Re: [PATCH 06/11] xfs: convey filesystem shutdown events to the health monitor

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Jan 13, 2026 at 05:14:42PM +0100, Christoph Hellwig wrote:
> On Mon, Jan 12, 2026 at 04:34:07PM -0800, Darrick J. Wong wrote:
> > -		/* mount */
> > +		/* shutdown */
> 
> huh?

Oh, heh.  That part of the union isn't needed until this patch, so I'll
move its definition to this patch.

> > @@ -497,14 +498,13 @@ xfs_fs_goingdown(
> >   */
> >  void
> >  xfs_do_force_shutdown(
> > -	struct xfs_mount *mp,
> > -	uint32_t	flags,
> > -	char		*fname,
> > -	int		lnnum)
> > +	struct xfs_mount	*mp,
> > +	uint32_t		flags,
> > +	char			*fname,
> > +	int			lnnum)
> >  {
> > -	int		tag;
> > -	const char	*why;
> > -
> > +	int			tag;
> > +	const char		*why;
> 
> I like this cleanup, but it seems to be entirely unrelated to
> the rest of the patch?

Yeah.  I think it was needed back when xfs_do_force_shutdown actually
had to call xfs_healthmon_get to make the new variables line up, but
now that the change is a oneliner I'll revert these whitspace cleanups.

--D