From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C536280331; Wed, 14 Jan 2026 14:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768400984; cv=none; b=dZKiIbVtSKgtTQZP0SoI7QGt2Z/lX+Enjf4EG2Bwg1uR+QwKOuFKjYmg7g61CDgSdyEZ2eSFnxHqzR0cg53GhyuSP5c1x8Q7BlbfaQVo2V4loTXujPwhLkcECC8OsT3vFCFxY4IrvJln1R1NaXiHXKnfHUp2k+z7QYOpgMuQWE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768400984; c=relaxed/simple; bh=WULodj3ndaifHU9DlNb0w1E7YxSNfz8+hYky6+hNjMA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CK+LR3s0TirIbr9NXF6ft/oTgObPsJxW/BcPU3CTKdsdzlf63MNCc1AzBOBfxQOvROkLoVjLeJgdlG9d+ddKgbS2K+JuNFCEfHan9FLvk+nKfbZsM5WpvOmrRrCeHGDifruLdfRQSqYlrdIsF8UWQNlVNNFdFQfKfRoz6IkYyhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qQcASKik; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qQcASKik" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 925D2C16AAE; Wed, 14 Jan 2026 14:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768400983; bh=WULodj3ndaifHU9DlNb0w1E7YxSNfz8+hYky6+hNjMA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qQcASKikIFysF55OsSDcLno6yPsldbqIszQl5E9VrtpQHdVb0ueVNZjDSyhD4x+/b 4NWDpfONF7ieJYp8N0+ve/gPVwvXg3H9/oSgPmZXo7RrjmqLyG9VkuG7G0TZ44D2T+ AAlZWd194y41zqrtroByvI0v60owrooxlsgFAPxO5O17qQz3oULXxTh6NCPrlqxUqH 8gSomo7NxfWXQZ6NcsBLGCIHLX5ZM1HeFxYHoilmIeLAWsEmAW1YNj9j//PoJZXYJm cQ19Z0pW0LY27EtsP7lfGSoyTOwX9Z+Rwf/BpNWZofdgj2XYMq9zWYyOxRVyEhILPW SO6qOgIBsk0Wg== From: Chuck Lever To: vira, Christian Brauner , Jan Kara Cc: , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org, , linux-f2fs-devel@lists.sourceforge.net, hirofumi@mail.parknet.co.jp, linkinjeon@kernel.org, sj1557.seo@samsung.com, yuezhang.mo@sony.com, almaz.alexandrovich@paragon-software.com, slava@dubeyko.com, glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu, adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org, pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com, trondmy@kernel.org, anna@kernel.org, jaegeuk@kernel.org, chao@kernel.org, hansg@kernel.org, senozhatsky@chromium.org, Chuck Lever Subject: [PATCH v4 16/16] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION Date: Wed, 14 Jan 2026 09:28:59 -0500 Message-ID: <20260114142900.3945054-17-cel@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260114142900.3945054-1-cel@kernel.org> References: <20260114142900.3945054-1-cel@kernel.org> Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever ksmbd hard-codes FILE_CASE_SENSITIVE_SEARCH and FILE_CASE_PRESERVED_NAMES in FS_ATTRIBUTE_INFORMATION responses, incorrectly indicating all exports are case-sensitive. This breaks clients accessing case-insensitive filesystems like exFAT or ext4/f2fs directories with casefold enabled. Query actual case behavior via vfs_fileattr_get() and report accurate attributes to SMB clients. Filesystems without ->fileattr_get continue reporting default POSIX behavior (case-sensitive, case-preserving). SMB's FS_ATTRIBUTE_INFORMATION reports per-share attributes from the share root, not per-file. Shares mixing casefold and non-casefold directories report the root directory's behavior. Acked-by: Namjae Jeon Signed-off-by: Chuck Lever --- fs/smb/server/smb2pdu.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 2fcd0d4d1fb0..f579093bb418 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -13,6 +13,7 @@ #include #include #include +#include #include "glob.h" #include "smbfsctl.h" @@ -5486,16 +5487,28 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work, case FS_ATTRIBUTE_INFORMATION: { FILE_SYSTEM_ATTRIBUTE_INFO *info; + struct file_kattr fa = {}; size_t sz; + u32 attrs; + int err; info = (FILE_SYSTEM_ATTRIBUTE_INFO *)rsp->Buffer; - info->Attributes = cpu_to_le32(FILE_SUPPORTS_OBJECT_IDS | - FILE_PERSISTENT_ACLS | - FILE_UNICODE_ON_DISK | - FILE_CASE_PRESERVED_NAMES | - FILE_CASE_SENSITIVE_SEARCH | - FILE_SUPPORTS_BLOCK_REFCOUNTING); + attrs = FILE_SUPPORTS_OBJECT_IDS | + FILE_PERSISTENT_ACLS | + FILE_UNICODE_ON_DISK | + FILE_SUPPORTS_BLOCK_REFCOUNTING; + err = vfs_fileattr_get(path.dentry, &fa); + if (err && err != -ENOIOCTLCMD) { + path_put(&path); + return err; + } + if (!fa.case_insensitive) + attrs |= FILE_CASE_SENSITIVE_SEARCH; + if (!fa.case_nonpreserving) + attrs |= FILE_CASE_PRESERVED_NAMES; + + info->Attributes = cpu_to_le32(attrs); info->Attributes |= cpu_to_le32(server_conf.share_fake_fscaps); if (test_share_config_flag(work->tcon->share_conf, -- 2.52.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2842CD37E39 for ; Wed, 14 Jan 2026 14:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:References:In-Reply-To: Message-ID:Date:To:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9mRLz0U+gjhvrnybucBoAYq1dSzJz4wO3cJlVmN5nO4=; b=mfCl9SHv/kBCgHBN9hyEdiPfGz gukCcToD650CKzQjAl4bpPuPlNMQz+DLxMKyTNl35hGxQav/JaLmdAQ/xwUMzkyhrqWgg8/3QhnZw vrVAlJAlqnJC4ivkmVho1fbGixqnuJNHH46WBmw/LHh9Urqoz8K7rqvFs9liymguKJtw=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vg1sd-0008R6-R7; Wed, 14 Jan 2026 14:29:51 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vg1sc-0008Qx-Fc for linux-f2fs-devel@lists.sourceforge.net; Wed, 14 Jan 2026 14:29:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ApZQEDMH+pKncNXBOdm4bTdpW/JwLXyA2ITsKgSmFcA=; b=OLLCs+4ccB3FoIpkGcDgeL4haW Ag9mdywu2zrExt9AnV8sEGKmCnF78Aq8COp7QuoY6QsHdoaUAA8ZEYgD96V91kglJtOWNIuEReYbP agp9EnhINNteZ27OuH8hooRmSOdbaySBk0RQkwjhVKJwe9WamKF72R3WFez4fypqO13U=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ApZQEDMH+pKncNXBOdm4bTdpW/JwLXyA2ITsKgSmFcA=; b=VzcYkHRoQKIrj13okRyRxz/wT8 V9Y7yBtYRec+KtNdnIzYKuslYJiGnRMQ8PkbmXdVpsfNXy9zB8xnHWVIYWc7g7eJW0gcP2qMJ/sqV 9KWUCWHmxuZy9bpvtqkehy6VntceuTdetcDVpYc9UonTLbvct4chRU2AeLdSXtNV9jOk=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vg1sb-0001Hl-MH for linux-f2fs-devel@lists.sourceforge.net; Wed, 14 Jan 2026 14:29:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 0D37860128; Wed, 14 Jan 2026 14:29:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 925D2C16AAE; Wed, 14 Jan 2026 14:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768400983; bh=WULodj3ndaifHU9DlNb0w1E7YxSNfz8+hYky6+hNjMA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qQcASKikIFysF55OsSDcLno6yPsldbqIszQl5E9VrtpQHdVb0ueVNZjDSyhD4x+/b 4NWDpfONF7ieJYp8N0+ve/gPVwvXg3H9/oSgPmZXo7RrjmqLyG9VkuG7G0TZ44D2T+ AAlZWd194y41zqrtroByvI0v60owrooxlsgFAPxO5O17qQz3oULXxTh6NCPrlqxUqH 8gSomo7NxfWXQZ6NcsBLGCIHLX5ZM1HeFxYHoilmIeLAWsEmAW1YNj9j//PoJZXYJm cQ19Z0pW0LY27EtsP7lfGSoyTOwX9Z+Rwf/BpNWZofdgj2XYMq9zWYyOxRVyEhILPW SO6qOgIBsk0Wg== To: vira, Christian Brauner , Jan Kara Date: Wed, 14 Jan 2026 09:28:59 -0500 Message-ID: <20260114142900.3945054-17-cel@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260114142900.3945054-1-cel@kernel.org> References: <20260114142900.3945054-1-cel@kernel.org> MIME-Version: 1.0 X-Headers-End: 1vg1sb-0001Hl-MH Subject: [f2fs-dev] [PATCH v4 16/16] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chuck Lever via Linux-f2fs-devel Reply-To: Chuck Lever Cc: pc@manguebit.org, yuezhang.mo@sony.com, cem@kernel.org, almaz.alexandrovich@paragon-software.com, adilger.kernel@dilger.ca, linux-cifs@vger.kernel.org, sfrench@samba.org, slava@dubeyko.com, linux-ext4@vger.kernel.org, linkinjeon@kernel.org, sprasad@microsoft.com, frank.li@vivo.com, ronniesahlberg@gmail.com, glaubitz@physik.fu-berlin.de, jaegeuk@kernel.org, hirofumi@mail.parknet.co.jp, linux-nfs@vger.kernel.org, tytso@mit.edu, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, senozhatsky@chromium.org, Chuck Lever , hansg@kernel.org, anna@kernel.org, linux-fsdevel@vger.kernel.org, sj1557.seo@samsung.com, trondmy@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net From: Chuck Lever ksmbd hard-codes FILE_CASE_SENSITIVE_SEARCH and FILE_CASE_PRESERVED_NAMES in FS_ATTRIBUTE_INFORMATION responses, incorrectly indicating all exports are case-sensitive. This breaks clients accessing case-insensitive filesystems like exFAT or ext4/f2fs directories with casefold enabled. Query actual case behavior via vfs_fileattr_get() and report accurate attributes to SMB clients. Filesystems without ->fileattr_get continue reporting default POSIX behavior (case-sensitive, case-preserving). SMB's FS_ATTRIBUTE_INFORMATION reports per-share attributes from the share root, not per-file. Shares mixing casefold and non-casefold directories report the root directory's behavior. Acked-by: Namjae Jeon Signed-off-by: Chuck Lever --- fs/smb/server/smb2pdu.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 2fcd0d4d1fb0..f579093bb418 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -13,6 +13,7 @@ #include #include #include +#include #include "glob.h" #include "smbfsctl.h" @@ -5486,16 +5487,28 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work, case FS_ATTRIBUTE_INFORMATION: { FILE_SYSTEM_ATTRIBUTE_INFO *info; + struct file_kattr fa = {}; size_t sz; + u32 attrs; + int err; info = (FILE_SYSTEM_ATTRIBUTE_INFO *)rsp->Buffer; - info->Attributes = cpu_to_le32(FILE_SUPPORTS_OBJECT_IDS | - FILE_PERSISTENT_ACLS | - FILE_UNICODE_ON_DISK | - FILE_CASE_PRESERVED_NAMES | - FILE_CASE_SENSITIVE_SEARCH | - FILE_SUPPORTS_BLOCK_REFCOUNTING); + attrs = FILE_SUPPORTS_OBJECT_IDS | + FILE_PERSISTENT_ACLS | + FILE_UNICODE_ON_DISK | + FILE_SUPPORTS_BLOCK_REFCOUNTING; + err = vfs_fileattr_get(path.dentry, &fa); + if (err && err != -ENOIOCTLCMD) { + path_put(&path); + return err; + } + if (!fa.case_insensitive) + attrs |= FILE_CASE_SENSITIVE_SEARCH; + if (!fa.case_nonpreserving) + attrs |= FILE_CASE_PRESERVED_NAMES; + + info->Attributes = cpu_to_le32(attrs); info->Attributes |= cpu_to_le32(server_conf.share_fake_fscaps); if (test_share_config_flag(work->tcon->share_conf, -- 2.52.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel