From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Tom Herbert <therbert@google.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 net 2/2] fou: Don't allow 0 for FOU_ATTR_IPPROTO.
Date: Wed, 14 Jan 2026 19:40:45 -0800 [thread overview]
Message-ID: <20260114194045.2916ef4e@kernel.org> (raw)
In-Reply-To: <CAAVpQUD9um80LD36osX4SuFk0BmkViHsPbKnFFXy=KtYoT_Z6g@mail.gmail.com>
On Tue, 13 Jan 2026 23:15:42 -0800 Kuniyuki Iwashima wrote:
> Btw I needed the change below to generate the diff above
> by "./tools/net/ynl/ynl-regen.sh -f". Maybe depending on
>
>
> diff --git a/tools/net/ynl/ynl-regen.sh b/tools/net/ynl/ynl-regen.sh
> index 81b4ecd891006..fda5fe24cfd47 100755
> --- a/tools/net/ynl/ynl-regen.sh
> +++ b/tools/net/ynl/ynl-regen.sh
> @@ -29,9 +29,9 @@ for f in $files; do
> continue
> fi
>
> - echo -e "\tGEN ${params[2]}\t$f"
> - $TOOL --cmp-out --mode ${params[2]} --${params[3]} \
> - --spec $KDIR/${params[0]} $args -o $f
> + echo -e "\tGEN ${params[5]}\t$f"
> + $TOOL --cmp-out --mode ${params[4]} --${params[5]} \
> + --spec $KDIR/${params[1]} $args -o $f
> done
>
> popd >>/dev/null
>
>
> fwiw, $params were like
>
> 3- Documentation/netlink/specs/fou.yaml
> 4: YNL-GEN kernel source
> --
> 3- Documentation/netlink/specs/fou.yaml
> 4: YNL-GEN kernel header
Hm, I guess you have grep.lineNumber enabled in your git config?
Could you see if tossing --no-line-number into the git grep
in this script fixes it for you and if yes send a patch?
next prev parent reply other threads:[~2026-01-15 3:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 20:06 [PATCH v1 net 0/2] fou/gue: Fix skb memleak with inner protocol 0 Kuniyuki Iwashima
2026-01-12 20:06 ` [PATCH v1 net 1/2] gue: Fix skb memleak with inner IP " Kuniyuki Iwashima
2026-01-12 20:27 ` Eric Dumazet
2026-01-12 20:06 ` [PATCH v1 net 2/2] fou: Don't allow 0 for FOU_ATTR_IPPROTO Kuniyuki Iwashima
2026-01-12 20:25 ` Eric Dumazet
2026-01-14 3:11 ` Jakub Kicinski
2026-01-14 7:15 ` Kuniyuki Iwashima
2026-01-15 3:40 ` Jakub Kicinski [this message]
2026-01-15 7:43 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114194045.2916ef4e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.