From: Rob Herring <robh@kernel.org>
To: Binbin Zhou <zhoubb.aaron@gmail.com>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org,
Xiaochuang Mao <maoxiaochuan@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org,
Keguang Zhang <keguang.zhang@gmail.com>
Subject: Re: [PATCH v2 2/3] dt-binding: rtc: loongson: Document Loongson-2K0300 compatible
Date: Wed, 14 Jan 2026 14:58:55 -0600 [thread overview]
Message-ID: <20260114205855.GA3190839-robh@kernel.org> (raw)
In-Reply-To: <CAMpQs4LpKSLGKySmzHeysS3x78inUQy9DF4dShneNymDvAi4Ew@mail.gmail.com>
On Wed, Jan 07, 2026 at 09:22:41AM +0800, Binbin Zhou wrote:
> Hi Rob:
>
> Thanks for your review.
>
> On Wed, Jan 7, 2026 at 3:13 AM Rob Herring <robh@kernel.org> wrote:
> >
> > On Tue, Jan 06, 2026 at 09:33:32AM +0800, Binbin Zhou wrote:
> > > Add "loongson,ls2k0300-rtc" dedicated compatible to represent the RTC
> > > interface of the Loongson-2K0300 chip.
> > >
> > > Its hardware design is similar to that of the Loongson-1B, but it does
> > > not support the alarm feature.
> >
> > But you are requiring the interrupt property for it? Isn't it no alarm
> > feature means no interrupt?
>
> Yes, the `interrupts` attribute is not required without the alarm feature.
>
> But my judgment condition is `not contains` (added in patch-1[1]).
> There are only a few SoCs on the Loongson platform that don't support
> the RTC alarm feature, so I think `not contains` looks cleaner and
> simpler.
I should have said allowing rather than requiring.
You are allowing (though not requiring) 'interrupts' for Loongson-1B and
Loongson-2K0300. In patch 1, you made it required for other platforms
which is an ABI change. That's fine if it was a mistake and is truly
required.
Rob
next prev parent reply other threads:[~2026-01-14 20:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 1:33 [PATCH v2 0/3] RTC: Add Loongson-2K0300 support Binbin Zhou
2026-01-06 1:33 ` [PATCH v2 1/3] dt-binding: rtc: loongson: Correct Loongson-1C interrupts property Binbin Zhou
2026-01-06 1:33 ` [PATCH v2 2/3] dt-binding: rtc: loongson: Document Loongson-2K0300 compatible Binbin Zhou
2026-01-06 19:13 ` Rob Herring
2026-01-07 1:22 ` Binbin Zhou
2026-01-14 20:58 ` Rob Herring [this message]
2026-01-15 7:38 ` Binbin Zhou
2026-01-15 17:00 ` Rob Herring
2026-01-16 1:14 ` Binbin Zhou
2026-01-06 1:33 ` [PATCH v2 3/3] rtc: loongson: Add Loongson-2K0300 support Binbin Zhou
2026-01-06 2:48 ` [PATCH v2 0/3] RTC: " Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114205855.GA3190839-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=keguang.zhang@gmail.com \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maoxiaochuan@loongson.cn \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.