From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
Carlos Maiolino <cem@kernel.org>, Qu Wenruo <wqu@suse.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 06/14] iomap: fix submission side handling of completion side errors
Date: Thu, 15 Jan 2026 07:17:27 +0100 [thread overview]
Message-ID: <20260115061727.GD9205@lst.de> (raw)
In-Reply-To: <20260114223558.GK15551@frogsfrogsfrogs>
On Wed, Jan 14, 2026 at 02:35:58PM -0800, Darrick J. Wong wrote:
> On Wed, Jan 14, 2026 at 08:41:04AM +0100, Christoph Hellwig wrote:
> > The "if (dio->error)" in iomap_dio_bio_iter exists to stop submitting
> > more bios when a completion already return an error. Commit cfe057f7db1f
> > ("iomap_dio_actor(): fix iov_iter bugs") made it revert the iov by
> > "copied", which is very wrong given that we've already consumed that
> > range and submitted a bio for it.
>
> Is it possible for the error to be ENOTBLK and the caller wants to fall
> back to buffered IO? I /think/ the answer is "no" because only the
> ->iomap_begin methods (and therefore iomap_iter()) should be doing that,
> and we mask the ENOTBLK and pretend it's a short write. Right?
Yeah, returning that on completion is too late to fall back, because
the iov_iter is already consumed.
next prev parent reply other threads:[~2026-01-15 6:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 7:40 bounce buffer direct I/O when stable pages are required Christoph Hellwig
2026-01-14 7:40 ` [PATCH 01/14] block: refactor get_contig_folio_len Christoph Hellwig
2026-01-14 7:41 ` [PATCH 02/14] block: open code bio_add_page and fix handling of mismatching P2P ranges Christoph Hellwig
2026-01-14 12:46 ` Johannes Thumshirn
2026-01-14 13:01 ` hch
2026-01-14 7:41 ` [PATCH 03/14] iov_iter: extract a iov_iter_extract_bvecs helper from bio code Christoph Hellwig
2026-01-14 7:41 ` [PATCH 04/14] block: remove bio_release_page Christoph Hellwig
2026-01-14 7:41 ` [PATCH 05/14] block: add helpers to bounce buffer an iov_iter into bios Christoph Hellwig
2026-01-14 12:51 ` Johannes Thumshirn
2026-01-14 7:41 ` [PATCH 06/14] iomap: fix submission side handling of completion side errors Christoph Hellwig
2026-01-14 22:35 ` Darrick J. Wong
2026-01-15 6:17 ` Christoph Hellwig [this message]
2026-01-14 7:41 ` [PATCH 07/14] iomap: simplify iomap_dio_bio_iter Christoph Hellwig
2026-01-14 22:51 ` Darrick J. Wong
2026-01-15 6:20 ` Christoph Hellwig
2026-01-14 7:41 ` [PATCH 08/14] iomap: split out the per-bio logic from iomap_dio_bio_iter Christoph Hellwig
2026-01-14 22:53 ` Darrick J. Wong
2026-01-14 7:41 ` [PATCH 09/14] iomap: share code between iomap_dio_bio_end_io and iomap_finish_ioend_direct Christoph Hellwig
2026-01-14 22:54 ` Darrick J. Wong
2026-01-14 7:41 ` [PATCH 10/14] iomap: free the bio before completing the dio Christoph Hellwig
2026-01-14 22:55 ` Darrick J. Wong
2026-01-15 6:21 ` Christoph Hellwig
2026-01-14 7:41 ` [PATCH 11/14] iomap: rename IOMAP_DIO_DIRTY to IOMAP_DIO_USER_BACKED Christoph Hellwig
2026-01-14 22:56 ` Darrick J. Wong
2026-01-14 7:41 ` [PATCH 12/14] iomap: support ioends for direct reads Christoph Hellwig
2026-01-14 22:57 ` Darrick J. Wong
2026-01-15 6:21 ` Christoph Hellwig
2026-01-14 7:41 ` [PATCH 13/14] iomap: add a flag to bounce buffer direct I/O Christoph Hellwig
2026-01-14 22:59 ` Darrick J. Wong
2026-01-15 6:21 ` Christoph Hellwig
2026-01-14 7:41 ` [PATCH 14/14] xfs: use bounce buffering direct I/O when the device requires stable pages Christoph Hellwig
2026-01-14 23:07 ` Darrick J. Wong
2026-01-15 6:24 ` Christoph Hellwig
2026-01-14 9:52 ` bounce buffer direct I/O when stable pages are required Qu Wenruo
2026-01-14 12:39 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2026-01-19 7:44 bounce buffer direct I/O when stable pages are required v2 Christoph Hellwig
2026-01-19 7:44 ` [PATCH 06/14] iomap: fix submission side handling of completion side errors Christoph Hellwig
2026-01-19 17:40 ` Darrick J. Wong
2026-01-23 8:54 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115061727.GD9205@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.