All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>, "John Snow" <jsnow@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	qemu-block@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v3 12/14] tests: fix check for sudo access in LUKS I/O test
Date: Thu, 15 Jan 2026 16:47:54 +0000	[thread overview]
Message-ID: <20260115164756.799402-13-berrange@redhat.com> (raw)
In-Reply-To: <20260115164756.799402-1-berrange@redhat.com>

The test did not cope with the possibility that 'sudo' was not installed
at all, merely that it was not configured. This broke tests in any CI
env which lacks 'sudo'.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/qemu-iotests/149 | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/tests/qemu-iotests/149 b/tests/qemu-iotests/149
index c13343d7ef..6dff39a28a 100755
--- a/tests/qemu-iotests/149
+++ b/tests/qemu-iotests/149
@@ -95,11 +95,14 @@ def verify_passwordless_sudo():
 
     args = ["sudo", "-n", "/bin/true"]
 
-    proc = subprocess.Popen(args,
-                            stdin=subprocess.PIPE,
-                            stdout=subprocess.PIPE,
-                            stderr=subprocess.STDOUT,
-                            universal_newlines=True)
+    try:
+        proc = subprocess.Popen(args,
+                                stdin=subprocess.PIPE,
+                                stdout=subprocess.PIPE,
+                                stderr=subprocess.STDOUT,
+                                universal_newlines=True)
+    except FileNotFoundError as e:
+        iotests.notrun('requires sudo binary: %s' % e)
 
     msg = proc.communicate()[0]
 
-- 
2.52.0



  parent reply	other threads:[~2026-01-15 16:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 16:47 [PATCH v3 00/14] tests: do more testing of block drivers Daniel P. Berrangé
2026-01-15 16:47 ` [PATCH v3 01/14] Revert "python/aqmp: fix send_fd_scm for python 3.6.x" Daniel P. Berrangé
2026-01-20 18:32   ` John Snow
2026-01-15 16:47 ` [PATCH v3 02/14] tests: print reason when I/O test is skipped in TAP mode Daniel P. Berrangé
2026-01-15 16:47 ` [PATCH v3 03/14] tests: remove redundant meson suite for iotests Daniel P. Berrangé
2026-01-15 16:47 ` [PATCH v3 04/14] tests: ensure all qcow2 I/O tests are able to be run via make Daniel P. Berrangé
2026-01-15 16:47 ` [PATCH v3 05/14] scripts/mtest2make: ensure output has stable sorting Daniel P. Berrangé
2026-01-15 16:47 ` [PATCH v3 06/14] scripts/mtest2make: support optional tests grouping Daniel P. Berrangé
2026-01-15 16:47 ` [PATCH v3 07/14] tests: add a meson suite / make target per block I/O tests format Daniel P. Berrangé
2026-01-15 16:47 ` [PATCH v3 08/14] docs/devel/testing: expand documentation for 'make check-block' Daniel P. Berrangé
2026-01-15 16:47 ` [PATCH v3 09/14] tests: add nbd and luks to the I/O test suites Daniel P. Berrangé
2026-01-16  7:42   ` Thomas Huth
2026-01-15 16:47 ` [PATCH v3 10/14] tests: use 'driver' as collective term for either format or protocol Daniel P. Berrangé
2026-01-16  7:44   ` Thomas Huth
2026-01-15 16:47 ` [PATCH v3 11/14] tests: validate dmsetup result in test 128 Daniel P. Berrangé
2026-01-16  7:45   ` Thomas Huth
2026-01-15 16:47 ` Daniel P. Berrangé [this message]
2026-01-15 16:47 ` [PATCH v3 13/14] tests: add QEMU_TEST_IO_SKIP for skipping I/O tests Daniel P. Berrangé
2026-01-15 16:47 ` [PATCH v3 14/14] gitlab: add jobs for thorough block tests Daniel P. Berrangé
2026-01-16  7:53   ` Thomas Huth
2026-01-16  9:49     ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260115164756.799402-13-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=crosa@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.