Re: [RFC PATCH v5 7/7] net: wwan: hwsim: support NMEA port emulation

[kernel test robot <lkp@intel.com>]

Hi Sergey,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on wireless-next/main]
[also build test ERROR on wireless/main net-next/main net/main linus/master v6.19-rc5 next-20260115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sergey-Ryazanov/net-wwan-core-remove-unused-port_id-field/20260109-091432
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link:    https://lore.kernel.org/r/20260109010909.4216-8-ryazanov.s.a%40gmail.com
patch subject: [RFC PATCH v5 7/7] net: wwan: hwsim: support NMEA port emulation
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20260115/202601152253.zyvd4WRp-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260115/202601152253.zyvd4WRp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601152253.zyvd4WRp-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/wwan/wwan_hwsim.c: In function 'wwan_hwsim_nmea_emul_timer':
>> drivers/net/wwan/wwan_hwsim.c:239:40: error: implicit declaration of function 'from_timer'; did you mean 'mod_timer'? [-Wimplicit-function-declaration]
     239 |         struct wwan_hwsim_port *port = from_timer(port, t, nmea_emul.timer);
         |                                        ^~~~~~~~~~
         |                                        mod_timer
>> drivers/net/wwan/wwan_hwsim.c:239:60: error: 'nmea_emul' undeclared (first use in this function)
     239 |         struct wwan_hwsim_port *port = from_timer(port, t, nmea_emul.timer);
         |                                                            ^~~~~~~~~
   drivers/net/wwan/wwan_hwsim.c:239:60: note: each undeclared identifier is reported only once for each function it appears in


vim +239 drivers/net/wwan/wwan_hwsim.c

   233	
   234	static void wwan_hwsim_nmea_emul_timer(struct timer_list *t)
   235	{
   236		/* 43.74754722298909 N 11.25759835922875 E in DMM format */
   237		static const unsigned int coord[4 * 2] = { 43, 44, 8528, 0,
   238							   11, 15, 4559, 0 };
 > 239		struct wwan_hwsim_port *port = from_timer(port, t, nmea_emul.timer);
   240		struct sk_buff *skb;
   241		struct tm tm;
   242	
   243		time64_to_tm(ktime_get_real_seconds(), 0, &tm);
   244	
   245		mod_timer(&port->nmea_emul.timer, jiffies + HZ);	/* 1 second */
   246	
   247		skb = alloc_skb(NMEA_MAX_LEN * 2, GFP_KERNEL);	/* GGA + RMC */
   248		if (!skb)
   249			return;
   250	
   251		wwan_hwsim_nmea_skb_push_sentence(skb,
   252						  "$GPGGA,%02u%02u%02u.000,%02u%02u.%04u,%c,%03u%02u.%04u,%c,1,7,1.03,176.2,M,55.2,M,,",
   253						  tm.tm_hour, tm.tm_min, tm.tm_sec,
   254						  coord[0], coord[1], coord[2],
   255						  coord[3] ? 'S' : 'N',
   256						  coord[4], coord[5], coord[6],
   257						  coord[7] ? 'W' : 'E');
   258	
   259		wwan_hwsim_nmea_skb_push_sentence(skb,
   260						  "$GPRMC,%02u%02u%02u.000,A,%02u%02u.%04u,%c,%03u%02u.%04u,%c,0.02,31.66,%02u%02u%02u,,,A",
   261						  tm.tm_hour, tm.tm_min, tm.tm_sec,
   262						  coord[0], coord[1], coord[2],
   263						  coord[3] ? 'S' : 'N',
   264						  coord[4], coord[5], coord[6],
   265						  coord[7] ? 'W' : 'E',
   266						  tm.tm_mday, tm.tm_mon + 1,
   267						  (unsigned int)tm.tm_year - 100);
   268	
   269		wwan_port_rx(port->wwan, skb);
   270	}
   271	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki