From: kernel test robot <lkp@intel.com>
To: Wei Fang <wei.fang@nxp.com>,
shenwei.wang@nxp.com, xiaoning.wang@nxp.com, frank.li@nxp.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, ast@kernel.org,
daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
sdf@fomichev.me
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, bpf@vger.kernel.org
Subject: Re: [PATCH v2 net-next 14/14] net: fec: add AF_XDP zero-copy support
Date: Fri, 16 Jan 2026 20:28:23 +0800 [thread overview]
Message-ID: <202601162115.ATDIXPBp-lkp@intel.com> (raw)
In-Reply-To: <20260116074027.1603841-15-wei.fang@nxp.com>
Hi Wei,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Wei-Fang/net-fec-add-fec_txq_trigger_xmit-helper/20260116-154834
base: net-next/main
patch link: https://lore.kernel.org/r/20260116074027.1603841-15-wei.fang%40nxp.com
patch subject: [PATCH v2 net-next 14/14] net: fec: add AF_XDP zero-copy support
config: arm-imx_v4_v5_defconfig (https://download.01.org/0day-ci/archive/20260116/202601162115.ATDIXPBp-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260116/202601162115.ATDIXPBp-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601162115.ATDIXPBp-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/freescale/fec_main.c:1040:4: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
1040 | default:
| ^
drivers/net/ethernet/freescale/fec_main.c:1040:4: note: insert 'break;' to avoid fall-through
1040 | default:
| ^
| break;
1 warning generated.
vim +1040 drivers/net/ethernet/freescale/fec_main.c
61a4427b955f79d drivers/net/ethernet/freescale/fec_main.c Nimrod Andy 2014-06-12 970
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 971 /* Init RX & TX buffer descriptors
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 972 */
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 973 static void fec_enet_bd_init(struct net_device *dev)
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 974 {
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 975 struct fec_enet_private *fep = netdev_priv(dev);
4d494cdc92b3b9a drivers/net/ethernet/freescale/fec_main.c Fugang Duan 2014-09-13 976 struct fec_enet_priv_tx_q *txq;
4d494cdc92b3b9a drivers/net/ethernet/freescale/fec_main.c Fugang Duan 2014-09-13 977 struct fec_enet_priv_rx_q *rxq;
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 978 struct bufdesc *bdp;
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 979 unsigned int i;
59d0f746564495c drivers/net/ethernet/freescale/fec_main.c Frank Li 2014-09-13 980 unsigned int q;
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 981
59d0f746564495c drivers/net/ethernet/freescale/fec_main.c Frank Li 2014-09-13 982 for (q = 0; q < fep->num_rx_queues; q++) {
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 983 /* Initialize the receive buffer descriptors. */
59d0f746564495c drivers/net/ethernet/freescale/fec_main.c Frank Li 2014-09-13 984 rxq = fep->rx_queue[q];
7355f2760620b38 drivers/net/ethernet/freescale/fec_main.c Troy Kisky 2016-02-05 985 bdp = rxq->bd.base;
4d494cdc92b3b9a drivers/net/ethernet/freescale/fec_main.c Fugang Duan 2014-09-13 986
7355f2760620b38 drivers/net/ethernet/freescale/fec_main.c Troy Kisky 2016-02-05 987 for (i = 0; i < rxq->bd.ring_size; i++) {
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 988
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 989 /* Initialize the BD for every fragment in the page. */
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 990 if (bdp->cbd_bufaddr)
5cfa30397bc3677 drivers/net/ethernet/freescale/fec_main.c Johannes Berg 2016-01-24 991 bdp->cbd_sc = cpu_to_fec16(BD_ENET_RX_EMPTY);
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 992 else
5cfa30397bc3677 drivers/net/ethernet/freescale/fec_main.c Johannes Berg 2016-01-24 993 bdp->cbd_sc = cpu_to_fec16(0);
7355f2760620b38 drivers/net/ethernet/freescale/fec_main.c Troy Kisky 2016-02-05 994 bdp = fec_enet_get_nextdesc(bdp, &rxq->bd);
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 995 }
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 996
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 997 /* Set the last buffer to wrap */
7355f2760620b38 drivers/net/ethernet/freescale/fec_main.c Troy Kisky 2016-02-05 998 bdp = fec_enet_get_prevdesc(bdp, &rxq->bd);
bd31490718b47d9 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2025-11-19 999 bdp->cbd_sc |= cpu_to_fec16(BD_ENET_RX_WRAP);
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 1000
7355f2760620b38 drivers/net/ethernet/freescale/fec_main.c Troy Kisky 2016-02-05 1001 rxq->bd.cur = rxq->bd.base;
59d0f746564495c drivers/net/ethernet/freescale/fec_main.c Frank Li 2014-09-13 1002 }
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 1003
59d0f746564495c drivers/net/ethernet/freescale/fec_main.c Frank Li 2014-09-13 1004 for (q = 0; q < fep->num_tx_queues; q++) {
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 1005 /* ...and the same for transmit */
59d0f746564495c drivers/net/ethernet/freescale/fec_main.c Frank Li 2014-09-13 1006 txq = fep->tx_queue[q];
7355f2760620b38 drivers/net/ethernet/freescale/fec_main.c Troy Kisky 2016-02-05 1007 bdp = txq->bd.base;
7355f2760620b38 drivers/net/ethernet/freescale/fec_main.c Troy Kisky 2016-02-05 1008 txq->bd.cur = bdp;
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 1009
7355f2760620b38 drivers/net/ethernet/freescale/fec_main.c Troy Kisky 2016-02-05 1010 for (i = 0; i < txq->bd.ring_size; i++) {
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1011 struct page *page;
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1012
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 1013 /* Initialize the BD for every fragment in the page. */
5cfa30397bc3677 drivers/net/ethernet/freescale/fec_main.c Johannes Berg 2016-01-24 1014 bdp->cbd_sc = cpu_to_fec16(0);
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1015
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1016 switch (txq->tx_buf[i].type) {
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1017 case FEC_TXBUF_T_SKB:
178e5f57a8d8f8f drivers/net/ethernet/freescale/fec_main.c Fugang Duan 2017-12-22 1018 if (bdp->cbd_bufaddr &&
178e5f57a8d8f8f drivers/net/ethernet/freescale/fec_main.c Fugang Duan 2017-12-22 1019 !IS_TSO_HEADER(txq, fec32_to_cpu(bdp->cbd_bufaddr)))
178e5f57a8d8f8f drivers/net/ethernet/freescale/fec_main.c Fugang Duan 2017-12-22 1020 dma_unmap_single(&fep->pdev->dev,
178e5f57a8d8f8f drivers/net/ethernet/freescale/fec_main.c Fugang Duan 2017-12-22 1021 fec32_to_cpu(bdp->cbd_bufaddr),
178e5f57a8d8f8f drivers/net/ethernet/freescale/fec_main.c Fugang Duan 2017-12-22 1022 fec16_to_cpu(bdp->cbd_datlen),
178e5f57a8d8f8f drivers/net/ethernet/freescale/fec_main.c Fugang Duan 2017-12-22 1023 DMA_TO_DEVICE);
af6f4791380c320 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2023-08-15 1024 dev_kfree_skb_any(txq->tx_buf[i].buf_p);
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1025 break;
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1026 case FEC_TXBUF_T_XDP_NDO:
20f797399035a80 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2023-07-06 1027 dma_unmap_single(&fep->pdev->dev,
20f797399035a80 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2023-07-06 1028 fec32_to_cpu(bdp->cbd_bufaddr),
20f797399035a80 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2023-07-06 1029 fec16_to_cpu(bdp->cbd_datlen),
20f797399035a80 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2023-07-06 1030 DMA_TO_DEVICE);
af6f4791380c320 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2023-08-15 1031 xdp_return_frame(txq->tx_buf[i].buf_p);
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1032 break;
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1033 case FEC_TXBUF_T_XDP_TX:
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1034 page = txq->tx_buf[i].buf_p;
65589e860a80369 drivers/net/ethernet/freescale/fec_main.c Byungchul Park 2025-07-21 1035 page_pool_put_page(pp_page_to_nmdesc(page)->pp,
f1d89a02b16bcdc drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1036 page, 0, false);
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1037 break;
f9806afd55c4ab1 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1038 case FEC_TXBUF_T_XSK_TX:
f9806afd55c4ab1 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1039 xsk_buff_free(txq->tx_buf[i].buf_p);
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 @1040 default:
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1041 break;
81725cc0fbfea44 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2026-01-16 1042 };
20f797399035a80 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2023-07-06 1043
af6f4791380c320 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2023-08-15 1044 txq->tx_buf[i].buf_p = NULL;
20f797399035a80 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2023-07-06 1045 /* restore default tx buffer type: FEC_TXBUF_T_SKB */
20f797399035a80 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2023-07-06 1046 txq->tx_buf[i].type = FEC_TXBUF_T_SKB;
5cfa30397bc3677 drivers/net/ethernet/freescale/fec_main.c Johannes Berg 2016-01-24 1047 bdp->cbd_bufaddr = cpu_to_fec32(0);
7355f2760620b38 drivers/net/ethernet/freescale/fec_main.c Troy Kisky 2016-02-05 1048 bdp = fec_enet_get_nextdesc(bdp, &txq->bd);
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 1049 }
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 1050
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 1051 /* Set the last buffer to wrap */
7355f2760620b38 drivers/net/ethernet/freescale/fec_main.c Troy Kisky 2016-02-05 1052 bdp = fec_enet_get_prevdesc(bdp, &txq->bd);
bd31490718b47d9 drivers/net/ethernet/freescale/fec_main.c Wei Fang 2025-11-19 1053 bdp->cbd_sc |= cpu_to_fec16(BD_ENET_TX_WRAP);
4d494cdc92b3b9a drivers/net/ethernet/freescale/fec_main.c Fugang Duan 2014-09-13 1054 txq->dirty_tx = bdp;
14109a59caf93e6 drivers/net/ethernet/freescale/fec.c Frank Li 2013-03-26 1055 }
59d0f746564495c drivers/net/ethernet/freescale/fec_main.c Frank Li 2014-09-13 1056 }
59d0f746564495c drivers/net/ethernet/freescale/fec_main.c Frank Li 2014-09-13 1057
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-01-16 12:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 7:40 [PATCH v2 net-next 00/14] net: fec: improve XDP copy mode and add AF_XDP zero-copy support Wei Fang
2026-01-16 7:40 ` [PATCH v2 net-next 01/14] net: fec: add fec_txq_trigger_xmit() helper Wei Fang
2026-01-16 7:40 ` [PATCH v2 net-next 02/14] net: fec: add fec_rx_error_check() to check RX errors Wei Fang
2026-01-16 7:40 ` [PATCH v2 net-next 03/14] net: fec: add rx_shift to indicate the extra bytes padded in front of RX frame Wei Fang
2026-01-16 7:40 ` [PATCH v2 net-next 04/14] net: fec: add fec_build_skb() to build a skb Wei Fang
2026-01-16 14:01 ` Frank Li
2026-01-16 7:40 ` [PATCH v2 net-next 05/14] net: fec: improve fec_enet_rx_queue() Wei Fang
2026-01-16 14:03 ` Frank Li
2026-01-16 7:40 ` [PATCH v2 net-next 06/14] net: fec: add fec_enet_rx_queue_xdp() for XDP path Wei Fang
2026-01-16 14:19 ` Frank Li
2026-01-17 2:32 ` Wei Fang
2026-01-16 7:40 ` [PATCH v2 net-next 07/14] net: fec: transmit XDP frames in bulk Wei Fang
2026-01-16 14:04 ` Frank Li
2026-01-16 7:40 ` [PATCH v2 net-next 08/14] net: fec: remove unnecessary NULL pointer check when clearing TX BD ring Wei Fang
2026-01-16 14:21 ` Frank Li
2026-01-16 7:40 ` [PATCH v2 net-next 09/14] net: fec: use switch statement to check the type of tx_buf Wei Fang
2026-01-16 7:40 ` [PATCH v2 net-next 10/14] net: fec: remove the size parameter from fec_enet_create_page_pool() Wei Fang
2026-01-16 14:26 ` Frank Li
2026-01-16 7:40 ` [PATCH v2 net-next 11/14] net: fec: move xdp_rxq_info* APIs out of fec_enet_create_page_pool() Wei Fang
2026-01-16 14:34 ` Frank Li
2026-01-20 6:39 ` Wei Fang
2026-01-16 7:40 ` [PATCH v2 net-next 12/14] net: fec: add fec_alloc_rxq_buffers_pp() to allocate buffers from page pool Wei Fang
2026-01-16 14:38 ` Frank Li
2026-01-17 2:16 ` Wei Fang
2026-01-20 7:30 ` Wei Fang
2026-01-16 7:40 ` [PATCH v2 net-next 13/14] net: fec: improve fec_enet_tx_queue() Wei Fang
2026-01-16 14:40 ` Frank Li
2026-01-16 7:40 ` [PATCH v2 net-next 14/14] net: fec: add AF_XDP zero-copy support Wei Fang
2026-01-16 12:28 ` kernel test robot [this message]
2026-01-16 14:47 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202601162115.ATDIXPBp-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frank.li@nxp.com \
--cc=hawk@kernel.org \
--cc=imx@lists.linux.dev \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.