From: Jakub Kicinski <kuba@kernel.org>
To: daniel@makrotopia.org
Cc: fchan@maxlinear.com, hkallweit1@gmail.com,
jpovazanec@maxlinear.com, yweng@maxlinear.com,
davem@davemloft.net, andrew@lunn.ch, linux@armlinux.org.uk,
edumazet@google.com, ajayaraman@maxlinear.com, john@phrozen.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
lrosu@maxlinear.com, bxu@maxlinear.com, pabeni@redhat.com
Subject: Re: [net-next] net: phy: intel-xway: workaround stale LEDs before link-up
Date: Sat, 17 Jan 2026 18:31:45 -0800 [thread overview]
Message-ID: <20260117183145.6f6a7d7e@kernel.org> (raw)
In-Reply-To: <20260118022907.1106701-1-kuba@kernel.org>
On Sat, 17 Jan 2026 18:29:07 -0800 Jakub Kicinski wrote:
> > @@ -286,8 +287,33 @@ static int xway_gphy_config_init(struct phy_device *phydev)
> > return err;
> >
> > /* Use default LED configuration if 'leds' node isn't defined */
> > - if (!of_get_child_by_name(np, "leds"))
> > + if (!of_get_child_by_name(np, "leds")) {
> > xway_gphy_init_leds(phydev);
> > + } else {
>
> Does this leak the device_node reference returned by of_get_child_by_name()?
Of course this is a pre-existing issue but could you fix it first
in net then proceed with this submission? Otherwise we'll have a
conflict.
next prev parent reply other threads:[~2026-01-18 2:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 23:40 [PATCH net-next] net: phy: intel-xway: workaround stale LEDs before link-up Daniel Golle
2026-01-16 1:23 ` Andrew Lunn
2026-01-16 2:06 ` Daniel Golle
2026-01-18 2:29 ` [net-next] " Jakub Kicinski
2026-01-18 2:31 ` Jakub Kicinski [this message]
2026-01-18 2:33 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260117183145.6f6a7d7e@kernel.org \
--to=kuba@kernel.org \
--cc=ajayaraman@maxlinear.com \
--cc=andrew@lunn.ch \
--cc=bxu@maxlinear.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fchan@maxlinear.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=jpovazanec@maxlinear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lrosu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yweng@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.