From: Jakub Kicinski <kuba@kernel.org>
To: Josua Mayer <josua@solid-run.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Mikhail Anikin <mikhail.anikin@solid-run.com>,
Rabeeh Khoury <rabeeh@solid-run.com>,
Yazan Shhady <yazan.shhady@solid-run.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: sfp: support 25G long-range modules (extended compliance code 0x3)
Date: Mon, 19 Jan 2026 11:30:18 -0800 [thread overview]
Message-ID: <20260119113018.48da59a2@kernel.org> (raw)
In-Reply-To: <20260118-sfp-25g-lr-v1-2-2daf48ffae7f@solid-run.com>
On Sun, 18 Jan 2026 16:07:38 +0200 Josua Mayer wrote:
> @@ -247,6 +247,7 @@ static void sfp_module_parse_support(struct sfp_bus *bus,
> case SFF8024_ECC_100GBASE_LR4_25GBASE_LR:
> case SFF8024_ECC_100GBASE_ER4_25GBASE_ER:
> phylink_set(modes, 100000baseLR4_ER4_Full);
> + phylink_set(modes, 25000baseLR_Full);
I _think_ the discussion here concluded that the patch is insufficient
/ DoA? Either way, I wanted to relay that AI code review points out
we may also want to set __set_bit(PHY_INTERFACE_MODE_25GBASER,
interfaces) here:
https://netdev-ai.bots.linux.dev/ai-review.html?id=c91c0f54-56d5-4356-89cd-b57cbb289495
next prev parent reply other threads:[~2026-01-19 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 14:07 [PATCH 0/2] net: sfp: support 25G long-range modules (extended compliance code 0x3) Josua Mayer
2026-01-18 14:07 ` [PATCH 1/2] net: ethtool: Add link mode for 25Gbps long-range fiber Josua Mayer
2026-01-18 14:07 ` [PATCH 2/2] net: sfp: support 25G long-range modules (extended compliance code 0x3) Josua Mayer
2026-01-18 16:01 ` Andrew Lunn
2026-01-19 7:30 ` Josua Mayer
2026-01-19 10:48 ` Russell King (Oracle)
2026-01-19 19:30 ` Jakub Kicinski [this message]
2026-01-21 9:44 ` Josua Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119113018.48da59a2@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=josua@solid-run.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mikhail.anikin@solid-run.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rabeeh@solid-run.com \
--cc=yazan.shhady@solid-run.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.