From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemb@google.com>
Cc: Kevin Yang <yyd@google.com>,
Harshitha Ramamurthy <hramamurthy@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Joshua Washington <joshwash@google.com>,
Gerhard Engleder <gerhard@engleder-embedded.com>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: extend ndo_get_tstamp for other timestamp types
Date: Mon, 19 Jan 2026 11:57:10 -0800 [thread overview]
Message-ID: <20260119115710.6fdde8c0@kernel.org> (raw)
In-Reply-To: <20260115222300.1116386-1-yyd@google.com>
On Thu, 15 Jan 2026 22:22:59 +0000 Kevin Yang wrote:
> Reviewed-by: Willem de Bruijn <willemb@google.com>
Other than expediency why implementing this in drivers makes sense?
There will be very little driver specific logic here.
After thinking about it for 1 minute my intuition would be for drivers
to just expose necessary information, in-kernel consumers should
"enable" the sync for all netdevs during init, and then convert
the timestamps into REALTIME / MONOTONIC by calling some helper?
Also AI code review says:
> + mult = mult_frac(GVE_HWTS_REAL_CC_NOMINAL,
> + real_ns - priv->ts_real.last_sync_ns,
> + priv->last_sync_nic_counter - prev_nic);
Can this divide by zero?
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-19 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 22:22 [PATCH net-next 1/2] net: extend ndo_get_tstamp for other timestamp types Kevin Yang
2026-01-15 22:23 ` [PATCH net-next 2/2] gve: implement ndo_get_tstamp Kevin Yang
2026-01-16 20:36 ` [PATCH net-next 1/2] net: extend ndo_get_tstamp for other timestamp types Gerhard Engleder
2026-01-20 18:20 ` Kevin Yang
2026-01-19 19:57 ` Jakub Kicinski [this message]
2026-01-20 18:23 ` Kevin Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119115710.6fdde8c0@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gerhard@engleder-embedded.com \
--cc=hramamurthy@google.com \
--cc=joshwash@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=willemb@google.com \
--cc=yyd@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.