All of lore.kernel.org
 help / color / mirror / Atom feed
From: cem@kernel.org
To: aalbersh@redhat.com
Cc: linux-xfs@vger.kernel.org, djwong@kernel.org
Subject: [RFC PATCH 1/2] libfrog: make xfrog_defragrange return a positive valued
Date: Mon, 19 Jan 2026 15:26:50 +0100	[thread overview]
Message-ID: <20260119142724.284933-2-cem@kernel.org> (raw)
In-Reply-To: <20260119142724.284933-1-cem@kernel.org>

From: Carlos Maiolino <cem@kernel.org>

Currently, the only user for xfrog_defragrange is xfs_fsr's packfile(),
which expects error to be a positive value.

Whenever xfrog_defragrange fails, the switch case always falls into the
default clausule, making the error message pointless.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
 libfrog/file_exchange.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libfrog/file_exchange.c b/libfrog/file_exchange.c
index e6c3f486b0ff..31bbc6da60c3 100644
--- a/libfrog/file_exchange.c
+++ b/libfrog/file_exchange.c
@@ -232,7 +232,7 @@ xfrog_defragrange(
 	if (ret) {
 		if (errno == EOPNOTSUPP || errno != ENOTTY)
 			goto legacy_fallback;
-		return -errno;
+		return errno;
 	}
 
 	return 0;
@@ -240,7 +240,7 @@ xfrog_defragrange(
 legacy_fallback:
 	ret = xfrog_ioc_swapext(file2_fd, xdf);
 	if (ret)
-		return -errno;
+		return errno;
 
 	return 0;
 }
-- 
2.52.0


  reply	other threads:[~2026-01-19 14:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 14:26 [RFC PATCH 0/2] Improve user experience with xfs_fsr cem
2026-01-19 14:26 ` cem [this message]
2026-01-20 17:20   ` [RFC PATCH 1/2] libfrog: make xfrog_defragrange return a positive valued Darrick J. Wong
2026-01-21  8:57     ` Carlos Maiolino
2026-01-21 17:42       ` Darrick J. Wong
2026-01-19 14:26 ` [RFC PATCH 2/2] fsr: Always print error messages from xfrog_defragrange() cem
2026-01-20 17:23   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260119142724.284933-2-cem@kernel.org \
    --to=cem@kernel.org \
    --cc=aalbersh@redhat.com \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.