diff for duplicates of <202601200057.P0Lr7NDg-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 8dce967..b5857ff 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,15 @@ +BCC: lkp@intel.com +CC: oe-kbuild-all@lists.linux.dev +CC: linux-gpio@vger.kernel.org +TO: Krzysztof Kozlowski <krzk@kernel.org> +CC: Linus Walleij <linusw@kernel.org> +CC: Heiko Stuebner <heiko@sntech.de> + tree: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel head: 76d415763bae9488dd2b923b1348ce6f26c1f0ae commit: e2c58cbe3aff49fe201e81ee5f651294e313ec74 [30/31] pinctrl: rockchip: Simplify locking with scoped_guard() +:::::: branch date: 16 hours ago +:::::: commit date: 16 hours ago config: sh-randconfig-r073-20260119 (https://download.01.org/0day-ci/archive/20260120/202601200057.P0Lr7NDg-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 15.2.0 smatch version: v0.5.0-8985-g2614ff1a @@ -8,7 +17,7 @@ smatch version: v0.5.0-8985-g2614ff1a If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> +| Reported-by: Dan Carpenter <error27@gmail.com> | Closes: https://lore.kernel.org/r/202601200057.P0Lr7NDg-lkp@intel.com/ smatch warnings: @@ -16,6 +25,8 @@ drivers/pinctrl/pinctrl-rockchip.c:3683 rockchip_pinconf_set() error: we previou vim +3683 drivers/pinctrl/pinctrl-rockchip.c +e7165b1dff06b6e Heiko Stuebner 2021-09-14 3620 +d3e5116119bd02e Heiko Stübner 2013-06-10 3621 /* set the pin config settings for a specified pin */ d3e5116119bd02e Heiko Stübner 2013-06-10 3622 static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin, 03b054e9696c3cb Sherman Yin 2013-08-27 3623 unsigned long *configs, unsigned num_configs) d3e5116119bd02e Heiko Stübner 2013-06-10 3624 { @@ -39,9 +50,6 @@ d3e5116119bd02e Heiko Stübner 2013-06-10 3636 8ce5ef645468502 Caleb Connolly 2022-03-28 3642 */ e2c58cbe3aff49f Krzysztof Kozlowski 2026-01-18 3643 scoped_guard(mutex, &bank->deferred_lock) { 8ce5ef645468502 Caleb Connolly 2022-03-28 @3644 if (!gpio || !gpio->direction_output) { - ^^^^^^^^^^^^^^^^^^^^^^ -Is this check necessary? - e2c58cbe3aff49f Krzysztof Kozlowski 2026-01-18 3645 rc = rockchip_pinconf_defer_pin(bank, e2c58cbe3aff49f Krzysztof Kozlowski 2026-01-18 3646 pin - bank->pin_base, e2c58cbe3aff49f Krzysztof Kozlowski 2026-01-18 3647 param, arg); @@ -81,10 +89,6 @@ d3e5116119bd02e Heiko Stübner 2013-06-10 3676 break; 9ce9a02039de72e Jianqun Xu 2021-08-16 3681 return -EINVAL; 9ce9a02039de72e Jianqun Xu 2021-08-16 3682 9ce9a02039de72e Jianqun Xu 2021-08-16 @3683 rc = gpio->direction_output(gpio, pin - bank->pin_base, - ^^^^^^^^^^^^^^^^^^^^^^ -Unchecked dereference. This is old code so it's presumably okay. I -think this warning is triggering now because of changes in Smatch. - 9ce9a02039de72e Jianqun Xu 2021-08-16 3684 arg); a076e2ed3fd26f8 Heiko Stübner 2014-04-23 3685 if (rc) a076e2ed3fd26f8 Heiko Stübner 2014-04-23 3686 return rc; @@ -126,6 +130,13 @@ d3e5116119bd02e Heiko Stübner 2013-06-10 3720 } d3e5116119bd02e Heiko Stübner 2013-06-10 3722 d3e5116119bd02e Heiko Stübner 2013-06-10 3723 return 0; d3e5116119bd02e Heiko Stübner 2013-06-10 3724 } +d3e5116119bd02e Heiko Stübner 2013-06-10 3725 + +:::::: The code at line 3683 was first introduced by commit +:::::: 9ce9a02039de72ec8af1bd4bff14f1780337ffcc pinctrl/rockchip: drop the gpio related codes + +:::::: TO: Jianqun Xu <jay.xu@rock-chips.com> +:::::: CC: Linus Walleij <linus.walleij@linaro.org> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index b6d07dd..9d86821 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,18 +1,23 @@ - "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" + "From\0kernel test robot <lkp@intel.com>\0" "Subject\0[linusw-pinctrl:devel 30/31] drivers/pinctrl/pinctrl-rockchip.c:3683 rockchip_pinconf_set() error: we previously assumed 'gpio->direction_output' could be null (see line 3644)\0" - "Date\0Tue, 20 Jan 2026 09:25:00 +0300\0" - "To\0oe-kbuild@lists.linux.dev" - " Krzysztof Kozlowski <krzk@kernel.org>\0" + "Date\0Tue, 20 Jan 2026 00:17:17 +0800\0" + "To\0oe-kbuild@lists.linux.dev\0" "Cc\0lkp@intel.com" - oe-kbuild-all@lists.linux.dev - linux-gpio@vger.kernel.org - Linus Walleij <linusw@kernel.org> - " Heiko Stuebner <heiko@sntech.de>\0" + " Dan Carpenter <error27@gmail.com>\0" "\00:1\0" "b\0" + "BCC: lkp@intel.com\n" + "CC: oe-kbuild-all@lists.linux.dev\n" + "CC: linux-gpio@vger.kernel.org\n" + "TO: Krzysztof Kozlowski <krzk@kernel.org>\n" + "CC: Linus Walleij <linusw@kernel.org>\n" + "CC: Heiko Stuebner <heiko@sntech.de>\n" + "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel\n" "head: 76d415763bae9488dd2b923b1348ce6f26c1f0ae\n" "commit: e2c58cbe3aff49fe201e81ee5f651294e313ec74 [30/31] pinctrl: rockchip: Simplify locking with scoped_guard()\n" + ":::::: branch date: 16 hours ago\n" + ":::::: commit date: 16 hours ago\n" "config: sh-randconfig-r073-20260119 (https://download.01.org/0day-ci/archive/20260120/202601200057.P0Lr7NDg-lkp@intel.com/config)\n" "compiler: sh4-linux-gcc (GCC) 15.2.0\n" "smatch version: v0.5.0-8985-g2614ff1a\n" @@ -20,7 +25,7 @@ "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" + "| Reported-by: Dan Carpenter <error27@gmail.com>\n" "| Closes: https://lore.kernel.org/r/202601200057.P0Lr7NDg-lkp@intel.com/\n" "\n" "smatch warnings:\n" @@ -28,6 +33,8 @@ "\n" "vim +3683 drivers/pinctrl/pinctrl-rockchip.c\n" "\n" + "e7165b1dff06b6e Heiko Stuebner 2021-09-14 3620 \n" + "d3e5116119bd02e Heiko St\303\274bner 2013-06-10 3621 /* set the pin config settings for a specified pin */\n" "d3e5116119bd02e Heiko St\303\274bner 2013-06-10 3622 static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,\n" "03b054e9696c3cb Sherman Yin 2013-08-27 3623 \t\t\t\tunsigned long *configs, unsigned num_configs)\n" "d3e5116119bd02e Heiko St\303\274bner 2013-06-10 3624 {\n" @@ -51,9 +58,6 @@ "8ce5ef645468502 Caleb Connolly 2022-03-28 3642 \t\t\t */\n" "e2c58cbe3aff49f Krzysztof Kozlowski 2026-01-18 3643 \t\t\tscoped_guard(mutex, &bank->deferred_lock) {\n" "8ce5ef645468502 Caleb Connolly 2022-03-28 @3644 \t\t\t\tif (!gpio || !gpio->direction_output) {\n" - " ^^^^^^^^^^^^^^^^^^^^^^\n" - "Is this check necessary?\n" - "\n" "e2c58cbe3aff49f Krzysztof Kozlowski 2026-01-18 3645 \t\t\t\t\trc = rockchip_pinconf_defer_pin(bank,\n" "e2c58cbe3aff49f Krzysztof Kozlowski 2026-01-18 3646 \t\t\t\t\t\t\t\t\tpin - bank->pin_base,\n" "e2c58cbe3aff49f Krzysztof Kozlowski 2026-01-18 3647 \t\t\t\t\t\t\t\t\tparam, arg);\n" @@ -93,10 +97,6 @@ "9ce9a02039de72e Jianqun Xu 2021-08-16 3681 \t\t\t\treturn -EINVAL;\n" "9ce9a02039de72e Jianqun Xu 2021-08-16 3682 \n" "9ce9a02039de72e Jianqun Xu 2021-08-16 @3683 \t\t\trc = gpio->direction_output(gpio, pin - bank->pin_base,\n" - " ^^^^^^^^^^^^^^^^^^^^^^\n" - "Unchecked dereference. This is old code so it's presumably okay. I\n" - "think this warning is triggering now because of changes in Smatch.\n" - "\n" "9ce9a02039de72e Jianqun Xu 2021-08-16 3684 \t\t\t\t\t\t arg);\n" "a076e2ed3fd26f8 Heiko St\303\274bner 2014-04-23 3685 \t\t\tif (rc)\n" "a076e2ed3fd26f8 Heiko St\303\274bner 2014-04-23 3686 \t\t\t\treturn rc;\n" @@ -138,9 +138,16 @@ "d3e5116119bd02e Heiko St\303\274bner 2013-06-10 3722 \n" "d3e5116119bd02e Heiko St\303\274bner 2013-06-10 3723 \treturn 0;\n" "d3e5116119bd02e Heiko St\303\274bner 2013-06-10 3724 }\n" + "d3e5116119bd02e Heiko St\303\274bner 2013-06-10 3725 \n" + "\n" + ":::::: The code at line 3683 was first introduced by commit\n" + ":::::: 9ce9a02039de72ec8af1bd4bff14f1780337ffcc pinctrl/rockchip: drop the gpio related codes\n" + "\n" + ":::::: TO: Jianqun Xu <jay.xu@rock-chips.com>\n" + ":::::: CC: Linus Walleij <linus.walleij@linaro.org>\n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -0195d56b213513a196f5b64576de3a815cdd5c733159a4f13a01ade9852d6e1d +e912a820202708733ed86bfcb002a6291677aae5a5658d1cfd0dbede4c53a2bc
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.