From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH v2 net-next 0/3] gro: inline tcp6_gro_{receive,complete}
Date: Tue, 20 Jan 2026 07:30:57 -0800 [thread overview]
Message-ID: <20260120073057.5ef3a5e1@kernel.org> (raw)
In-Reply-To: <20260118175215.2871535-1-edumazet@google.com>
On Sun, 18 Jan 2026 17:52:12 +0000 Eric Dumazet wrote:
> On some platforms, GRO stack is too deep and causes cpu stalls.
>
> Decreasing call depths by one shows a 1.5 % gain on Zen2 cpus.
> (32 RX queues, 100Gbit NIC, RFS enabled, tcp_rr with 128 threads and 10,000 flows)
>
> We can go further by inlining ipv6_gro_{receive,complete}
> and take care of IPv4 if there is interest.
>
> Note: two temporary __always_inline will be replaced with
> inline_for_performance when available.
>
> v2: dealt with udp6_gro_receive()/udp6_gro_complete()
> missing declarations (kernel test robot <lkp@intel.com>)
> for CONFIG_MITIGATION_RETPOLINE=n
Still not good?
net/ipv6/udp_offload.c:136:17: error: static declaration of ‘udp6_gro_receive’ follows non-static declaration
136 | struct sk_buff *udp6_gro_receive(struct list_head *head, struct sk_buff *skb)
| ^~~~~~~~~~~~~~~~
In file included from net/ipv6/udp_offload.c:16:
./include/net/gro.h:408:17: note: previous declaration of ‘udp6_gro_receive’ with type ‘struct sk_buff *(struct list_head *, struct sk_buff *)’
408 | struct sk_buff *udp6_gro_receive(struct list_head *, struct sk_buff *);
| ^~~~~~~~~~~~~~~~
net/ipv6/udp_offload.c:168:29: error: static declaration of ‘udp6_gro_complete’ follows non-static declaration
168 | INDIRECT_CALLABLE_SCOPE int udp6_gro_complete(struct sk_buff *skb, int nhoff)
| ^~~~~~~~~~~~~~~~~
./include/net/gro.h:409:5: note: previous declaration of ‘udp6_gro_complete’ with type ‘int(struct sk_buff *, int)’
409 | int udp6_gro_complete(struct sk_buff *, int);
| ^~~~~~~~~~~~~~~~~
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-20 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 17:52 [PATCH v2 net-next 0/3] gro: inline tcp6_gro_{receive,complete} Eric Dumazet
2026-01-18 17:52 ` [PATCH v2 net-next 1/3] net: always inline __skb_incr_checksum_unnecessary() Eric Dumazet
2026-01-18 17:52 ` [PATCH v2 net-next 2/3] gro: inline tcp6_gro_receive() Eric Dumazet
2026-01-18 17:52 ` [PATCH v2 net-next 3/3] gro: inline tcp6_gro_complete() Eric Dumazet
2026-01-20 15:30 ` Jakub Kicinski [this message]
2026-01-20 15:41 ` [PATCH v2 net-next 0/3] gro: inline tcp6_gro_{receive,complete} Eric Dumazet
2026-01-20 15:44 ` Eric Dumazet
2026-01-20 16:29 ` Jakub Kicinski
2026-01-20 16:38 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120073057.5ef3a5e1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.