All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Benoît Monin" <benoit.monin@bootlin.com>
Cc: "Andi Shyti" <andi.shyti@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Jan Dabros" <jsd@semihalf.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Clark Williams" <clrkwllms@kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Gregory CLEMENT" <gregory.clement@bootlin.com>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
	"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
	"Dmitry Guzman" <dmitry.guzman@mobileye.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH v5 0/6] i2c: designware: Improve support of multi-messages transfer
Date: Tue, 20 Jan 2026 11:01:29 +0100	[thread overview]
Message-ID: <20260120100129.GH2275908@black.igk.intel.com> (raw)
In-Reply-To: <20260120-i2c-dw-v5-0-0e34d6d9455c@bootlin.com>

On Tue, Jan 20, 2026 at 10:28:00AM +0100, Benoît Monin wrote:
> Add support for the I2C_M_STOP flag to the .xfer() function of the
> designware driver. This allows grouping multiple accesses in a single
> call and changing the target address after a STOP flag. This is achieved
> by splitting i2c_dw_xfer() in two functions. The core logic handling
> the transaction is now in __i2c_dw_xfer_one_part(), while i2c_dw_xfer()
> loops over the messages to search for the I2C_M_STOP flag and calls
> __i2c_dw_xfer_one_part().
> 
> Handle controllers that lack the ability to emit a RESTART when two
> consecutive messages have the same address and direction by aborting
> transfers that contain such a sequence of messages. For those controllers,
> we also check that we do not get any unwanted STOP caused by a Tx FIFO
> underrun, as they lack the ability to hold the clock during a transaction.
> And we set the irq as non-threaded to prevent underrun on PREEMPT-RT
> kernel when filling the FIFO.
> 
> The I2C controllers found in the EyeQ6Lplus and EyeQ7H SoCs from Mobileye
> lack such capability, so a compatible string is added because this cannot
> be detected at runtime.
> 
> This patch series also brings four cleanups:
> * Optimize the read of the message flags in i2c_dw_read().
> * Sort the compatible strings alphabetically in dw_i2c_of_match[].
> * Simplify runtime PM handling in i2c_dw_xfer() with guard.
> * Add a dedicated i2c_algorithm for AMD NAVI controller.
> 
> Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
> ---
> Changes in v5:
> - Rebased on v6.19-rc6 and fully retested on EyeQ6Lplus.
> - Drop dt-binding patch: already merged upstream in v6.19-rc2.
> - From Andi Shyti's review:
>   - __i2c_dw_xfer_one_part() now returns 0 on success instead
>     of the number of messages transferred.
>   - Drop inline keyword from i2c_dw_msg_is_valid() declaration.
> - Link to v4: https://lore.kernel.org/r/20251126-i2c-dw-v4-0-b0654598e7c5@bootlin.com

Why you dropped my ack?

  parent reply	other threads:[~2026-01-20 10:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20  9:28 [PATCH v5 0/6] i2c: designware: Improve support of multi-messages transfer Benoît Monin
2026-01-20  9:28 ` [PATCH v5 1/6] i2c: designware: Optimize flag reading in i2c_dw_read() Benoît Monin
2026-01-22 13:29   ` Andi Shyti
2026-01-20  9:28 ` [PATCH v5 2/6] i2c: designware: Sort compatible strings in alphabetical order Benoît Monin
2026-01-22 13:30   ` Andi Shyti
2026-01-20  9:28 ` [PATCH v5 3/6] i2c: designware: Add dedicated algorithm for AMD NAVI Benoît Monin
2026-01-20  9:39   ` Andy Shevchenko
2026-01-22 13:31     ` Andi Shyti
2026-01-20  9:28 ` [PATCH v5 4/6] i2c: designware: Implement I2C_M_STOP support Benoît Monin
2026-01-22 16:25   ` Andy Shevchenko
2026-01-23 14:25     ` Benoît Monin
2026-01-23 14:37       ` Andy Shevchenko
2026-01-20  9:28 ` [PATCH v5 5/6] i2c: designware: Use runtime PM macro for auto-cleanup Benoît Monin
2026-01-20  9:28 ` [PATCH v5 6/6] i2c: designware: Support of controller with IC_EMPTYFIFO_HOLD_MASTER disabled Benoît Monin
2026-01-23  7:03   ` Andy Shevchenko
2026-01-20 10:01 ` Mika Westerberg [this message]
2026-01-20 15:17   ` [PATCH v5 0/6] i2c: designware: Improve support of multi-messages transfer Benoît Monin
2026-01-22 13:33     ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260120100129.GH2275908@black.igk.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=benoit.monin@bootlin.com \
    --cc=bigeasy@linutronix.de \
    --cc=clrkwllms@kernel.org \
    --cc=dmitry.guzman@mobileye.com \
    --cc=gregory.clement@bootlin.com \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=tawfik.bayouk@mobileye.com \
    --cc=theo.lebrun@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.kondratiev@mobileye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.