From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v4] syscalls: add file_attr05 test
Date: Tue, 20 Jan 2026 19:58:47 +0100 [thread overview]
Message-ID: <20260120185847.GA65442@pevik> (raw)
In-Reply-To: <20260120-file_attr05-v4-1-7cf444e3c7ea@suse.com>
Hi Andrea,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> +static struct tst_test test = {
> + .test_all = run,
> + .setup = setup,
> + .mntpoint = MNTPOINT,
> + .needs_root = 1,
> + .mount_device = 1,
> + .all_filesystems = 1,
> + .format_device = 1,
testcases/kernel/syscalls/file_attr/file_attr05.c: useless tag: format_device
very nit: please remove it (.mount_device implies it).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-01-20 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 13:26 [LTP] [PATCH v4] syscalls: add file_attr05 test Andrea Cervesato
2026-01-20 18:58 ` Petr Vorel [this message]
2026-01-21 13:40 ` Andrea Cervesato via ltp
2026-01-21 9:26 ` Li Wang via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120185847.GA65442@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.