From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E98ABD625F8 for ; Thu, 22 Jan 2026 08:37:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A58410E940; Thu, 22 Jan 2026 08:37:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="f7FrFs53"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0541910E7B2; Wed, 21 Jan 2026 13:47:46 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1769003259; cv=none; d=zohomail.com; s=zohoarc; b=UX47zEFnCFoEXymJWT65fed521ISt3QIL4N0+HnK+Au7DL6x3fD6CDvQfBqNdl2pRK2B/TbXVBHIDKEaQTVBvTzz/MsbBGWWBMWGRPHOFPvkX3OnFjRcnGeVHgMcu8stiozLurUvSpJrl5omfYVFucciP4WLMv/vB+Fs5odqBuU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769003259; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=XWYb1EVLop+y2YZYRyOemiCyseKAM65zvMigstgh+WI=; b=mSQfzGojBnG+QwoTyvzwkRv/fyf6lQb72pRcwmbFtEd6L/tTwDocZCKoGUvnYFixoTFOA8/nMUjKfBVWjkwtw+M6LBbBTHfn2YjBlVKuDVAeAeTQNYA6mw61VgFJtsI2eWyQ5NFLTfqnyV1K6cxQEhI2+qDWAf9fVjshNnE4L5Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1769003259; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=XWYb1EVLop+y2YZYRyOemiCyseKAM65zvMigstgh+WI=; b=f7FrFs53fKVCL6DJp4ri7GLuHzyTbx3D+rHTJT1DdV+ZM8nZRx/XcrSJbM7QuqBq QC8GxYJN/StqlAQZBDc8kchiQ6r2qn9Lps9AeAJlXBGMkxJq2OINuk5R21m1mzkVoiZ UxYBA/mxhG/lTCWUrqoK6NoTCuHJmHtttYYxYw2c= Received: by mx.zohomail.com with SMTPS id 1769003258024111.41098834348202; Wed, 21 Jan 2026 05:47:38 -0800 (PST) From: Nicolas Frattaroli Date: Wed, 21 Jan 2026 14:45:39 +0100 Subject: [PATCH v6 13/21] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260121-color-format-v6-13-7b81a771cd0b@collabora.com> References: <20260121-color-format-v6-0-7b81a771cd0b@collabora.com> In-Reply-To: <20260121-color-format-v6-0-7b81a771cd0b@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 X-Mailman-Approved-At: Thu, 22 Jan 2026 08:36:26 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" For RK3576 to be able to output YUV422 signals, it first needs to be able to pick the right output mode in the display controller to do so. The RK3576 hardware specifies different output formats depending on the used display protocol. Adjust the written register value based on the SoC and connector, so other users of vcstate->output_mode don't have to care about this. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index 3dd7b7571487..d93c6779286e 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -1706,6 +1706,22 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc, if (vcstate->output_mode == ROCKCHIP_OUT_MODE_AAAA && !(vp_data->feature & VOP2_VP_FEATURE_OUTPUT_10BIT)) out_mode = ROCKCHIP_OUT_MODE_P888; + else if (vcstate->output_mode == ROCKCHIP_OUT_MODE_YUV422 && + vop2->version == VOP_VERSION_RK3576) + switch (vcstate->output_type) { + case DRM_MODE_CONNECTOR_DisplayPort: + case DRM_MODE_CONNECTOR_eDP: + out_mode = ROCKCHIP_OUT_MODE_YUV422_RK3576_DP; + break; + case DRM_MODE_CONNECTOR_HDMIA: + out_mode = ROCKCHIP_OUT_MODE_YUV422_RK3576_HDMI; + break; + default: + drm_err(vop2->drm, "Unknown DRM_MODE_CONNECTOR %d\n", + vcstate->output_type); + vop2_unlock(vop2); + return; + } else out_mode = vcstate->output_mode; -- 2.52.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FE5AC4452E for ; Wed, 21 Jan 2026 13:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sbt9TxG5SFni7gTMKrnKmtITiOu1XrUzEDiLoThANEI=; b=xgTrPreZmI7+Ly 9D8wB3NUR+/4L5hmD/jVhceHxBDEYT0SnaOiabkMuy2SA9/Y+IEx0dE5gaBNRSPbm9kwLny1qh+vw E9vMB5ygcM9dWIK0Gn1kyG4rzgDt66EggPwN9a0O+jfQsB28SgM/XUuAeSD3+nYNVcfULPygG04EH DENHFJ8+NXvQEUnchtzbEc+o5buUoxk6rJI/Mm53ngQJJH1BsH7ixqHlaVpRq3IwSs5qtMhJxOrAm hi/734VJq4D9ZVeTiZKrkm7XEp4IpryCrUdryv6nzo6Iw6MKXv9IVT+cVAoOJWGzPCv9V2ytBl9VZ POqNe0D21z57iWOgiVRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1viYZB-00000005WW8-1jV0; Wed, 21 Jan 2026 13:48:13 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1viYZ8-00000005WRj-0L5D; Wed, 21 Jan 2026 13:48:11 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1769003259; cv=none; d=zohomail.com; s=zohoarc; b=UX47zEFnCFoEXymJWT65fed521ISt3QIL4N0+HnK+Au7DL6x3fD6CDvQfBqNdl2pRK2B/TbXVBHIDKEaQTVBvTzz/MsbBGWWBMWGRPHOFPvkX3OnFjRcnGeVHgMcu8stiozLurUvSpJrl5omfYVFucciP4WLMv/vB+Fs5odqBuU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769003259; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=XWYb1EVLop+y2YZYRyOemiCyseKAM65zvMigstgh+WI=; b=mSQfzGojBnG+QwoTyvzwkRv/fyf6lQb72pRcwmbFtEd6L/tTwDocZCKoGUvnYFixoTFOA8/nMUjKfBVWjkwtw+M6LBbBTHfn2YjBlVKuDVAeAeTQNYA6mw61VgFJtsI2eWyQ5NFLTfqnyV1K6cxQEhI2+qDWAf9fVjshNnE4L5Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1769003259; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=XWYb1EVLop+y2YZYRyOemiCyseKAM65zvMigstgh+WI=; b=f7FrFs53fKVCL6DJp4ri7GLuHzyTbx3D+rHTJT1DdV+ZM8nZRx/XcrSJbM7QuqBq QC8GxYJN/StqlAQZBDc8kchiQ6r2qn9Lps9AeAJlXBGMkxJq2OINuk5R21m1mzkVoiZ UxYBA/mxhG/lTCWUrqoK6NoTCuHJmHtttYYxYw2c= Received: by mx.zohomail.com with SMTPS id 1769003258024111.41098834348202; Wed, 21 Jan 2026 05:47:38 -0800 (PST) From: Nicolas Frattaroli Date: Wed, 21 Jan 2026 14:45:39 +0100 Subject: [PATCH v6 13/21] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 MIME-Version: 1.0 Message-Id: <20260121-color-format-v6-13-7b81a771cd0b@collabora.com> References: <20260121-color-format-v6-0-7b81a771cd0b@collabora.com> In-Reply-To: <20260121-color-format-v6-0-7b81a771cd0b@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260121_054810_274384_367CB0F3 X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org For RK3576 to be able to output YUV422 signals, it first needs to be able to pick the right output mode in the display controller to do so. The RK3576 hardware specifies different output formats depending on the used display protocol. Adjust the written register value based on the SoC and connector, so other users of vcstate->output_mode don't have to care about this. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index 3dd7b7571487..d93c6779286e 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -1706,6 +1706,22 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc, if (vcstate->output_mode == ROCKCHIP_OUT_MODE_AAAA && !(vp_data->feature & VOP2_VP_FEATURE_OUTPUT_10BIT)) out_mode = ROCKCHIP_OUT_MODE_P888; + else if (vcstate->output_mode == ROCKCHIP_OUT_MODE_YUV422 && + vop2->version == VOP_VERSION_RK3576) + switch (vcstate->output_type) { + case DRM_MODE_CONNECTOR_DisplayPort: + case DRM_MODE_CONNECTOR_eDP: + out_mode = ROCKCHIP_OUT_MODE_YUV422_RK3576_DP; + break; + case DRM_MODE_CONNECTOR_HDMIA: + out_mode = ROCKCHIP_OUT_MODE_YUV422_RK3576_HDMI; + break; + default: + drm_err(vop2->drm, "Unknown DRM_MODE_CONNECTOR %d\n", + vcstate->output_type); + vop2_unlock(vop2); + return; + } else out_mode = vcstate->output_mode; -- 2.52.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip