From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: "Alex Shi" <alexs@kernel.org>,
"Carlos Bilbao" <carlos.bilbao@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Federico Vaga" <federico.vaga@vaga.pv.it>,
"Hu Haowen" <2023002089@link.tyut.edu.cn>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nsc@kernel.org>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Yanteng Si" <si.yanteng@linux.dev>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, workflows@vger.kernel.org,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Avadhut Naik" <avadhut.naik@amd.com>,
"Chenguang Zhao" <zhaochenguang@kylinos.cn>,
"David Disseldorp" <ddiss@suse.de>,
"Dongliang Mu" <dzm91@hust.edu.cn>,
"Gang Yan" <yangang@kylinos.cn>, "Kees Cook" <kees@kernel.org>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Tamir Duberstein" <tamird@gmail.com>,
"Vincent Mailhol" <mailhol@kernel.org>,
WangYuli <wanyl5933@chinaunicom.cn>
Subject: Re: [PATCH 0/9] docs: Fix kernel-doc -Werror and moves it to tools/docs
Date: Wed, 21 Jan 2026 00:00:53 +0100 [thread overview]
Message-ID: <20260121000053.5e274248@foz.lan> (raw)
In-Reply-To: <87wm1bhozz.fsf@trenco.lwn.net>
Hi Jon,
On Tue, 20 Jan 2026 15:56:48 -0700
Jonathan Corbet <corbet@lwn.net> wrote:
> Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:
>
> > Hi Jon,
> >
> > After a restful weekend and revisiting both yours and my series,
> > I'm opting to send a patch series merging both into one:
> >
> > - The first 4 patches are from my series (no changes since v5):
> > https://lore.kernel.org/linux-doc/cover.1768642102.git.mchehab+huawei@kernel.org/T/#m81211c0ff38bbaa82b8b0b6606f242ccc0c2a9ac
> >
> > - It follows by the 2 patches from your renaming series:
> > https://lore.kernel.org/linux-doc/20260119111745.4694546b@foz.lan/T/#m51099c31a99dccccdb4d17cbaadc818e9e4df8c4
> >
> > with the fix I proposed for kernel-doc to find its libraries
> >
> > I added 3 patches afterwards:
> >
> > - patch 5: move possible return values from docstring to helper message;
> > - patch 6: improve MsgFormatter description;
> > - patch 7: moves kerneldoc_bin from conf.py to the sphinx/kerneldoc.py
> > (this is now just a debugging message - no need to pick it from env)
> >
> > IMO, this series is ready to be merged.
>
> Patch 7 adds a new warning:
>
> WARNING: unknown config value 'kerneldoc_bin' in override, ignoring
>
> It needs to be taken out of sphinx-build-wrapper; I've appended the
> following patch to the series to deal with it.
True, thanks for checking it!
> I think I'll go ahead
> and tack on a patch putting in the scripts/kernel-doc symlink, then I
> guess it's ready to go.
Go ahead. Yeah, I think that, with such changes, this series is
ready to go.
>
> Thanks,
>
> jon
>
> From 4a3efd128f7da996b677151790d043ec44a00561 Mon Sep 17 00:00:00 2001
> From: Jonathan Corbet <corbet@lwn.net>
> Date: Tue, 20 Jan 2026 15:50:38 -0700
> Subject: [PATCH] docs: sphinx-build-wrapper: stop setting kerneldoc_bin for
> Sphinx
>
> Now that the Sphinx build does not use the kerneldoc_bin configuration
> variable, we shouldn't try to set it in the build wrapper or we get a nifty
> warning:
>
> WARNING: unknown config value 'kerneldoc_bin' in override, ignoring
>
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> tools/docs/sphinx-build-wrapper | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/docs/sphinx-build-wrapper b/tools/docs/sphinx-build-wrapper
> index cb2a5005e633..9f1ae1485f84 100755
> --- a/tools/docs/sphinx-build-wrapper
> +++ b/tools/docs/sphinx-build-wrapper
> @@ -750,7 +750,6 @@ class SphinxBuilder:
>
> build_args = args + [
> "-d", doctree_dir,
> - "-D", f"kerneldoc_bin={kerneldoc}",
> "-D", f"version={self.kernelversion}",
> "-D", f"release={self.kernelrelease}",
> "-D", f"kerneldoc_srctree={self.srctree}",
Thanks,
Mauro
prev parent reply other threads:[~2026-01-20 23:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 12:04 [PATCH 0/9] docs: Fix kernel-doc -Werror and moves it to tools/docs Mauro Carvalho Chehab
2026-01-19 12:04 ` [PATCH 1/9] docs: kdoc: fix logic to handle unissued warnings Mauro Carvalho Chehab
2026-01-19 12:04 ` [PATCH 2/9] docs: kdoc: avoid error_count overflows Mauro Carvalho Chehab
2026-01-19 12:04 ` [PATCH 3/9] docs: kdoc: ensure that comments are using our coding style Mauro Carvalho Chehab
2026-01-19 12:04 ` [PATCH 4/9] docs: kdoc: some fixes to kernel-doc comments Mauro Carvalho Chehab
2026-01-19 12:05 ` [PATCH 5/9] docs: kdoc: remove support for an external kernel-doc from sphinx Mauro Carvalho Chehab
2026-01-19 12:05 ` [PATCH 6/9] docs: kdoc: move kernel-doc to tools/docs Mauro Carvalho Chehab
2026-01-19 12:05 ` [PATCH 7/9] docs: kdoc: move the return values to the helper message Mauro Carvalho Chehab
2026-01-19 12:05 ` [PATCH 8/9] docs: kdoc: improve description of MsgFormatter Mauro Carvalho Chehab
2026-01-19 12:05 ` [PATCH 9/9] docs: conf.py: get rid of the now unused kerneldoc_bin env var Mauro Carvalho Chehab
2026-01-19 15:29 ` ✗ Fi.CI.BUILD: failure for docs: Fix kernel-doc -Werror and moves it to tools/docs Patchwork
2026-01-20 22:56 ` [PATCH 0/9] " Jonathan Corbet
2026-01-20 23:00 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121000053.5e274248@foz.lan \
--to=mchehab+huawei@kernel.org \
--cc=2023002089@link.tyut.edu.cn \
--cc=airlied@gmail.com \
--cc=alexs@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=avadhut.naik@amd.com \
--cc=carlos.bilbao@kernel.org \
--cc=corbet@lwn.net \
--cc=ddiss@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=dzm91@hust.edu.cn \
--cc=federico.vaga@vaga.pv.it \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kees@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=masahiroy@kernel.org \
--cc=mchehab@kernel.org \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=ojeda@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rodrigo.vivi@intel.com \
--cc=rostedt@goodmis.org \
--cc=si.yanteng@linux.dev \
--cc=simona@ffwll.ch \
--cc=skhan@linuxfoundation.org \
--cc=tamird@gmail.com \
--cc=thomas.weissschuh@linutronix.de \
--cc=tursulin@ursulin.net \
--cc=wanyl5933@chinaunicom.cn \
--cc=workflows@vger.kernel.org \
--cc=yangang@kylinos.cn \
--cc=zhaochenguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.