From: David Laight <david.laight.linux@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
David Desobry <david.desobry@formalgen.com>,
tglx@kernel.org, mingo@redhat.com, dave.hansen@linux.intel.com,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/lib: Fix num_digits() signed overflow for INT_MIN
Date: Wed, 21 Jan 2026 10:59:28 +0000 [thread overview]
Message-ID: <20260121105928.21c5e2de@pumpkin> (raw)
In-Reply-To: <20260120201346.GEaW_h-tUO2pb4d26w@fat_crate.local>
On Tue, 20 Jan 2026 21:13:46 +0100
Borislav Petkov <bp@alien8.de> wrote:
> On Tue, Jan 20, 2026 at 11:50:41AM -0800, H. Peter Anvin wrote:
> > For negative numbers? Dave Hansen pointed out that we currently don't ever
> > pass negative numbers, in which case it would make more sense to have the
> > function simply take an unsigned int.
>
> Yes, that's why I'm asking what we're even fixing here...
You can certainly just document it doesn't work for INT_MIN.
David
next prev parent reply other threads:[~2026-01-21 10:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 9:42 [PATCH] x86/lib: Fix num_digits() signed overflow for INT_MIN David Desobry
2026-01-20 16:23 ` H. Peter Anvin
2026-01-20 16:40 ` Borislav Petkov
2026-01-20 18:02 ` H. Peter Anvin
2026-01-20 18:17 ` H. Peter Anvin
2026-01-20 19:16 ` Borislav Petkov
2026-01-20 19:50 ` H. Peter Anvin
2026-01-20 20:13 ` Borislav Petkov
2026-01-21 10:59 ` David Laight [this message]
[not found] ` <14738799-afb2-428b-9829-f1ed038f3872@formalgen.com>
2026-01-20 20:24 ` H. Peter Anvin
2026-01-20 21:22 ` Borislav Petkov
2026-01-20 21:21 ` Borislav Petkov
2026-01-20 17:48 ` David Desobry
2026-01-20 22:15 ` David Laight
2026-01-20 18:58 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121105928.21c5e2de@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david.desobry@formalgen.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.