From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E840410D37 for ; Wed, 21 Jan 2026 12:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768998050; cv=none; b=ZddW6CiOMJFVHSN3Uu2hX18Ti5s6gsY6NEjRNWkntgF1ITT4ekippNlC0Q/CijGygXWOYWbpZouDAQFRCG3xii5qM5bTW2Xce8Vg19QORhIvvru7nQKcO5SPTjnbdaVFwLr7oWUrcX8HQUkKBsGPVDnPlvSRyEdBJVbgUeqlpAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768998050; c=relaxed/simple; bh=bEfow8NEF0uOGPh/bPakUtYFCs/iMZu6Z6wQWaeOiNM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M7BxJ+ELAQCgjZBeB/xyR63AdhdQ9k7WT+W8+nmjZbIWvxQHJFyupyWR/tWmMGOS/wfJ0V5ztd+Cyt5+qFOBjTCq8e9RhRwAv3g9x2JwYRJWzWAmz5uorLudFqCFLoxV9Z7q2ySg3kXfBxUvqiQKarLIp6diTsATMsHpeYOVBQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CfrJ/YL9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CfrJ/YL9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51BF9C116D0; Wed, 21 Jan 2026 12:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768998050; bh=bEfow8NEF0uOGPh/bPakUtYFCs/iMZu6Z6wQWaeOiNM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CfrJ/YL95LaCDhDuaTEBE29y+G79wYNPfJRRGmHFent5vTY9kxoRn9mwXG1jpYiQR NWgHdt1mouaRCmHZN2otSnUO4JoofOmU9eK13yLtAFTELnbyJCd66eP8WeOJTb3ou5 5PYjaEyFtOrWwYXJu29m1SFVSsJ2VE9LqrmaLCSV1Xj4Xxs3cDjOcydKdd2i1RsU6d yQR5OoW05GbgxIkupV4ESuSaBctgfwDzfxuefrBj9yneW0kyTPSLrdmbVaCsPNe8ua 6hVAHWJr9lF0MuCWb1JwoY5otANTZTjoQWo/EUZN++m3YfdmL8V/jTJO87CjartNht 0o2rXGO1xnILQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Johan Hovold , Pierre-Yves MORDRET , Amelie Delaunay , Vinod Koul , Sasha Levin Subject: [PATCH 6.6.y] dmaengine: stm32: dmamux: fix OF node leak on route allocation failure Date: Wed, 21 Jan 2026 07:20:47 -0500 Message-ID: <20260121122047.1526648-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026012005-grid-smell-308a@gregkh> References: <2026012005-grid-smell-308a@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Johan Hovold [ Upstream commit b1b590a590af13ded598e70f0b72bc1e515787a1 ] Make sure to drop the reference taken to the DMA master OF node also on late route allocation failures. Fixes: df7e762db5f6 ("dmaengine: Add STM32 DMAMUX driver") Cc: stable@vger.kernel.org # 4.15 Cc: Pierre-Yves MORDRET Signed-off-by: Johan Hovold Reviewed-by: Amelie Delaunay Link: https://patch.msgid.link/20251117161258.10679-12-johan@kernel.org Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/stm32-dmamux.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/stm32-dmamux.c b/drivers/dma/stm32-dmamux.c index 8d77e2a7939a0..3a6907fbb5a3e 100644 --- a/drivers/dma/stm32-dmamux.c +++ b/drivers/dma/stm32-dmamux.c @@ -142,7 +142,7 @@ static void *stm32_dmamux_route_allocate(struct of_phandle_args *dma_spec, ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) { spin_unlock_irqrestore(&dmamux->lock, flags); - goto error; + goto err_put_dma_spec_np; } spin_unlock_irqrestore(&dmamux->lock, flags); @@ -162,6 +162,8 @@ static void *stm32_dmamux_route_allocate(struct of_phandle_args *dma_spec, return mux; +err_put_dma_spec_np: + of_node_put(dma_spec->np); error: clear_bit(mux->chan_id, dmamux->dma_inuse); -- 2.51.0