From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E077C44526 for ; Wed, 21 Jan 2026 13:28:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1viYFs-000368-L2; Wed, 21 Jan 2026 08:28:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1viYFn-000357-4Z for qemu-devel@nongnu.org; Wed, 21 Jan 2026 08:28:11 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1viYFl-0005ft-NP for qemu-devel@nongnu.org; Wed, 21 Jan 2026 08:28:10 -0500 Received: from mail.maildlp.com (unknown [172.18.224.150]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4dx4kD37CCzHnH76; Wed, 21 Jan 2026 21:27:32 +0800 (CST) Received: from dubpeml500005.china.huawei.com (unknown [7.214.145.207]) by mail.maildlp.com (Postfix) with ESMTPS id 39D4E40539; Wed, 21 Jan 2026 21:28:06 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml500005.china.huawei.com (7.214.145.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 21 Jan 2026 13:28:05 +0000 Date: Wed, 21 Jan 2026 13:28:04 +0000 To: Mauro Carvalho Chehab CC: Michael S Tsirkin , Shiju Jose , , Igor Mammedov , Cleber Rosa , John Snow Subject: Re: [PATCH 08/13] scripts/ghes_inject: exit 1 if command was not sent Message-ID: <20260121132804.0000501d@huawei.com> In-Reply-To: <746cc65bbde60ebe2232b048d6448d19466601c5.1768993993.git.mchehab+huawei@kernel.org> References: <746cc65bbde60ebe2232b048d6448d19466601c5.1768993993.git.mchehab+huawei@kernel.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.15] X-ClientProxiedBy: lhrpeml500012.china.huawei.com (7.191.174.4) To dubpeml500005.china.huawei.com (7.214.145.207) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via qemu development Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 21 Jan 2026 12:25:16 +0100 Mauro Carvalho Chehab wrote: > add a return code to subparser func() and return 1 if the > command failed. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron > --- > scripts/arm_processor_error.py | 2 +- > scripts/ghes_inject.py | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/scripts/arm_processor_error.py b/scripts/arm_processor_error.py > index 73d069f070d4..d9845adb0c0a 100644 > --- a/scripts/arm_processor_error.py > +++ b/scripts/arm_processor_error.py > @@ -473,4 +473,4 @@ def send_cper(self, args): > > self.data = data > > - qmp_cmd.send_cper(cper_guid.CPER_PROC_ARM, self.data) > + return qmp_cmd.send_cper(cper_guid.CPER_PROC_ARM, self.data) > diff --git a/scripts/ghes_inject.py b/scripts/ghes_inject.py > index 9a235201418b..6ac917d0b5db 100755 > --- a/scripts/ghes_inject.py > +++ b/scripts/ghes_inject.py > @@ -43,7 +43,8 @@ def main(): > > args = parser.parse_args() > if "func" in args: > - args.func(args) > + if not args.func(args): > + sys.exit(1) > else: > sys.exit(f"Please specify a valid command for {sys.argv[0]}") >