All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>,
	netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Simon Horman <horms@kernel.org>,
	Mahesh Bandewar <maheshb@google.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, Liang Li <liali@redhat.com>
Subject: Re: [PATCHv2 net-next 2/3] bonding: restructure ad_churn_machine
Date: Wed, 21 Jan 2026 17:10:51 -0800	[thread overview]
Message-ID: <20260121171051.039110c3@kernel.org> (raw)
In-Reply-To: <eaac2f5e-842e-4a18-a7a0-8a7ba2794ef9@redhat.com>

On Wed, 21 Jan 2026 08:58:13 +0100 Paolo Abeni wrote:
> >> My personal preference would be for 2/3 landing into net-next: the code
> >> looks correct to me, but refactor has IMHO still to much potential for
> >> regressions do land directly into net and the blamed commit is quite old.
> >>
> >> I suggested targeting net-next while retaining the Fixes tag as we
> >> already had complex fixes landing into net-next in the past.  
> > 
> > The appropriate way to delay propagation of the fix to add:
> > 
> > Cc: <stable@vger.kernel.org> # after 4 weeks
> > 
> > not to merge things into -next.  
> 
> I went over the code as carefully as I could and I don't see any obvious
> problem, so I don't have a so strong opinion vs net, but to hopefully
> clarify: my thinking is that this is net-next material because it's an
> invasive refactor with behavior change. My preference would be let the
> code be tested in next/net-next for a while before landing into mainline.

From the patch description it look like user-trigger-able hang of 
the FSM. But if this is more of a resiliency improvement than a fix
then I'm perfectly fine with net-next. But then no Fixes tag and 
no stable at all, please.

  reply	other threads:[~2026-01-22  1:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14  6:49 [PATCHv2 net-next 0/3] bonding: fix 802.3ad churn machine and port state issues Hangbin Liu
2026-01-14  6:49 ` [PATCHv2 net-next 1/3] bonding: set AD_RX_PORT_DISABLED when disabling a port Hangbin Liu
2026-01-14  6:49 ` [PATCHv2 net-next 2/3] bonding: restructure ad_churn_machine Hangbin Liu
2026-01-19 20:22   ` Jakub Kicinski
2026-01-20  5:51     ` Hangbin Liu
2026-01-20  8:29     ` Paolo Abeni
2026-01-20 23:11       ` Jakub Kicinski
2026-01-21  7:58         ` Paolo Abeni
2026-01-22  1:10           ` Jakub Kicinski [this message]
2026-01-14  6:49 ` [PATCHv2 net-next 3/3] selftests: bonding: add mux and churn state testing Hangbin Liu
2026-02-02  1:14 ` [PATCHv2 net-next 0/3] bonding: fix 802.3ad churn machine and port state issues Hangbin Liu
2026-02-02  9:27   ` Paolo Abeni
2026-02-23  1:55     ` Hangbin Liu
2026-02-26 11:55       ` Paolo Abeni
2026-02-26 12:40         ` Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260121171051.039110c3@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jv@jvosburgh.net \
    --cc=liali@redhat.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=maheshb@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.