From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Shijith Thotton <sthotton@marvell.com>
Subject: [RFC 2/3] event/cnxk: add pause to spinloops
Date: Wed, 21 Jan 2026 10:05:43 -0800 [thread overview]
Message-ID: <20260121180845.889190-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20260121180845.889190-1-stephen@networkplumber.org>
On SMT systems when a spinloop is done without a pause
it may cause excessive latency. This problem was found
by the fix_empty_spinloops coccinelle script.
This is compile tested only! I don't have this hardware.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/event/cnxk/cn10k_worker.c | 2 +-
drivers/event/cnxk/cn20k_worker.c | 2 +-
drivers/event/cnxk/cnxk_tim_worker.h | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/event/cnxk/cn10k_worker.c b/drivers/event/cnxk/cn10k_worker.c
index 80077ec8a1..69ac67115a 100644
--- a/drivers/event/cnxk/cn10k_worker.c
+++ b/drivers/event/cnxk/cn10k_worker.c
@@ -93,7 +93,7 @@ sso_lmt_aw_wait_fc(struct cn10k_sso_hws *ws, int64_t req)
retry:
while (rte_atomic_load_explicit(ws->fc_cache_space, rte_memory_order_relaxed) < 0)
- ;
+ rte_pause();
cached = rte_atomic_fetch_sub_explicit(ws->fc_cache_space, req, rte_memory_order_acquire) -
req;
diff --git a/drivers/event/cnxk/cn20k_worker.c b/drivers/event/cnxk/cn20k_worker.c
index 53daf3b4b0..49dfb2a28c 100644
--- a/drivers/event/cnxk/cn20k_worker.c
+++ b/drivers/event/cnxk/cn20k_worker.c
@@ -93,7 +93,7 @@ sso_lmt_aw_wait_fc(struct cn20k_sso_hws *ws, int64_t req)
retry:
while (rte_atomic_load_explicit(ws->fc_cache_space, rte_memory_order_relaxed) < 0)
- ;
+ rte_pause();
cached = rte_atomic_fetch_sub_explicit(ws->fc_cache_space, req, rte_memory_order_acquire) -
req;
diff --git a/drivers/event/cnxk/cnxk_tim_worker.h b/drivers/event/cnxk/cnxk_tim_worker.h
index 09f84091ab..887c0800e2 100644
--- a/drivers/event/cnxk/cnxk_tim_worker.h
+++ b/drivers/event/cnxk/cnxk_tim_worker.h
@@ -405,9 +405,9 @@ cnxk_tim_add_entry_mp(struct cnxk_tim_ring *const tim_ring,
: [crem] "r"(&bkt->w1)
: "memory");
#else
- while (rte_atomic_load_explicit((int64_t __rte_atomic *)&bkt->w1,
+ while (rte_atomic_load_explicit((int64_t __rte_atomic *)&bkt->w1,
rte_memory_order_relaxed) < 0)
- ;
+ rte_pause();
#endif
goto __retry;
} else if (!rem) {
--
2.51.0
next prev parent reply other threads:[~2026-01-21 18:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 18:05 [RFC 0/3] Add pause to empty spinloops Stephen Hemminger
2026-01-21 18:05 ` [RFC 1/3] net/cnxk: add pause to spinloops Stephen Hemminger
2026-01-21 18:05 ` Stephen Hemminger [this message]
2026-01-21 21:01 ` [RFC 2/3] event/cnxk: " Stephen Hemminger
2026-01-21 18:05 ` [RFC 3/3] devtools/cocci: add script to find empty spinloops Stephen Hemminger
2026-04-13 16:45 ` [PATCH v2 0/3] Add pause to empty spin loops Stephen Hemminger
2026-04-13 16:45 ` [PATCH v2 1/3] net/cnxk: add pause to spinloops Stephen Hemminger
2026-04-13 16:45 ` [PATCH v2 2/3] event/cnxk: " Stephen Hemminger
2026-06-08 15:49 ` Jerin Jacob
2026-06-08 17:44 ` Stephen Hemminger
2026-06-09 4:50 ` Jerin Jacob
2026-04-13 16:45 ` [PATCH v2 3/3] devtools/cocci: add script to find empty spinloops Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121180845.889190-3-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=pbhagavatula@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.