All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: "Benoît Monin" <benoit.monin@bootlin.com>
Cc: linux-i2c@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH i2c-tools v2 0/2] Add support for message modifier flags
Date: Wed, 21 Jan 2026 19:37:06 +0100	[thread overview]
Message-ID: <20260121193706.51135355@endymion> (raw)
In-Reply-To: <3571298.LZWGnKmheA@benoit.monin>

On Wed, 21 Jan 2026 11:00:56 +0100, Benoît Monin wrote:
> On Tuesday, 20 January 2026 at 15:15:36 CET, Jean Delvare wrote:
> > Out of curiosity, did you have an actual scenario where you needed to
> > do this? Protocol mangling is supposed to be rarely needed and avoided
> > as much as possible.
> >   
> My only need was to have a way to set the I2C_M_STOP flag, but since I
> started modifying i2ctransfer, adding the other flags was not much
> additional work.
> 
> If you think that some of the flags should not be exposed by i2ctransfer, I
> can remove them.

I was just curious, I have no objection to including them all in
i2ctransfer. Maybe someone else will need them in the future.

It might be a good idea to mention in the man page that these flags
should be used carefully though. They are a deviation from the standard
and devices may react badly if they do not expect that.

-- 
Jean Delvare
SUSE L3 Support

      reply	other threads:[~2026-01-21 18:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-23 13:22 [PATCH i2c-tools v2 0/2] Add support for message modifier flags Benoît Monin
2025-12-23 13:22 ` [PATCH i2c-tools v2 1/2] i2cdetect: Display mangling and nostart support Benoît Monin
2026-01-13 17:22   ` Wolfram Sang
2025-12-23 13:22 ` [PATCH i2c-tools v2 2/2] i2ctransfer: Add optional message modifier flags Benoît Monin
2026-01-13 17:33   ` Wolfram Sang
2026-01-16 13:01     ` Benoît Monin
2026-01-20 15:06       ` Jean Delvare
2026-01-20 14:45   ` Jean Delvare
2026-01-13 17:21 ` [PATCH i2c-tools v2 0/2] Add support for " Wolfram Sang
2026-01-20 14:15 ` Jean Delvare
2026-01-21 10:00   ` Benoît Monin
2026-01-21 18:37     ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260121193706.51135355@endymion \
    --to=jdelvare@suse.de \
    --cc=benoit.monin@bootlin.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.