From: Francesco Dolcini <francesco@dolcini.it>
To: Anshul Dalal <anshuld@ti.com>
Cc: u-boot@lists.denx.de, upstream@lists.phytec.de,
Tom Rini <trini@konsulko.com>, Nishanth Menon <nm@ti.com>,
Robert Nelson <robertcnelson@gmail.com>,
Wadim Egorov <w.egorov@phytec.de>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Garrett Giordano <ggiordano@phytec.com>,
Manorit Chawdhry <m-chawdhry@ti.com>, Bryan Brattlof <bb@ti.com>,
Paresh Bhagat <p-bhagat@ti.com>,
Vitor Soares <vitor.soares@toradex.com>,
Parth Pancholi <parth.pancholi@toradex.com>,
Andrew Davis <afd@ti.com>, Gowtham Tammana <g-tammana@ti.com>,
Vignesh R <vigneshr@ti.com>
Subject: Re: [PATCH master] arch: arm: dts: k3: refactor common nodes to k3-*-r5.dtsi
Date: Thu, 22 Jan 2026 15:44:04 +0100 [thread overview]
Message-ID: <20260122144404.GA71266@francesco-nb> (raw)
In-Reply-To: <20260122-r5_dt_refactor-v1-1-5442a4321756@ti.com>
Hello Anshul,
On Thu, Jan 22, 2026 at 07:38:38PM +0530, Anshul Dalal wrote:
> This patch refactors the nodes in each board's R5 device-tree to common
> SoC level dtsi. No functional change is intended from this patch.
...
> diff --git a/arch/arm/dts/k3-am625-r5.dtsi b/arch/arm/dts/k3-am625-r5.dtsi
> new file mode 100644
> index 00000000000..c509857ac5d
> --- /dev/null
> +++ b/arch/arm/dts/k3-am625-r5.dtsi
> @@ -0,0 +1,88 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2026 Texas Instruments Incorporated - https://www.ti.com/
> + */
> +
> +/ {
> + aliases {
> + tick-timer = &main_timer0;
> + remoteproc0 = &sysctrler;
> + remoteproc1 = &a53_0;
> + serial0 = &wkup_uart0;
> + serial3 = &main_uart1;
> + };
> +
> + a53_0: a53@0 {
> + compatible = "ti,am654-rproc";
> + reg = <0x00 0x00a90000 0x00 0x10>;
> + power-domains = <&k3_pds 61 TI_SCI_PD_EXCLUSIVE>,
> + <&k3_pds 135 TI_SCI_PD_EXCLUSIVE>,
> + <&k3_pds 166 TI_SCI_PD_EXCLUSIVE>;
> + resets = <&k3_reset 135 0>;
> + clocks = <&k3_clks 61 0>, <&k3_clks 135 0>;
> + clock-names = "gtc", "core";
> + assigned-clocks = <&k3_clks 61 0>, <&k3_clks 135 0>;
> + assigned-clock-parents = <&k3_clks 61 2>;
> + assigned-clock-rates = <200000000>, <1200000000>;
> + ti,sci = <&dmsc>;
> + ti,sci-proc-id = <32>;
> + ti,sci-host-id = <10>;
> + bootph-pre-ram;
> + };
....
> diff --git a/arch/arm/dts/k3-am625-verdin-r5.dts b/arch/arm/dts/k3-am625-verdin-r5.dts
> index fb431c96337..dfd960aaf3c 100644
> --- a/arch/arm/dts/k3-am625-verdin-r5.dts
> +++ b/arch/arm/dts/k3-am625-verdin-r5.dts
> @@ -9,75 +9,30 @@
> #include "k3-am62-ddr.dtsi"
>
> #include "k3-am625-verdin-wifi-dev-u-boot.dtsi"
> +#include "k3-am625-r5.dtsi"
>
> / {
> - a53_0: a53@0 {
> - compatible = "ti,am654-rproc";
> - reg = <0x00 0x00a90000 0x00 0x10>;
> - /*
> - * FIXME: Currently only the SPL running on the R5 has a clock
> - * driver. As a workaround therefore move the assigned-clock
> - * stuff required for our ETH_25MHz_CLK from the cpsw3g_mdio
> - * node of the regular device tree to here (last one each in
> - * below three lines, adding a <0> as spacing for parents).
> - */
> - assigned-clocks = <&k3_clks 61 0>, <&k3_clks 135 0>, <&k3_clks 157 20>;
> - assigned-clock-parents = <&k3_clks 61 2>, <0>, <&k3_clks 157 22>;
> - assigned-clock-rates = <200000000>, <800000000>, <25000000>;
^^^^^^^^^^
Can you check this? On both verdin am62 and am62p?
According to your diff nothing should change here, however if I look at
the code you are removing the ethernet clock.
Thanks,
Francesco
next prev parent reply other threads:[~2026-01-22 14:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 14:08 [PATCH master] arch: arm: dts: k3: refactor common nodes to k3-*-r5.dtsi Anshul Dalal
2026-01-22 14:44 ` Francesco Dolcini [this message]
2026-01-22 14:48 ` Francesco Dolcini
2026-02-02 8:25 ` Anshul Dalal
2026-02-02 14:38 ` Tom Rini
2026-02-03 6:51 ` Wadim Egorov
2026-02-03 13:39 ` Bryan Brattlof
2026-02-06 8:23 ` Anshul Dalal
2026-02-06 13:47 ` Bryan Brattlof
2026-02-06 15:18 ` Bryan Brattlof
2026-02-06 18:15 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122144404.GA71266@francesco-nb \
--to=francesco@dolcini.it \
--cc=afd@ti.com \
--cc=anshuld@ti.com \
--cc=bb@ti.com \
--cc=francesco.dolcini@toradex.com \
--cc=g-tammana@ti.com \
--cc=ggiordano@phytec.com \
--cc=m-chawdhry@ti.com \
--cc=nm@ti.com \
--cc=p-bhagat@ti.com \
--cc=parth.pancholi@toradex.com \
--cc=robertcnelson@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=upstream@lists.phytec.de \
--cc=vigneshr@ti.com \
--cc=vitor.soares@toradex.com \
--cc=w.egorov@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.