From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC75A35292E for ; Fri, 23 Jan 2026 05:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769145147; cv=none; b=Nc32OkEzeEsLANjiPLQGSeik4kunyDW6EKk6xHf6RnfOVO265bMqBoGRS6cIT0QORDMQw9f8r0NjLNERrqdydlGnVhGY5nfyF1UZR1fH5lXknFA7DqRkzOoidFfW8OEIWuC7R8BvXTxfpHH/nA2IgGuGq9mYOAqv0ajaAIRPtGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769145147; c=relaxed/simple; bh=f9ZY//WP7sMGr4/l+Rf2qgx5FluM0DH8X2K6UdTQ70U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JWb9T1I2dafwUy1ofgGrJM1qDu4ZsezmEvnS/5LvUg8h4dEq9Xp+b/5bw0ca2LkoJ6gCGzX4UAZik+urAhauaEJq7CKU2z4ufjnQRBV2Arv8jxsqH2dd9aYDzv7GV72EIDz10VmAIIl8ytK/0kMHmrgnnXSpl+5LlKaY9eZH83w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id A85EC227AA8; Fri, 23 Jan 2026 06:12:16 +0100 (CET) Date: Fri, 23 Jan 2026 06:12:16 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , t@magnolia.djwong.org, Eric Biggers , Al Viro , Christian Brauner , Jan Kara , David Sterba , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Andrey Albershteyn , "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, fsverity@lists.linux.dev Subject: Re: [PATCH 04/11] fsverity: start consolidating pagecache code Message-ID: <20260123051216.GA24123@lst.de> References: <20260122082214.452153-1-hch@lst.de> <20260122082214.452153-5-hch@lst.de> <20260122212700.GD5910@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: fsverity@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260122212700.GD5910@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Jan 22, 2026 at 01:27:00PM -0800, Darrick J. Wong wrote: > Nice hoist, though I wonder -- as an exported fs function, should we be > checking that the returned folio doesn't cover EOF? Not that any of the > users actually check that returned merkle tree folios fit that > criterion. As in past i_size because this is verity metadata? I think per the last discussion that's only guranteed to be true, not the folio. It might be useful to assert this, but it might be better for combine this with the work to use different on-disk vs in-memory offset and to consolidate all the offset magic. Which is worthwhile, but І don't really want to add that in this series. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07992D6CFBB for ; Fri, 23 Jan 2026 05:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5i73lrPqjZRKb5ZD0Cqm/vhtyF1yMuKGZTJcXuUL/Jg=; b=PYUshf3Y5jCrnAmjqWt6ha5kEH ti7p0yzawcOfDJ/wU7HovV6tbMPyVfCdVt63fVR3ruCoJeQyiKS0aTLkcPxfi7ncvDjJJr6JQPZ0H syj+V6/63V0j4jLxtgDEeXk3yVjCO7FijYCSzPGQNiZWqKF6cmq/GsoBAS7pptchY5kA=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vj9T8-0002hw-SJ; Fri, 23 Jan 2026 05:12:26 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vj9T8-0002ho-1g for linux-f2fs-devel@lists.sourceforge.net; Fri, 23 Jan 2026 05:12:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4Jqp+gWUNSNLiAWDtTK+Alw28/gUycqDxeXrGjI52iM=; b=crPi6QSA27CFmlErIECfT+soI4 v1hTdK7A84XjaYxbml7LQCuFVIUfeU/Di1+nOLyb5+XnaxP0dnhdJdKPWQmnRRRRNjPqE1IlzAQL0 zpTmXqxfDGPAcCF/dhCWztMZKHU+/+yst7Cw7hKfFzDvW9UcIx1pWSYSxGplP8T16PdM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4Jqp+gWUNSNLiAWDtTK+Alw28/gUycqDxeXrGjI52iM=; b=Wl+n2qY3icraM8z7ypI8NU+4GW 5UodlIL7a/wjpiuubOngH8RhPvQP+lS0BFMkz3FZ+udvH9sOwF96aGdkP01AUsCsngauVDNB9ag6p E9ohpQdgZQztPynI3IN29/oVqe1LrAQShy68nA4swltu0xO4yQuA2b6345QLhAV1j1qQ=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vj9T7-0006FZ-Bi for linux-f2fs-devel@lists.sourceforge.net; Fri, 23 Jan 2026 05:12:25 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id A85EC227AA8; Fri, 23 Jan 2026 06:12:16 +0100 (CET) Date: Fri, 23 Jan 2026 06:12:16 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Message-ID: <20260123051216.GA24123@lst.de> References: <20260122082214.452153-1-hch@lst.de> <20260122082214.452153-5-hch@lst.de> <20260122212700.GD5910@frogsfrogsfrogs> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260122212700.GD5910@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1vj9T7-0006FZ-Bi Subject: Re: [f2fs-dev] [PATCH 04/11] fsverity: start consolidating pagecache code X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fsverity@lists.linux.dev, Christian Brauner , Jan Kara , Andrey Albershteyn , t@magnolia.djwong.org, "Matthew Wilcox \(Oracle\)" , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fsdevel@vger.kernel.org, Al Viro , Jaegeuk Kim , David Sterba , Theodore Ts'o , linux-ext4@vger.kernel.org, Christoph Hellwig , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gVGh1LCBKYW4gMjIsIDIwMjYgYXQgMDE6Mjc6MDBQTSAtMDgwMCwgRGFycmljayBKLiBXb25n IHdyb3RlOgo+IE5pY2UgaG9pc3QsIHRob3VnaCBJIHdvbmRlciAtLSBhcyBhbiBleHBvcnRlZCBm cyBmdW5jdGlvbiwgc2hvdWxkIHdlIGJlCj4gY2hlY2tpbmcgdGhhdCB0aGUgcmV0dXJuZWQgZm9s aW8gZG9lc24ndCBjb3ZlciBFT0Y/ICBOb3QgdGhhdCBhbnkgb2YgdGhlCj4gdXNlcnMgYWN0dWFs bHkgY2hlY2sgdGhhdCByZXR1cm5lZCBtZXJrbGUgdHJlZSBmb2xpb3MgZml0IHRoYXQKPiBjcml0 ZXJpb24uCgpBcyBpbiBwYXN0IGlfc2l6ZSBiZWNhdXNlIHRoaXMgaXMgdmVyaXR5IG1ldGFkYXRh PyAgSSB0aGluayBwZXIgdGhlCmxhc3QgZGlzY3Vzc2lvbiB0aGF0J3Mgb25seSBndXJhbnRlZWQg dG8gYmUgdHJ1ZSwgbm90IHRoZSBmb2xpby4gIEl0Cm1pZ2h0IGJlIHVzZWZ1bCB0byBhc3NlcnQg dGhpcywgYnV0IGl0IG1pZ2h0IGJlIGJldHRlciBmb3IgY29tYmluZQp0aGlzIHdpdGggdGhlIHdv cmsgdG8gdXNlIGRpZmZlcmVudCBvbi1kaXNrIHZzIGluLW1lbW9yeSBvZmZzZXQKYW5kIHRvIGNv bnNvbGlkYXRlIGFsbCB0aGUgb2Zmc2V0IG1hZ2ljLiAgV2hpY2ggaXMgd29ydGh3aGlsZSwKYnV0 INCGIGRvbid0IHJlYWxseSB3YW50IHRvIGFkZCB0aGF0IGluIHRoaXMgc2VyaWVzLgoKCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1mMmZzLWRl dmVsIG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApo dHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1mMmZzLWRl dmVsCg==