From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4550C22A4CC for ; Fri, 23 Jan 2026 07:24:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769153078; cv=none; b=EEPuJPSBEG5swECA5wm6vByxOVzb1OlkIZOdIGV5mKY+t+Quo8dl3kJIcHULII3hr1B7ulzWmi0fss4HDjLHhCDYm4BFphe7MUfxY0FH6sWjIk7TFlzPlMz2Ax3pqPGXuKOjQezoVbXWcIsdPYvSy77HlzQQthfz/yXY/YnLhPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769153078; c=relaxed/simple; bh=Tdc9xwIa7aB3BlCpIOjUKl9IwWx6UPKNoW05Ii8kmec=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PvKko0hVeN2KYAoyW5K9MRXCYM1oqKIXDMi5FSc8niLP/y1TU2yzWSrQ9BIXEdkGIEUoRmDqz8OQjyRx5OwY6cjZkRaW11Sd449c4tr2Cnh/vorDKfiDRzF/+W1EafhAZV3qNx3AAdlFMOpIzWvL8lKAGwhSR4KQj9iIOjaLRmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 06C25227AAE; Fri, 23 Jan 2026 08:24:34 +0100 (CET) Date: Fri, 23 Jan 2026 08:24:33 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Eric Biggers , Al Viro , Christian Brauner , Jan Kara , David Sterba , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Andrey Albershteyn , "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, fsverity@lists.linux.dev Subject: Re: [PATCH 07/11] fs: consolidate fsverity_info lookup in buffer.c Message-ID: <20260123072433.GA27421@lst.de> References: <20260122082214.452153-1-hch@lst.de> <20260122082214.452153-8-hch@lst.de> <20260122214958.GG5910@frogsfrogsfrogs> <20260123051556.GC24123@lst.de> <20260123072329.GL5910@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: fsverity@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260123072329.GL5910@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Jan 22, 2026 at 11:23:29PM -0800, Darrick J. Wong wrote: > On Fri, Jan 23, 2026 at 06:15:56AM +0100, Christoph Hellwig wrote: > > On Thu, Jan 22, 2026 at 01:49:58PM -0800, Darrick J. Wong wrote: > > > Well this is no longer a weird ext4ism, since f2fs also needs this, > > > right? Maybe this comment should read: > > > > f2fs doesn't use buffer heads. So this is just because ext4 only > > implements the easy parts of ->read_folio and ->readahead itself and > > falls back onto the generic code for the rest, which then had to be > > grow hacky ext4-specific bits like this for it :( > > Yikes. So I guess we shouldn't genericise the comment to encourage more > people to do the same thing ext4 did? I don't think so. I actually need to send a ping to the ext4 folks that maybe, maybe they really should handle all reads into the page cache in their own code so that we can hopefully kill this entirely. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BF6BD72340 for ; Fri, 23 Jan 2026 07:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SvNUCvjrtKmBImqyeYs3ustJkBpqjOfMWoo9YTtvh4Y=; b=iiXa+XUMeww8i3K8Qyuecihpya D+vMZJ8byG1Crr9F+WbVBAQU3uLLm7Sz7M/8IHWVgcy43XHWuhauEM1d04NoW/OFJ6uSik72NCPdG ub+1HNSmK8pzhc8uV8dZ2lMI+6zACQ4p5lhGwDVnuzyEsTCrSpRjqze01EGh7nTe7CQE=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vjBXE-0001eK-Af; Fri, 23 Jan 2026 07:24:49 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vjBXC-0001e7-U2 for linux-f2fs-devel@lists.sourceforge.net; Fri, 23 Jan 2026 07:24:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=D5hT19nk1G0CmEcMDf6P+tt6pycdzLu56FhXz3+jIfo=; b=WxAOdo7U3yxIUmsuOMUANxltYB fBzZIq93oMTJL8AfNFB8p2FH/rY+Ql73PjbtZr0yhjzWoMUKI2xQC3rXyHewa41h2cdrXJPxjZ0Jz Cs3Q/hZfiVdd+UQ00ySFs/9cCkaJRHqoxR+aopExr6UmW5JIit2kB5b5XgpnvLm2bsEU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=D5hT19nk1G0CmEcMDf6P+tt6pycdzLu56FhXz3+jIfo=; b=g8GfBP8OCxy5f8gxQbfIJir/cP 32ipG0cvZyfdtJNm2KwtUoliIjFQhSi7WNd/CJh7L8E11xNOJ11hVHsqXphwDWk0yxH7YEht7KlYH BiJNyAsbW+x3CFCOa80w9I34Cxzx512HmQXx1nBq+FXahAwE+RIr1JKX3XF/Ua99bVkA=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vjBXD-00038j-3J for linux-f2fs-devel@lists.sourceforge.net; Fri, 23 Jan 2026 07:24:47 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 06C25227AAE; Fri, 23 Jan 2026 08:24:34 +0100 (CET) Date: Fri, 23 Jan 2026 08:24:33 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Message-ID: <20260123072433.GA27421@lst.de> References: <20260122082214.452153-1-hch@lst.de> <20260122082214.452153-8-hch@lst.de> <20260122214958.GG5910@frogsfrogsfrogs> <20260123051556.GC24123@lst.de> <20260123072329.GL5910@frogsfrogsfrogs> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260123072329.GL5910@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1vjBXD-00038j-3J Subject: Re: [f2fs-dev] [PATCH 07/11] fs: consolidate fsverity_info lookup in buffer.c X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fsverity@lists.linux.dev, Christian Brauner , Jan Kara , Andrey Albershteyn , "Matthew Wilcox \(Oracle\)" , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fsdevel@vger.kernel.org, Al Viro , Jaegeuk Kim , David Sterba , Theodore Ts'o , linux-ext4@vger.kernel.org, Christoph Hellwig , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Jan 22, 2026 at 11:23:29PM -0800, Darrick J. Wong wrote: > On Fri, Jan 23, 2026 at 06:15:56AM +0100, Christoph Hellwig wrote: > > On Thu, Jan 22, 2026 at 01:49:58PM -0800, Darrick J. Wong wrote: > > > Well this is no longer a weird ext4ism, since f2fs also needs this, > > > right? Maybe this comment should read: > > > > f2fs doesn't use buffer heads. So this is just because ext4 only > > implements the easy parts of ->read_folio and ->readahead itself and > > falls back onto the generic code for the rest, which then had to be > > grow hacky ext4-specific bits like this for it :( > > Yikes. So I guess we shouldn't genericise the comment to encourage more > people to do the same thing ext4 did? I don't think so. I actually need to send a ping to the ext4 folks that maybe, maybe they really should handle all reads into the page cache in their own code so that we can hopefully kill this entirely. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel