From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75C87D72379 for ; Fri, 23 Jan 2026 11:39:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vjFVy-0002ZO-85; Fri, 23 Jan 2026 06:39:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjFVw-0002Y9-QE; Fri, 23 Jan 2026 06:39:44 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjFVu-00060G-Po; Fri, 23 Jan 2026 06:39:44 -0500 Received: from mail.maildlp.com (unknown [172.18.224.150]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4dyGDB4LNXzJ46XN; Fri, 23 Jan 2026 19:39:06 +0800 (CST) Received: from dubpeml500005.china.huawei.com (unknown [7.214.145.207]) by mail.maildlp.com (Postfix) with ESMTPS id DDE164056A; Fri, 23 Jan 2026 19:39:35 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml500005.china.huawei.com (7.214.145.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 23 Jan 2026 11:39:34 +0000 Date: Fri, 23 Jan 2026 11:39:33 +0000 To: Shameer Kolothum CC: , , , , , , , , , , , , , , , , , , , "Michael S . Tsirkin" Subject: Re: [PATCH v8 34/37] hw/pci: Add helper to insert PCIe extended capability at a fixed offset Message-ID: <20260123113933.00003456@huawei.com> In-Reply-To: <20260121175248.87649-35-skolothumtho@nvidia.com> References: <20260121175248.87649-1-skolothumtho@nvidia.com> <20260121175248.87649-35-skolothumtho@nvidia.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.15] X-ClientProxiedBy: lhrpeml500009.china.huawei.com (7.191.174.84) To dubpeml500005.china.huawei.com (7.214.145.207) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Wed, 21 Jan 2026 17:52:39 +0000 Shameer Kolothum wrote: > Add pcie_insert_capability(), a helper to insert a PCIe extended > capability into an existing extended capability list at a caller > specified offset. > > Unlike pcie_add_capability(), which always appends a capability to the > end of the list, this helper preserves the existing list ordering while > allowing insertion at an arbitrary offset. > > The helper only validates that the insertion does not overwrite an > existing PCIe extended capability header, since corrupting a header > would break the extended capability linked list. Validation of overlaps > with other configuration space registers or capability-specific > register blocks is left to the caller. > > Reviewed-by: Michael S. Tsirkin > Reviewed-by: Eric Auger > Tested-by: Eric Auger > Tested-by: Zhangfei Gao > Signed-off-by: Shameer Kolothum Reviewed-by: Jonathan Cameron From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4321D7236C for ; Fri, 23 Jan 2026 11:40:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vjFVz-0002ZN-Rn; Fri, 23 Jan 2026 06:39:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjFVw-0002Y9-QE; Fri, 23 Jan 2026 06:39:44 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjFVu-00060G-Po; Fri, 23 Jan 2026 06:39:44 -0500 Received: from mail.maildlp.com (unknown [172.18.224.150]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4dyGDB4LNXzJ46XN; Fri, 23 Jan 2026 19:39:06 +0800 (CST) Received: from dubpeml500005.china.huawei.com (unknown [7.214.145.207]) by mail.maildlp.com (Postfix) with ESMTPS id DDE164056A; Fri, 23 Jan 2026 19:39:35 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml500005.china.huawei.com (7.214.145.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 23 Jan 2026 11:39:34 +0000 Date: Fri, 23 Jan 2026 11:39:33 +0000 To: Shameer Kolothum CC: , , , , , , , , , , , , , , , , , , , "Michael S . Tsirkin" Subject: Re: [PATCH v8 34/37] hw/pci: Add helper to insert PCIe extended capability at a fixed offset Message-ID: <20260123113933.00003456@huawei.com> In-Reply-To: <20260121175248.87649-35-skolothumtho@nvidia.com> References: <20260121175248.87649-1-skolothumtho@nvidia.com> <20260121175248.87649-35-skolothumtho@nvidia.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.15] X-ClientProxiedBy: lhrpeml500009.china.huawei.com (7.191.174.84) To dubpeml500005.china.huawei.com (7.214.145.207) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via qemu development Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 21 Jan 2026 17:52:39 +0000 Shameer Kolothum wrote: > Add pcie_insert_capability(), a helper to insert a PCIe extended > capability into an existing extended capability list at a caller > specified offset. > > Unlike pcie_add_capability(), which always appends a capability to the > end of the list, this helper preserves the existing list ordering while > allowing insertion at an arbitrary offset. > > The helper only validates that the insertion does not overwrite an > existing PCIe extended capability header, since corrupting a header > would break the extended capability linked list. Validation of overlaps > with other configuration space registers or capability-specific > register blocks is left to the caller. > > Reviewed-by: Michael S. Tsirkin > Reviewed-by: Eric Auger > Tested-by: Eric Auger > Tested-by: Zhangfei Gao > Signed-off-by: Shameer Kolothum Reviewed-by: Jonathan Cameron