From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, hch@lst.de, r772577952@gmail.com,
stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/5] xfs: fix UAF in xchk_btree_check_block_owner
Date: Fri, 23 Jan 2026 15:14:36 +0100 [thread overview]
Message-ID: <20260123141436.GD25834@lst.de> (raw)
In-Reply-To: <176915153782.1677852.511726226065469460.stgit@frogsfrogsfrogs>
On Thu, Jan 22, 2026 at 11:04:08PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> We cannot dereference bs->cur when trying to determine if bs->cur
> aliases bs->sc->sa.{bno,rmap}_cur after the latter has been freed.
> Fix this by sampling before type before any freeing could happen.
> The correct temporal ordering was broken when we removed xfs_btnum_t.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-01-23 14:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 7:00 [PATCHSET 3/3] xfs: syzbot fixes for online fsck Darrick J. Wong
2026-01-23 7:03 ` [PATCH 1/5] xfs: get rid of the xchk_xfile_*_descr calls Darrick J. Wong
2026-01-23 14:13 ` Christoph Hellwig
2026-01-23 18:22 ` Jiaming Zhang
2026-01-23 7:03 ` [PATCH 2/5] xfs: only call xf{array,blob}_destroy if we have a valid pointer Darrick J. Wong
2026-01-23 14:13 ` Christoph Hellwig
2026-01-23 18:23 ` Jiaming Zhang
2026-01-23 7:03 ` [PATCH 3/5] xfs: check return value of xchk_scrub_create_subord Darrick J. Wong
2026-01-23 14:14 ` Christoph Hellwig
2026-01-23 18:24 ` Jiaming Zhang
2026-01-23 7:04 ` [PATCH 4/5] xfs: fix UAF in xchk_btree_check_block_owner Darrick J. Wong
2026-01-23 14:14 ` Christoph Hellwig [this message]
2026-01-23 18:24 ` Jiaming Zhang
2026-01-23 7:04 ` [PATCH 5/5] xfs: check for deleted cursors when revalidating two btrees Darrick J. Wong
2026-01-23 14:16 ` Christoph Hellwig
2026-01-23 18:25 ` Jiaming Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123141436.GD25834@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=r772577952@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.