All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: Ryan Eatmon <reatmon@ti.com>
Cc: Paresh Bhagat <p-bhagat@ti.com>,
	meta-arago@lists.yoctoproject.org, praneeth@ti.com,
	v-singh1@ti.com, c-shilwant@ti.com, khasim@ti.com, afd@ti.com,
	devarsht@ti.com
Subject: Re: [scarthgap][RFC PATCH 3/3] tisdk-default-image: Add audio server support for am62dxx
Date: Fri, 23 Jan 2026 12:01:12 -0500	[thread overview]
Message-ID: <20260123170112.GC11121@denix.org> (raw)
In-Reply-To: <446b4187-af51-4af9-b97f-97058399cdb6@ti.com>

On Fri, Jan 23, 2026 at 10:11:06AM -0600, Ryan Eatmon wrote:
> 
> 
> On 1/23/2026 12:03 AM, Paresh Bhagat wrote:
> >Add pipewire and wireplumber audio stack support for am62dxx:
> >- Include pipewire core components and tools
> >- Add ALSA and PulseAudio compatibility layers
> >- Include wireplumber session manager
> >- Add GStreamer pipewire plugin
> >- Configure pipewire with proper modules and plugins
> >
> >Signed-off-by: Paresh Bhagat <p-bhagat@ti.com>
> >---
> >  .../recipes-core/images/tisdk-default-image.bb  | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >
> >diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> >index 264d1b2d..d5db6fd4 100644
> >--- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> >+++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> >@@ -47,3 +47,20 @@ IMAGE_INSTALL += "\
> >      ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \
> >      docker \
> >  "
> >+
> >+IMAGE_INSTALL:append:am62dxx = " \
> >+    pipewire \
> >+    pipewire-tools \
> >+    pipewire-alsa \
> >+    pipewire-pulse \
> >+    wireplumber \
> >+    speexdsp \
> >+    libpipewire \
> >+    pipewire-spa-plugins-meta \
> >+    pipewire-spa-tools \
> >+    pipewire-modules-meta \
> >+    pipewire-alsa-card-profile \
> >+    gstreamer1.0-pipewire \
> >+"
> 
> I'm sure at some point we will want to push the "more modern"
> pipewire to other boards as well.  What is the reasoning for only
> doing this on am62d?
> 
> Please create a PIPEWIRE variable that contains the above list and then:
> 
> IMAGE_INSTALL:append:am62dxx = " ${PIPEWIRE}"
> 
> Also, for ease of looking up packages, please sort the list alphabetically.
> 
> 
> >+PACKAGECONFIG:append:am62dxx:pn-pipewire = " pipewire-jack pipewire-modules pipewire-spa-plugins"

Huh? pipewire-modules and pipewire-spa-plugins are not PACKAGECONFIGs, but 
packages...


> >+PACKAGECONFIG:remove:am62dxx:pn-pipewire = " jack"

No leading space is needed here.


> Agree with Yogesh.  This is not appropriate in this file.  This
> should be in a pipewire bbappend.

Or rather generically in the distro config, as I suggested last week.

-- 
Denys


  reply	other threads:[~2026-01-23 17:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23  6:03 [scarthgap][RFC PATCH 0/3] Add pipeWire audio stack for am62dxx Paresh Bhagat
2026-01-23  6:03 ` [scarthgap][RFC PATCH 1/3] recipes-multimedia: Add pipewire configuration files Paresh Bhagat
2026-01-23  6:47   ` [meta-arago] " Yogesh Hegde
2026-01-23 16:03   ` Ryan Eatmon
2026-01-23 17:03     ` [meta-arago] " Denys Dmytriyenko
2026-01-23  6:03 ` [scarthgap][RFC PATCH 2/3] recipes-multimedia: Add wireplumber audio configuration Paresh Bhagat
2026-01-23  7:07   ` [meta-arago] " Yogesh Hegde
2026-01-23  6:03 ` [scarthgap][RFC PATCH 3/3] tisdk-default-image: Add audio server support for am62dxx Paresh Bhagat
2026-01-23  7:19   ` [meta-arago] " Yogesh Hegde
2026-01-23 16:11   ` Ryan Eatmon
2026-01-23 17:01     ` Denys Dmytriyenko [this message]
2026-01-23 17:14       ` Ryan Eatmon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260123170112.GC11121@denix.org \
    --to=denis@denix.org \
    --cc=afd@ti.com \
    --cc=c-shilwant@ti.com \
    --cc=devarsht@ti.com \
    --cc=khasim@ti.com \
    --cc=meta-arago@lists.yoctoproject.org \
    --cc=p-bhagat@ti.com \
    --cc=praneeth@ti.com \
    --cc=reatmon@ti.com \
    --cc=v-singh1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.