From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6D43D778AF for ; Fri, 23 Jan 2026 19:45:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 25CEB10EBD1; Fri, 23 Jan 2026 19:45:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="LIIi02yM"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id E54E110EBD1 for ; Fri, 23 Jan 2026 19:45:48 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 04F03600CB; Fri, 23 Jan 2026 19:45:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF5DFC4AF09; Fri, 23 Jan 2026 19:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769197547; bh=Nk5uzwoANqoRcY0cyp5LaiHtC5a0UyLUtk/IP3OWMKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LIIi02yMrQuLR+TVEFHs16e/I1F4H7xVXaJChuCbpQfnDLX4uyiUQvg9zPm6crSOM ihrR+MUO5UpOfgirGWahj2tellfWWVxKxWlsQ9isznVPcUsOjWuEZxBGTwEZaySc+Q d+cO12Wwz/aRnQYcsmdpo8M3qxfO2g5kl0GQ+3k4DCWWY5tfXxNLTcxn6SP1EKgV+j ZqXV9pCuw3euXYs8Ycpqx46o/065Pmp+/OMZ41423AocyKevMpox5R17H9vYR3QQrO K9kXYe/Wh9Jrj06MHvbnHYqwform/dWZM6Qc+PJZEk/Ccfzclr7GrMqEfE6VRwitw8 KqHen0oAbEyuQ== Date: Fri, 23 Jan 2026 12:45:42 -0700 From: Nathan Chancellor To: Nicolas Frattaroli Cc: Sasha Levin , Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chia-I Wu , Karunika Choo , kernel@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v10 3/4] drm/panthor: Add tracepoint for hardware utilisation changes Message-ID: <20260123194542.GA75720@ax162> References: <20260116-panthor-tracepoints-v10-0-d925986e3d1b@collabora.com> <20260116-panthor-tracepoints-v10-3-d925986e3d1b@collabora.com> <3154579.irdbgypaU6@workhorse> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3154579.irdbgypaU6@workhorse> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jan 23, 2026 at 01:52:19PM +0100, Nicolas Frattaroli wrote: > On Friday, 23 January 2026 05:02:21 Central European Standard Time Sasha Levin wrote: > > With this commit, I'm seeing: > > > > In file included from drivers/gpu/drm/panthor/panthor_trace.h:86, > > from drivers/gpu/drm/panthor/panthor_gpu.c:26: > > ./include/trace/define_trace.h:118:42: fatal error: ./panthor_trace.h: No such file or directory > > 118 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) > > > > I think we need to add in 'CFLAGS_panthor_gpu.o := -I$(src)' to the Makefile > > too, but I haven't tested that yet. > > > > > > Huh, puzzling that I never ran into this build failure. > > Doing another build right now, I still can't reproduce it even on a clean > build without ccache. Your fix looks appropriate though judging by the LWM[1] > series on event tracepoints. > > I'll submit a fix for this. You will only see this when building in-tree (i.e., no O= or KBUILD_OUTPUT) because $(src) and $(obj) are only added to the include path automatically when building out of tree (see scripts/Makefile.lib, search for 'ifdef building_out_of_srctree'), which could explain why you (and presumably Mark doing -next) have not seen this error yet. $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- O=build defconfig drivers/gpu/drm/panthor/panthor_gpu.o $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- defconfig drivers/gpu/drm/panthor/panthor_gpu.o In file included from drivers/gpu/drm/panthor/panthor_trace.h:86, from drivers/gpu/drm/panthor/panthor_gpu.c:26: ./include/trace/define_trace.h:118:42: fatal error: ./panthor_trace.h: No such file or directory 118 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) | ^ compilation terminated. Cheers, Nathan