From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jan Remmet <j.remmet@phytec.de>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
upstream@lists.phytec.de
Subject: Re: [PATCH v2] usb: typec: hd3ss3220: Enable VBUS based on role state
Date: Fri, 23 Jan 2026 17:19:06 +0100 [thread overview]
Message-ID: <2026012343-rockfish-candle-d3d9@gregkh> (raw)
In-Reply-To: <20260123-wip-jremmet-hd3ss3220_vbus-v2-1-bcad313ce92b@phytec.de>
On Fri, Jan 23, 2026 at 03:52:37PM +0100, Jan Remmet wrote:
> For systems where the ID pin isn't available as gpio use the ATTACHED_STATE
> register instead to control vbus.
>
> >From the datasheet:
> "This is an additional method to communicate attach other
> than the ID pin. These bits can be read by the application to
> determine what was attached."
>
> Use this method if id-gpios property is not set, but the connector node
> has vbus-supply defined.
>
> Check regulator state as peripheral and detach can disable vbus.
>
> Signed-off-by: Jan Remmet <j.remmet@phytec.de>
> ---
> Changes in v2:
> - Added check if regulator is already disabled. As detach and
> peripheral mode cause an interrupt.
> - Link to v1: https://lore.kernel.org/r/20260115-wip-jremmet-hd3ss3220_vbus-v1-1-b7d9adfbe346@phytec.de
> ---
> drivers/usb/typec/hd3ss3220.c | 30 +++++++++++++++++++++---------
> 1 file changed, 21 insertions(+), 9 deletions(-)
Does not apply against my tree, what did you make it against? Can you
redo this against linux-next and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2026-01-23 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 14:52 [PATCH v2] usb: typec: hd3ss3220: Enable VBUS based on role state Jan Remmet
2026-01-23 16:19 ` Greg Kroah-Hartman [this message]
2026-01-26 8:04 ` Jan Remmet
2026-01-26 9:05 ` Greg Kroah-Hartman
2026-01-26 10:32 ` Jan Remmet
2026-01-26 10:42 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026012343-rockfish-candle-d3d9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=j.remmet@phytec.de \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.