From: Jakub Kicinski <kuba@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH v2 2/3] net: phy: as21xxx: add support for DBG command
Date: Sun, 25 Jan 2026 14:33:26 -0800 [thread overview]
Message-ID: <20260125143326.35d1a2d8@kernel.org> (raw)
In-Reply-To: <20260123120117.10883-3-ansuelsmth@gmail.com>
On Fri, 23 Jan 2026 13:00:30 +0100 Christian Marangi wrote:
> Rework the msg send logic to support sending DBG command.
>
> These DBG command use a special way to send and receive data and use
> data in u8 size and are used to tweak advanced (and later introduced)
> feature of the PHY.
Unfortunately we can't have unused static functions, even transiently:
drivers/net/phy/as21xxx.c:631:12: warning: unused function 'aeon_ipc_poll' [-Wunused-function]
631 | static int aeon_ipc_poll(struct phy_device *phydev)
| ^~~~~~~~~~~~~
drivers/net/phy/as21xxx.c:653:12: warning: unused function 'aeon_ipc_dbg_cmd' [-Wunused-function]
653 | static int aeon_ipc_dbg_cmd(struct phy_device *phydev, u16 dbg_sec,
| ^~~~~~~~~~~~~~~~
drivers/net/phy/as21xxx.c:666:12: warning: unused function 'aeon_ipc_dbg_read_buf' [-Wunused-function]
666 | static int aeon_ipc_dbg_read_buf(struct phy_device *phydev, u16 *buf)
| ^~~~~~~~~~~~~~~~~~~~~
drivers/net/phy/as21xxx.c:689:12: warning: unused function 'aeon_ipc_dbg_write_buf' [-Wunused-function]
689 | static int aeon_ipc_dbg_write_buf(struct phy_device *phydev, u8 *data,
| ^~~~~~~~~~~~~~~~~~~~~~
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-25 22:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 12:00 [net-next PATCH v2 0/3] net: phy: as21xxx: toggle In Band feature support Christian Marangi
2026-01-23 12:00 ` [net-next PATCH v2 1/3] net: phy: as21xxx: save firmware version major/minor version Christian Marangi
2026-01-23 12:00 ` [net-next PATCH v2 2/3] net: phy: as21xxx: add support for DBG command Christian Marangi
2026-01-25 22:33 ` Jakub Kicinski [this message]
2026-01-23 12:00 ` [net-next PATCH v2 3/3] net: phy: as21xxx: fill in inband caps and better handle inband Christian Marangi
2026-01-23 12:16 ` [net-next PATCH v2 0/3] net: phy: as21xxx: toggle In Band feature support Russell King (Oracle)
2026-01-23 13:09 ` Christian Marangi
2026-01-23 13:35 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260125143326.35d1a2d8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.