Re: [RFC v1 09/11] media: platform: Add NXP Neoisp Image Signal Processor

[kernel test robot <lkp@intel.com>]

Hi Antoine,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on shawnguo/for-next]
[also build test WARNING on linus/master v6.19-rc6 next-20260123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Antoine-Bouyer/media-uapi-v4l2-isp-Add-v4l2-ISP-extensible-statistics-definitions/20260123-161422
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link:    https://lore.kernel.org/r/20260123080938.3367348-10-antoine.bouyer%40nxp.com
patch subject: [RFC v1 09/11] media: platform: Add NXP Neoisp Image Signal Processor
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20260125/202601251949.tfmL0ZqH-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260125/202601251949.tfmL0ZqH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601251949.tfmL0ZqH-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/media/platform/nxp/neoisp/neoisp_ctx.c: In function 'neoisp_ctx_update_buf_addr':
>> drivers/media/platform/nxp/neoisp/neoisp_ctx.c:1841:20: warning: variable 'height' set but not used [-Wunused-but-set-variable]
    1841 |         u32 width, height, ibpp, inp0_stride, inp1_stride;
         |                    ^~~~~~
>> drivers/media/platform/nxp/neoisp/neoisp_ctx.c:1841:13: warning: variable 'width' set but not used [-Wunused-but-set-variable]
    1841 |         u32 width, height, ibpp, inp0_stride, inp1_stride;
         |             ^~~~~


vim +/height +1841 drivers/media/platform/nxp/neoisp/neoisp_ctx.c

  1828	
  1829	/*
  1830	 * Set pipe conf volatile settings (i.e. buffer addresses)
  1831	 */
  1832	void neoisp_ctx_update_buf_addr(struct neoisp_dev_s *neoispd)
  1833	{
  1834		struct neoisp_job_s *job = &neoispd->queued_job;
  1835		struct neoisp_pipe_conf_s *cfg = &job->node_group->context->hw.pipe_conf.common;
  1836		struct neoisp_buffer_s *buf_inp0 = job->buf[NEOISP_INPUT0_NODE];
  1837		struct neoisp_buffer_s *buf_inp1 = job->buf[NEOISP_INPUT1_NODE];
  1838		struct neoisp_buffer_s *buf_out = job->buf[NEOISP_FRAME_NODE];
  1839		struct neoisp_buffer_s *buf_ir = job->buf[NEOISP_IR_NODE];
  1840		struct neoisp_node_s *nd;
> 1841		u32 width, height, ibpp, inp0_stride, inp1_stride;
  1842		dma_addr_t inp0_addr, inp1_addr;
  1843	
  1844		/* Input0 specific */
  1845		nd = &job->node_group->node[NEOISP_INPUT0_NODE];
  1846		width = nd->crop.width;
  1847		height = nd->crop.height;
  1848		ibpp = (nd->neoisp_format->bit_depth + 7) / 8;
  1849		inp0_stride = nd->format.fmt.pix_mp.plane_fmt[0].bytesperline;
  1850	
  1851		/* Input0 - Take crop into account if any */
  1852		inp0_addr = get_addr(buf_inp0, 0) + (nd->crop.left * ibpp) + (nd->crop.top * inp0_stride);
  1853	
  1854		/* Input 1 specific */
  1855		nd = &job->node_group->node[NEOISP_INPUT1_NODE];
  1856		ibpp = (nd->neoisp_format->bit_depth + 7) / 8;
  1857		inp1_stride = nd->format.fmt.pix_mp.plane_fmt[0].bytesperline;
  1858	
  1859		/* Input1 - Take crop into account if any */
  1860		inp1_addr = get_addr(buf_inp1, 0) + (nd->crop.left * ibpp) + (nd->crop.top * inp1_stride);
  1861	
  1862		cfg->img0_in_addr =
  1863			NEO_PIPE_CONF_ADDR_SET(inp0_addr);
  1864	
  1865		/* Handle hdr inputs */
  1866		nd = &job->node_group->node[NEOISP_INPUT1_NODE];
  1867		if (neoisp_node_link_is_enabled(nd)) {
  1868			cfg->img1_in_addr =
  1869				NEO_PIPE_CONF_ADDR_SET(inp1_addr);
  1870		}
  1871	
  1872		nd = &job->node_group->node[NEOISP_FRAME_NODE];
  1873		if (neoisp_node_link_is_enabled(nd)) {
  1874			/* Planar/multiplanar output image addresses */
  1875			switch (nd->format.fmt.pix_mp.pixelformat) {
  1876			case V4L2_PIX_FMT_GREY:
  1877			case V4L2_PIX_FMT_Y10:
  1878			case V4L2_PIX_FMT_Y12:
  1879			case V4L2_PIX_FMT_Y16:
  1880			case V4L2_PIX_FMT_Y16_BE:
  1881				/* Monochrome formats: only output channel 0 is used */
  1882				cfg->outch0_addr =
  1883					NEO_PIPE_CONF_ADDR_SET(get_addr(buf_out, 0));
  1884				break;
  1885			case V4L2_PIX_FMT_NV12:
  1886			case V4L2_PIX_FMT_NV21:
  1887			case V4L2_PIX_FMT_NV16:
  1888			case V4L2_PIX_FMT_NV61:
  1889				/* Semi-Planar formats: both output channels are used */
  1890				cfg->outch0_addr =
  1891					NEO_PIPE_CONF_ADDR_SET(get_addr(buf_out, 0));
  1892				cfg->outch1_addr =
  1893					NEO_PIPE_CONF_ADDR_SET(get_addr(buf_out, 1));
  1894				break;
  1895			default:
  1896				/* Interleaved formats: only output channel 1 is used */
  1897				cfg->outch1_addr =
  1898					NEO_PIPE_CONF_ADDR_SET(get_addr(buf_out, 0));
  1899				break;
  1900			}
  1901		}
  1902	
  1903		nd = &job->node_group->node[NEOISP_IR_NODE];
  1904		if (neoisp_node_link_is_enabled(nd))
  1905			cfg->outir_addr =
  1906				NEO_PIPE_CONF_ADDR_SET(get_addr(buf_ir, 0));
  1907	}
  1908	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki