From: "Günther Noack" <gnoack3000@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "Mickaël Salaün" <mic@digikod.net>,
linux-security-module@vger.kernel.org,
"Tingmao Wang" <m@maowtm.org>,
"Justin Suess" <utilityemal77@gmail.com>,
"Samasth Norway Ananda" <samasth.norway.ananda@oracle.com>,
"Matthieu Buffet" <matthieu@buffet.re>,
"Mikhail Ivanov" <ivanov.mikhail1@huawei-partners.com>,
konstantin.meskhidze@huawei.com
Subject: Re: [PATCH v2 3/3] landlock: transpose the layer masks data structure
Date: Mon, 26 Jan 2026 17:52:16 +0100 [thread overview]
Message-ID: <20260126.fd8c7b7537e1@gnoack.org> (raw)
In-Reply-To: <7b7b8fd5-7e1f-4572-a342-11a0fd24b0ac@infradead.org>
On Sun, Jan 25, 2026 at 02:02:50PM -0800, Randy Dunlap wrote:
> The first line here is confusing: "in @rule in @masks"
> Maybe:
>
> On 1/25/26 11:58 AM, Günther Noack wrote:
> > +/**
> > + * landlock_unmask_layers - Cross off access rights granted in @rule in @masks
>
> - Update (or Remove) access rights in @masks that are
> granted in @rules
>
> ?
Thanks, that is a better wording indeed.
Will be included in next patch set version,
I think this is less grammatically ambiguous:
- * landlock_unmask_layers - Cross off access rights granted in @rule in @masks
+ * landlock_unmask_layers - Remove the access rights in @masks
+ * which are granted in @rule
–Günther
next prev parent reply other threads:[~2026-01-26 16:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 19:58 [PATCH v2 0/3] landlock: Refactor layer masks Günther Noack
2026-01-25 19:58 ` [PATCH v2 1/3] selftests/landlock: Add filesystem access benchmark Günther Noack
2026-01-28 21:31 ` Mickaël Salaün
2026-02-06 12:24 ` Günther Noack
2026-02-06 12:59 ` Mickaël Salaün
2026-02-06 15:05 ` Günther Noack
2026-01-25 19:58 ` [PATCH v2 2/3] landlock: access_mask_subset() helper Günther Noack
2026-01-25 21:48 ` Randy Dunlap
2026-01-26 16:48 ` Günther Noack
2026-01-28 21:31 ` Mickaël Salaün
2026-01-28 21:38 ` Günther Noack
2026-01-25 19:58 ` [PATCH v2 3/3] landlock: transpose the layer masks data structure Günther Noack
2026-01-25 22:02 ` Randy Dunlap
2026-01-26 16:52 ` Günther Noack [this message]
2026-01-26 17:55 ` Randy Dunlap
2026-01-28 21:34 ` Mickaël Salaün
2026-01-29 7:56 ` Günther Noack
2026-01-29 16:54 ` Mickaël Salaün
2026-02-06 8:02 ` Günther Noack
2026-01-29 20:28 ` Mickaël Salaün
2026-02-01 12:24 ` Günther Noack
2026-01-28 21:31 ` [PATCH v2 0/3] landlock: Refactor layer masks Mickaël Salaün
2026-02-06 7:32 ` Günther Noack
2026-02-06 7:49 ` Günther Noack
2026-02-06 11:24 ` Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260126.fd8c7b7537e1@gnoack.org \
--to=gnoack3000@gmail.com \
--cc=ivanov.mikhail1@huawei-partners.com \
--cc=konstantin.meskhidze@huawei.com \
--cc=linux-security-module@vger.kernel.org \
--cc=m@maowtm.org \
--cc=matthieu@buffet.re \
--cc=mic@digikod.net \
--cc=rdunlap@infradead.org \
--cc=samasth.norway.ananda@oracle.com \
--cc=utilityemal77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.