From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 661FD13AA2F; Mon, 26 Jan 2026 04:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769403441; cv=none; b=lvQIFRyyhdghuNMcadxuoCRvA9IUdWbimwQI5rrq+JyYFJfnV1Q7f7PN9yio6cKvjL+chUvsFhdsL/4tTvhxUvpTXOc3BB8JridV5MotZ+FTxpfW2JiNLmViH99KH1s4gINDWaPr7LeV3UAmO6GePqFyeCJtosQdaCYnbpKujUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769403441; c=relaxed/simple; bh=ajjpzkKmQYBaJ5yLJSgX4W0nod+etg3s5TaDWX1PUss=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FNlYCmwSNAZR2WM6rVhDgzv3HK8rPLFVWeQEHPezlfnULKZrCvjd2GyMNHI93h3fuv9JCFu5eFhYrEPKtv8/Br5si5Tx2GiRE7ILAaCLOczUNGabMUuu6J7tBJkqSNX4A1zwg6TL7VsN9Dqur1zFVMSwwvk4wMWjVdLvZ9+4fw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id F3EC3227A88; Mon, 26 Jan 2026 05:57:16 +0100 (CET) Date: Mon, 26 Jan 2026 05:57:16 +0100 From: "hch@lst.de" To: Chaitanya Kulkarni Cc: Chaitanya Kulkarni , "axboe@kernel.dk" , "agk@redhat.com" , "snitzer@kernel.org" , "mpatocka@redhat.com" , "song@kernel.org" , "yukuai@fnnas.com" , "hch@lst.de" , "sagi@grimberg.me" , "jaegeuk@kernel.org" , "chao@kernel.org" , "cem@kernel.org" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dm-devel@lists.linux.dev" , "linux-raid@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-xfs@vger.kernel.org" , "bpf@vger.kernel.org" , "Martin K . Petersen" , Johannes Thumshirn Subject: Re: [PATCH V3 4/6] nvmet: ignore discard return value Message-ID: <20260126045716.GA31683@lst.de> References: <20251124234806.75216-1-ckulkarnilinux@gmail.com> <20251124234806.75216-5-ckulkarnilinux@gmail.com> <942ad29c-cff3-458f-b175-0111de821970@nvidia.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <942ad29c-cff3-458f-b175-0111de821970@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Sat, Jan 24, 2026 at 09:35:16PM +0000, Chaitanya Kulkarni wrote: > On 11/24/25 15:48, Chaitanya Kulkarni wrote: > > __blkdev_issue_discard() always returns 0, making the error checking > > in nvmet_bdev_discard_range() dead code. > > > > Kill the function nvmet_bdev_discard_range() and call > > __blkdev_issue_discard() directly from nvmet_bdev_execute_discard(), > > since no error handling is needed anymore for __blkdev_issue_discard() > > call. > > > > Reviewed-by: Martin K. Petersen > > Reviewed-by: Johannes Thumshirn > > Reviewed-by: Christoph Hellwig > > Signed-off-by: Chaitanya Kulkarni > > --- > > Gentle ping on this, can we apply this patch ? Are we down to three patches now? Maybe resend the whole series and get ACKs to merge everything through the block layer? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8544C88E42 for ; Mon, 26 Jan 2026 04:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uFmy4qgvKdYZLKZ9Hdvo0yBRUUlV+TDjLMmML6XmhiU=; b=kaEMIaOlBdPvIMddogAJWGUv4v 4yYHH0wFZHwcFOd5a3+O6zt8Mt5rmC97DIQMJgkFAYlf6JxHeFM1/tqWgBnYdCuSHXSOE+/DSXi3O qAwbQz+IU17epaZJOjJ1X9I7ZvH3vBjV59mQ9WbxWB9CKelEtIf9V64riz/hiKrGm6Y8=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vkEfG-0002Bj-Kw; Mon, 26 Jan 2026 04:57:26 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vkEfF-0002Bd-7q for linux-f2fs-devel@lists.sourceforge.net; Mon, 26 Jan 2026 04:57:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CwxH6H2CfkT8iMZqvJXDnqSuSDUBr+iSR8mDT1/rG18=; b=j0/tBnUme2cMLPP52kVLr9CM7h aqSGpm3gIs1YCrX5vb6JXHGB0IRxlrelR4WpzD47+k/BbfKnLZ+cgjCv7AKWZjEmoU7oocqPal/V5 TDldpOzW8BHQBQ4+SphYTSvEDQgCnuzm4Z05DgaPb6evyxB2sjigDoCFvyJxEouf4zNw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CwxH6H2CfkT8iMZqvJXDnqSuSDUBr+iSR8mDT1/rG18=; b=b6whU8Yym1fMzkqVCbBwsxL5Zv fEt+K/3fKhJ+b3jOMll+wgirPHhMKyreeX5dsWFkPyEeWXeMnXSIRh08yi4DVe18/1bN4Xu54FCpx 3SGURKT6Yn3B2FtY/TL+Fp3lPXfX/jMGHpU5KMDM1P30Li7Ms61ibaz/0QB3OxaUVeYA=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vkEfE-0002EC-Nq for linux-f2fs-devel@lists.sourceforge.net; Mon, 26 Jan 2026 04:57:25 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id F3EC3227A88; Mon, 26 Jan 2026 05:57:16 +0100 (CET) Date: Mon, 26 Jan 2026 05:57:16 +0100 From: "hch@lst.de" To: Chaitanya Kulkarni Message-ID: <20260126045716.GA31683@lst.de> References: <20251124234806.75216-1-ckulkarnilinux@gmail.com> <20251124234806.75216-5-ckulkarnilinux@gmail.com> <942ad29c-cff3-458f-b175-0111de821970@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <942ad29c-cff3-458f-b175-0111de821970@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1vkEfE-0002EC-Nq Subject: Re: [f2fs-dev] [PATCH V3 4/6] nvmet: ignore discard return value X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "cem@kernel.org" , "linux-nvme@lists.infradead.org" , "song@kernel.org" , "hch@lst.de" , "agk@redhat.com" , "sagi@grimberg.me" , Chaitanya Kulkarni , "dm-devel@lists.linux.dev" , "snitzer@kernel.org" , "linux-raid@vger.kernel.org" , "mpatocka@redhat.com" , "jaegeuk@kernel.org" , "yukuai@fnnas.com" , "axboe@kernel.dk" , "linux-block@vger.kernel.org" , "Martin K . Petersen" , Johannes Thumshirn , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-xfs@vger.kernel.org" , "bpf@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Sat, Jan 24, 2026 at 09:35:16PM +0000, Chaitanya Kulkarni wrote: > On 11/24/25 15:48, Chaitanya Kulkarni wrote: > > __blkdev_issue_discard() always returns 0, making the error checking > > in nvmet_bdev_discard_range() dead code. > > > > Kill the function nvmet_bdev_discard_range() and call > > __blkdev_issue_discard() directly from nvmet_bdev_execute_discard(), > > since no error handling is needed anymore for __blkdev_issue_discard() > > call. > > > > Reviewed-by: Martin K. Petersen > > Reviewed-by: Johannes Thumshirn > > Reviewed-by: Christoph Hellwig > > Signed-off-by: Chaitanya Kulkarni > > --- > > Gentle ping on this, can we apply this patch ? Are we down to three patches now? Maybe resend the whole series and get ACKs to merge everything through the block layer? _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel