From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [koverstreet-bcachefs:bcachefs-rebalance_v2 458/799] fs/bcachefs/btree/commit.c:423 btree_key_can_insert_cached_slowpath() warn: inconsistent returns 'trans'.
Date: Tue, 27 Jan 2026 05:16:50 +0800 [thread overview]
Message-ID: <202601270519.oH8B4Zs8-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Kent Overstreet <kent.overstreet@linux.dev>
Hi Kent,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://github.com/koverstreet/bcachefs bcachefs-rebalance_v2
head: d4b3d00447faf8d4d95db47e3902e4ca4db8fbdc
commit: caf90d22262c52f7c29c4b08bd50f2a27d3dbe25 [458/799] bcachefs: move btree files to subdir
:::::: branch date: 3 months ago
:::::: commit date: 3 months ago
config: parisc-randconfig-r071-20260127 (https://download.01.org/0day-ci/archive/20260127/202601270519.oH8B4Zs8-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 10.5.0
smatch version: v0.5.0-8994-gd50c5a4c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202601270519.oH8B4Zs8-lkp@intel.com/
smatch warnings:
fs/bcachefs/btree/commit.c:423 btree_key_can_insert_cached_slowpath() warn: inconsistent returns 'trans'.
vim +/trans +423 fs/bcachefs/btree/commit.c
b0004d8dfac514 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2018-08-03 387
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 388 noinline static int
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 389 btree_key_can_insert_cached_slowpath(struct btree_trans *trans, unsigned flags,
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 390 struct btree_path *path, unsigned new_u64s)
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 391 {
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 392 struct bkey_cached *ck = (void *) path->l[0].b;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 393 struct bkey_i *new_k;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 394 int ret;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 395
0971a72c3d1a8b fs/bcachefs/btree_trans_commit.c Kent Overstreet 2024-12-24 396 bch2_trans_unlock_updates_write(trans);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 397 bch2_trans_unlock(trans);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 398
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 399 new_k = kmalloc(new_u64s * sizeof(u64), GFP_KERNEL);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 400 if (!new_k) {
09b9c72bd4b77a fs/bcachefs/btree_trans_commit.c Kent Overstreet 2025-05-28 401 struct bch_fs *c = trans->c;
09b9c72bd4b77a fs/bcachefs/btree_trans_commit.c Kent Overstreet 2025-05-28 402 bch_err(c, "error allocating memory for key cache key, btree %s u64s %u",
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 403 bch2_btree_id_str(path->btree_id), new_u64s);
09b9c72bd4b77a fs/bcachefs/btree_trans_commit.c Kent Overstreet 2025-05-28 404 return bch_err_throw(c, ENOMEM_btree_key_cache_insert);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 405 }
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 406
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 407 ret = bch2_trans_relock(trans) ?:
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 408 bch2_trans_lock_write(trans);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 409 if (unlikely(ret)) {
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 410 kfree(new_k);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 411 return ret;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 412 }
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 413
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 414 memcpy(new_k, ck->k, ck->u64s * sizeof(u64));
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 415
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 416 trans_for_each_update(trans, i)
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 417 if (i->old_v == &ck->k->v)
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 418 i->old_v = &new_k->v;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 419
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 420 kfree(ck->k);
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 421 ck->u64s = new_u64s;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 422 ck->k = new_k;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 @423 return 0;
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 424 }
09b0283ee23a02 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-11-05 425
:::::: The code at line 423 was first introduced by commit
:::::: 09b0283ee23a02094a43a9b93146d1060c58fc3a bcachefs: Make sure to drop/retake btree locks before reclaim
:::::: TO: Kent Overstreet <kent.overstreet@linux.dev>
:::::: CC: Kent Overstreet <kent.overstreet@linux.dev>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-01-26 21:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 21:16 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-14 16:05 [koverstreet-bcachefs:bcachefs-rebalance_v2 458/799] fs/bcachefs/btree/commit.c:423 btree_key_can_insert_cached_slowpath() warn: inconsistent returns 'trans' kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202601270519.oH8B4Zs8-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.