From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C4A4D2F005 for ; Tue, 27 Jan 2026 12:13:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B7E010E06D; Tue, 27 Jan 2026 12:13:42 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="qCo1SN+s"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EFF810E06D for ; Tue, 27 Jan 2026 12:13:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1769516018; bh=oqqg0Pbo+qsF9ziyceFNqX1tPDH0EYMWRA0h+inmXhw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qCo1SN+s02Dc8d9O8e10s1isKF9A4CUAt9O5TcEdV1BKtAoDRWiU9RvzGap97wnC4 fKy23UHBsEr7KyNoKxrLLT1ZkCWXoJiRNR5vCGcPWOgTR8rLERl7+Wv9QLgzEJRu4X xsZLJxBA9H/YEvfOEliG1LZd0jNBThfGRgEVisd+dlmJhnso8uOMpp5KnfqlP7m+8E 5x8SFQTjcAEvLA1dlLUznir7ak1UZIEK73CnTBalUpku4upfnxmtcwDCNLpi3Y6XYd X6ETIynwrTFRlhuzMj+Jc42MPVPGgwXSBHm4RDz+CI5EwXswB/yBrQy8Ghww02I10p TykstuYorLaIg== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 6E40817E0E3D; Tue, 27 Jan 2026 13:13:38 +0100 (CET) Date: Tue, 27 Jan 2026 13:13:34 +0100 From: Boris Brezillon To: Caterina Shablia Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , kernel@collabora.com, "Steven Price" , "Liviu Dudau" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm: add ARM interleaved 64k modifier Message-ID: <20260127131334.4e5a6226@fedora> In-Reply-To: <20260127110740.473562-1-caterina.shablia@collabora.com> References: <20260127110740.473562-1-caterina.shablia@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 27 Jan 2026 11:07:39 +0000 Caterina Shablia wrote: > This modifier is primarily intended to be used by panvk to implement > sparse partially-resident images with better map and unmap > performance, and no worse access performance, compared to > implementing them in terms of U-interleaved. > > With this modifier, the plane is divided into 64k byte 1:1 or 2:1 > -sided tiles. The 64k tiles are laid out linearly. Each 64k tile > is divided into blocks of 16x16 texel blocks each, which themselves > are laid out linearly within a 64k tile. Then within each such > 16x16 block, texel blocks are laid out according to U order, > similar to 16X16_BLOCK_U_INTERLEAVED. > > Unlike 16X16_BLOCK_U_INTERLEAVED, the layout does not depend on > whether a format is compressed or not. > > The hardware features corresponding to this modifier are available > starting with v10 (second gen Valhall.) > > The corresponding panvk MR can be found at: > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38986 > > Previous patch: > https://lists.freedesktop.org/archives/dri-devel/2026-January/546655.html > > Changes since v1: > > * Rewrite the description of the modifier to be hopefully unambiguous. > > Signed-off-by: Caterina Shablia Reviewed-by: Boris Brezillon > --- > include/uapi/drm/drm_fourcc.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index e527b24bd824..452f901513ad 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -1422,6 +1422,22 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier) > #define DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED \ > DRM_FORMAT_MOD_ARM_CODE(DRM_FORMAT_MOD_ARM_TYPE_MISC, 1ULL) > > +/* > + * ARM 64k interleaved modifier > + * > + * This is used by ARM Mali v10+ GPUs. With this modifier, the plane is divided > + * into 64k byte 1:1 or 2:1 -sided tiles. The 64k tiles are laid out linearly. > + * Each 64k tile is divided into blocks of 16x16 texel blocks, which are > + * themselves laid out linearly within a 64k tile. Then within each 16x16 > + * block, texel blocks are laid out according to U order, similar to > + * 16X16_BLOCK_U_INTERLEAVED. > + * > + * Note that unlike 16X16_BLOCK_U_INTERLEAVED, the layout does not change > + * depending on whether a format is compressed or not. > + */ > +#define DRM_FORMAT_MOD_ARM_INTERLEAVED_64K \ > + DRM_FORMAT_MOD_ARM_CODE(DRM_FORMAT_MOD_ARM_TYPE_MISC, 2ULL) > + > /* > * Allwinner tiled modifier > * > > base-commit: f08f665f8cda9520d98ee24545d306a92f386616