From: Jakub Kicinski <kuba@kernel.org>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Peter Korsgaard" <peter@korsgaard.com>,
"Petko Manolov" <petkan@nucleusys.com>,
"Steve Glendinning" <steve.glendinning@shawell.net>,
UNGLinuxDriver@microchip.com,
"Nikita Zhandarovich" <n.zhandarovich@fintech.ru>,
"Oliver Neukum" <oneukum@suse.com>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Deepanshu Kartikey" <kartikey406@gmail.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Max Schulze" <max.schulze@online.de>,
"Thomas Gleixner" <tglx@kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Kees Cook" <kees@kernel.org>,
"Eric Biggers" <ebiggers@google.com>
Subject: Re: [PATCH net-next v3] net: usb: remove unnecessary get_drvinfo code and driver versions
Date: Tue, 27 Jan 2026 18:58:56 -0800 [thread overview]
Message-ID: <20260127185856.7ff5d1a2@kernel.org> (raw)
In-Reply-To: <20260127060534.51206-1-enelsonmoore@gmail.com>
On Mon, 26 Jan 2026 22:04:38 -0800 Ethan Nelson-Moore wrote:
> Many USB network drivers define get_drvinfo functions which add no
> value over usbnet_get_drvinfo, only setting the driver name and
> version. usbnet_get_drvinfo automatically sets the driver name, and
> separate driver versions are now frowned upon in the kernel. Remove all
> driver versions and replace these get_drvinfo functions with references
> to usbnet_get_drvinfo where possible. Where that is not possible,
> remove unnecessary code to set the driver name. Also remove two
> unnecessary initializations from aqc111_get_drvinfo, an inaccurate
> comment in pegasus.c, and an unused macro in catc.c.
I slightly lost track of the conversations on your patches so forgive
a possibly obvious statement :) - but this did not apply cleanly to
net-next at the time of posting. So it needs a respin.
--
pw-bot: cr
prev parent reply other threads:[~2026-01-28 2:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 6:04 [PATCH net-next v3] net: usb: remove unnecessary get_drvinfo code and driver versions Ethan Nelson-Moore
2026-01-27 7:23 ` Andy Shevchenko
2026-01-27 7:43 ` Peter Korsgaard
2026-01-28 2:58 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127185856.7ff5d1a2@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=gustavoars@kernel.org \
--cc=kartikey406@gmail.com \
--cc=kees@kernel.org \
--cc=khalasa@piap.pl \
--cc=linux-usb@vger.kernel.org \
--cc=max.schulze@online.de \
--cc=mingo@kernel.org \
--cc=n.zhandarovich@fintech.ru \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=peter@korsgaard.com \
--cc=petkan@nucleusys.com \
--cc=steve.glendinning@shawell.net \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.