From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
<netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Gal Pressman <gal@nvidia.com>,
Moshe Shemesh <moshe@nvidia.com>
Subject: Re: [PATCH net 3/3] net/mlx5e: Account for netdev stats in ndo_get_stats64
Date: Tue, 27 Jan 2026 19:52:52 -0800 [thread overview]
Message-ID: <20260127195252.10fa054e@kernel.org> (raw)
In-Reply-To: <1769411695-18820-4-git-send-email-tariqt@nvidia.com>
On Mon, 26 Jan 2026 09:14:55 +0200 Tariq Toukan wrote:
> The driver's ndo_get_stats64 callback is only reporting mlx5 counters,
> without accounting for the netdev stats, causing errors from the network
> stack to be invisible in statistics.
I cooked up a patch to fix this generically in the core... but I can't
actually find any "errors from the network stack" that are accounted
to dev->stats. Could you be more specific about the issues you were
seeing?
next prev parent reply other threads:[~2026-01-28 3:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 7:14 [PATCH net 0/3] mlx5 misc fixes 2026-01-26 Tariq Toukan
2026-01-26 7:14 ` [PATCH net 1/3] net/mlx5: Fix Unbinding uplink-netdev in switchdev mode Tariq Toukan
2026-01-26 7:14 ` [PATCH net 2/3] net/mlx5e: TC, delete flows only for existing peers Tariq Toukan
2026-01-26 7:14 ` [PATCH net 3/3] net/mlx5e: Account for netdev stats in ndo_get_stats64 Tariq Toukan
2026-01-28 3:52 ` Jakub Kicinski [this message]
2026-01-28 11:28 ` Gal Pressman
2026-01-27 17:38 ` [PATCH net 0/3] mlx5 misc fixes 2026-01-26 Simon Horman
2026-01-28 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127195252.10fa054e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.