diff for duplicates of <202601272004.HnjloZC4-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index acce4c5..ad20069 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,12 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -TO: cros-kernel-buildreports@googlegroups.com - tree: https://android.googlesource.com/kernel/common android13-5.10 head: 8b96c137bec0cc9c414f85dc958b9a5785a0790f commit: d95bf22a4d1cbeebc288b87af27f0ea181a57218 [1/1] f2fs: introduce periodic iostat io latency traces -:::::: branch date: 16 hours ago -:::::: commit date: 4 years, 5 months ago config: x86_64-randconfig-161-20260126 (https://download.01.org/0day-ci/archive/20260127/202601272004.HnjloZC4-lkp@intel.com/config) compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710) smatch version: v0.5.0-8994-gd50c5a4c @@ -14,7 +8,7 @@ smatch version: v0.5.0-8994-gd50c5a4c If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <error27@gmail.com> +| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> | Closes: https://lore.kernel.org/r/202601272004.HnjloZC4-lkp@intel.com/ New smatch warnings: @@ -27,7 +21,6 @@ fs/f2fs/iostat.c:213 __update_iostat_latency() error: buffer overflow 'io_lat->p vim +210 fs/f2fs/iostat.c -d20508aceea564 Daeho Jeong 2021-08-19 182 d95bf22a4d1cbe Daeho Jeong 2021-08-20 183 static inline void __update_iostat_latency(struct bio_iostat_ctx *iostat_ctx, d95bf22a4d1cbe Daeho Jeong 2021-08-20 184 int rw, bool is_sync) d95bf22a4d1cbe Daeho Jeong 2021-08-20 185 { @@ -43,6 +36,9 @@ d95bf22a4d1cbe Daeho Jeong 2021-08-20 194 return; d95bf22a4d1cbe Daeho Jeong 2021-08-20 195 d95bf22a4d1cbe Daeho Jeong 2021-08-20 196 ts_diff = jiffies - iostat_ctx->submit_ts; d95bf22a4d1cbe Daeho Jeong 2021-08-20 197 if (iotype >= META_FLUSH) + +Should this be NR_PAGE_TYPE? The check is off by one. + d95bf22a4d1cbe Daeho Jeong 2021-08-20 198 iotype = META; d95bf22a4d1cbe Daeho Jeong 2021-08-20 199 d95bf22a4d1cbe Daeho Jeong 2021-08-20 200 if (rw == 0) { @@ -56,12 +52,15 @@ d95bf22a4d1cbe Daeho Jeong 2021-08-20 207 } d95bf22a4d1cbe Daeho Jeong 2021-08-20 208 d95bf22a4d1cbe Daeho Jeong 2021-08-20 209 spin_lock_irqsave(&sbi->iostat_lat_lock, flags); d95bf22a4d1cbe Daeho Jeong 2021-08-20 @210 io_lat->sum_lat[idx][iotype] += ts_diff; + + +Out of bounds if iotype is NR_PAGE_TYPE. + d95bf22a4d1cbe Daeho Jeong 2021-08-20 @211 io_lat->bio_cnt[idx][iotype]++; d95bf22a4d1cbe Daeho Jeong 2021-08-20 @212 if (ts_diff > io_lat->peak_lat[idx][iotype]) d95bf22a4d1cbe Daeho Jeong 2021-08-20 213 io_lat->peak_lat[idx][iotype] = ts_diff; d95bf22a4d1cbe Daeho Jeong 2021-08-20 214 spin_unlock_irqrestore(&sbi->iostat_lat_lock, flags); d95bf22a4d1cbe Daeho Jeong 2021-08-20 215 } -d95bf22a4d1cbe Daeho Jeong 2021-08-20 216 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index d0f33a8..ad7717b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,20 +1,15 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" "Subject\0[android-common:android13-5.10 1/1] fs/f2fs/iostat.c:210 __update_iostat_latency() error: buffer overflow 'io_lat->sum_lat[idx]' 3 <= 3\0" - "Date\0Tue, 27 Jan 2026 21:03:43 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Wed, 28 Jan 2026 14:29:05 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " cros-kernel-buildreports@googlegroups.com\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + " oe-kbuild-all@lists.linux.dev\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "TO: cros-kernel-buildreports@googlegroups.com\n" - "\n" "tree: https://android.googlesource.com/kernel/common android13-5.10\n" "head: 8b96c137bec0cc9c414f85dc958b9a5785a0790f\n" "commit: d95bf22a4d1cbeebc288b87af27f0ea181a57218 [1/1] f2fs: introduce periodic iostat io latency traces\n" - ":::::: branch date: 16 hours ago\n" - ":::::: commit date: 4 years, 5 months ago\n" "config: x86_64-randconfig-161-20260126 (https://download.01.org/0day-ci/archive/20260127/202601272004.HnjloZC4-lkp@intel.com/config)\n" "compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)\n" "smatch version: v0.5.0-8994-gd50c5a4c\n" @@ -22,7 +17,7 @@ "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <error27@gmail.com>\n" + "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" "| Closes: https://lore.kernel.org/r/202601272004.HnjloZC4-lkp@intel.com/\n" "\n" "New smatch warnings:\n" @@ -35,7 +30,6 @@ "\n" "vim +210 fs/f2fs/iostat.c\n" "\n" - "d20508aceea564 Daeho Jeong 2021-08-19 182 \n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 183 static inline void __update_iostat_latency(struct bio_iostat_ctx *iostat_ctx,\n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 184 \t\t\t\tint rw, bool is_sync)\n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 185 {\n" @@ -51,6 +45,9 @@ "d95bf22a4d1cbe Daeho Jeong 2021-08-20 195 \n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 196 \tts_diff = jiffies - iostat_ctx->submit_ts;\n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 197 \tif (iotype >= META_FLUSH)\n" + "\n" + "Should this be NR_PAGE_TYPE? The check is off by one.\n" + "\n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 198 \t\tiotype = META;\n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 199 \n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 200 \tif (rw == 0) {\n" @@ -64,15 +61,18 @@ "d95bf22a4d1cbe Daeho Jeong 2021-08-20 208 \n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 209 \tspin_lock_irqsave(&sbi->iostat_lat_lock, flags);\n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 @210 \tio_lat->sum_lat[idx][iotype] += ts_diff;\n" + "\n" + "\n" + "Out of bounds if iotype is NR_PAGE_TYPE.\n" + "\n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 @211 \tio_lat->bio_cnt[idx][iotype]++;\n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 @212 \tif (ts_diff > io_lat->peak_lat[idx][iotype])\n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 213 \t\tio_lat->peak_lat[idx][iotype] = ts_diff;\n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 214 \tspin_unlock_irqrestore(&sbi->iostat_lat_lock, flags);\n" "d95bf22a4d1cbe Daeho Jeong 2021-08-20 215 }\n" - "d95bf22a4d1cbe Daeho Jeong 2021-08-20 216 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -ad3a6c419f37371f480660e48b53d0cb49d790d7d74b78d87d5981834657ab9a +8ad0d505e742cc663e8487b7ae6fbc1b2c139be9380ae36768d3857ebb4c523e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.