From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jan Remmet <J.Remmet@phytec.de>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"upstream@lists.phytec.de" <upstream@lists.phytec.de>
Subject: Re: [PATCH] usb: typec: hd3ss3220: Check if regulator needs to be switched
Date: Tue, 27 Jan 2026 15:21:10 +0100 [thread overview]
Message-ID: <2026012754-trump-coziness-cda1@gregkh> (raw)
In-Reply-To: <1c36ebc4-9a37-4e88-a39f-e6472c0df11b@phytec.de>
On Mon, Jan 26, 2026 at 03:22:01PM +0000, Jan Remmet wrote:
> Am 26.01.26 um 15:32 schrieb Heikki Krogerus:
> > Mon, Jan 26, 2026 at 01:06:36PM +0100, Jan Remmet kirjoitti:
> >> Check regulator state as peripheral and detach can disable vbus.
> >> Without this check we will try to disable the regulator twice if
> >> we disconnect host and then connect as device.
> >>
> >> Signed-off-by: Jan Remmet <j.remmet@phytec.de>
> >> ---
> >> This is a fixup from
> >> - Link to v1: https://lore.kernel.org/r/20260115-wip-jremmet-hd3ss3220_vbus-v1-1-b7d9adfbe346@phytec.de
> >> To
> >> - Link to v2: https://lore.kernel.org/r/20260123-wip-jremmet-hd3ss3220_vbus-v2-1-bcad313ce92b@phytec.de
> >
> > I don't understand that, but I think you are fixing a commit in Greg's
> > tree, right?
> Yes
> >
> > If that's the case, then you need the Fixes tag.
>
> Sorry, I'm not familar with the workflow here. Should it be a "--fixup"
> git commit against the usb-next commit id?
>
> Or
> Fixes: 7e7025811579 ("usb: typec: hd3ss3220: Check if regulator needs to
> be switched")
>
> In the commit message (again with commit sha from Greg's usb-next
This one, Fixes: is the correct way to do it.
thanks,
greg k-h
prev parent reply other threads:[~2026-01-27 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 12:06 [PATCH] usb: typec: hd3ss3220: Check if regulator needs to be switched Jan Remmet
2026-01-26 14:32 ` Heikki Krogerus
2026-01-26 15:22 ` Jan Remmet
2026-01-27 14:21 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026012754-trump-coziness-cda1@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=J.Remmet@phytec.de \
--cc=heikki.krogerus@linux.intel.com \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.