All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Xingjing Deng <micro6947@gmail.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de,
	dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, Xingjing Deng <xjdeng@buaa.edu.cn>,
	stable@vger.kernel.org
Subject: Re: [PATCH v5] misc: fastrpc: check qcom_scm_assign_mem() return in rpmsg_probe
Date: Tue, 27 Jan 2026 08:10:41 +0100	[thread overview]
Message-ID: <2026012758-sacred-slouchy-45ca@gregkh> (raw)
In-Reply-To: <CAK+ZN9r+oCbSNjSf=yKQHGT9=Cqfw02J+TS3eZaUgrd=PfV7tA@mail.gmail.com>

On Tue, Jan 27, 2026 at 10:18:38AM +0800, Xingjing Deng wrote:
> I identified this issue through static program analysis. All other
> callers of this function validate its return value, so I believe a
> validation check should also be added here.

Please don't top-post :(

Anyway, you MUST properly document the tools used to find issues like
this in your changelog text, as our rules require.  Please do so.

thanks,

greg k-h

  parent reply	other threads:[~2026-01-27  7:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-17 14:03 [PATCH v5] misc: fastrpc: check qcom_scm_assign_mem() return in rpmsg_probe Xingjing Deng
2026-01-26 15:24 ` Greg KH
2026-01-26 20:53   ` Bjorn Andersson
2026-01-27  2:18     ` Xingjing Deng
2026-01-27  2:46       ` Bjorn Andersson
2026-01-27  7:10       ` Greg KH [this message]
2026-01-28  2:29         ` Xingjing Deng
2026-01-28  2:34           ` Xingjing Deng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026012758-sacred-slouchy-45ca@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=amahesh@qti.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=micro6947@gmail.com \
    --cc=srini@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=xjdeng@buaa.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.