All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
	"jgg@ziepe.ca" <jgg@ziepe.ca>
Subject: Re: [PATCH] RDMA/rxe: Fix race condition in QP timer handlers
Date: Wed, 28 Jan 2026 12:02:26 +0200	[thread overview]
Message-ID: <20260128100226.GB12149@unreal> (raw)
In-Reply-To: <02afa3a2-42d1-48c2-a75e-0555e8803d65@fujitsu.com>

On Tue, Jan 27, 2026 at 09:27:27AM +0000, Zhijian Li (Fujitsu) wrote:
> 
> 
> On 25/01/2026 22:08, Leon Romanovsky wrote:
> >> Ensure the QP's reference count is maintained and its validity is checked
> >> within the timer callbacks by adding calls to rxe_get(qp) and corresponding
> >> rxe_put(qp) after use.
> >>
> >> Signed-off-by: Li Zhijian<lizhijian@fujitsu.com>
> > Fixes line?
> 
> I believe the following `Fixes` tag is appropriate, as this commit introduced
> the WARN_ON that now triggers:
>   
> Fixes: d94671632572 ("RDMA/rxe: Rewrite rxe_task.c")
>   
> However, I'm not entirely certain if this race condition also existed
> before this commit, as it involved a significant rewrite.

Let's include the most recent fix. It is unlikely that anyone is still
running such an old version of RXE.

Thanks

> 
> Thanks
> Zhijian
> 
> > 
> > Thanks

  reply	other threads:[~2026-01-28 10:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20  7:44 [PATCH] RDMA/rxe: Fix race condition in QP timer handlers Li Zhijian
2026-01-21  5:04 ` Zhu Yanjun
2026-01-25 14:08 ` Leon Romanovsky
2026-01-25 21:24   ` Zhu Yanjun
2026-01-27  9:27   ` Zhijian Li (Fujitsu)
2026-01-28 10:02     ` Leon Romanovsky [this message]
2026-01-28 10:25 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260128100226.GB12149@unreal \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.