From: Jakub Kicinski <kuba@kernel.org>
To: Oliver Hartkopp via B4 Relay <devnull+socketcan.hartkopp.net@kernel.org>
Cc: socketcan@hartkopp.net, netdev@vger.kernel.org,
linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH net-next v4 0/6] move CAN skb headroom content to skb extensions
Date: Wed, 28 Jan 2026 17:41:37 -0800 [thread overview]
Message-ID: <20260128174137.65929694@kernel.org> (raw)
In-Reply-To: <20260128-can_skb_ext-v1-0-330f60fd5d7e@hartkopp.net>
On Wed, 28 Jan 2026 23:43:39 +0100 Oliver Hartkopp via B4 Relay wrote:
> CAN bus related skbuffs (ETH_P_CAN/ETH_P_CANFD/ETH_P_CANXL) simply contain
> CAN frame structs for CAN CC/FD/XL of skb->len length at skb->data. Those
> CAN skbs do not have network/mac/transport headers nor other such
> references for encapsulated protocols like ethernet/IP protocols.
>
> To store data for CAN specific use-cases all CAN bus related skbuffs are
> created with a 16 byte private skb headroom (struct can_skb_priv). Using
> the skb headroom and accessing skb->head for this private data led to
> several problems in the past likely due to "The struct can_skb_priv
> business is highly unconventional for the networking stack." [1]
>
> This patch set aims to remove the unconventional skb headroom usage for CAN
> bus related skbuffs and use the common skb extensions instead.
If you're targeting netdev trees please comply with our community
guidelines:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
--
pv-bot: 24h
prev parent reply other threads:[~2026-01-29 1:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 22:43 [PATCH net-next v4 0/6] move CAN skb headroom content to skb extensions Oliver Hartkopp
2026-01-28 22:43 ` Oliver Hartkopp via B4 Relay
2026-01-28 22:43 ` [PATCH net-next V4 1/6] can: use skb hash instead of private variable in headroom Oliver Hartkopp
2026-01-28 22:43 ` Oliver Hartkopp via B4 Relay
2026-01-28 22:43 ` [PATCH net-next V4 2/6] can: add CAN skb extension infrastructure Oliver Hartkopp
2026-01-28 22:43 ` Oliver Hartkopp via B4 Relay
2026-01-28 22:43 ` [PATCH net-next V4 3/6] can: move ifindex to CAN skb extensions Oliver Hartkopp
2026-01-28 22:43 ` Oliver Hartkopp via B4 Relay
2026-01-28 22:43 ` [PATCH net-next V4 4/6] can: move frame_len " Oliver Hartkopp
2026-01-28 22:43 ` Oliver Hartkopp via B4 Relay
2026-01-28 22:43 ` [PATCH net-next V4 5/6] can: remove private CAN skb headroom infrastructure Oliver Hartkopp
2026-01-28 22:43 ` Oliver Hartkopp via B4 Relay
2026-01-28 22:43 ` [PATCH net-next V4 6/6] can: gw: use can_gw_hops instead of sk_buff::csum_start Oliver Hartkopp
2026-01-28 22:43 ` Oliver Hartkopp via B4 Relay
2026-01-29 1:41 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128174137.65929694@kernel.org \
--to=kuba@kernel.org \
--cc=devnull+socketcan.hartkopp.net@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.