From: Jakub Kicinski <kuba@kernel.org>
To: "Marc Suñé" <marcdevel@gmail.com>
Cc: willemdebruijn.kernel@gmail.com, pabeni@redhat.com,
netdev@vger.kernel.org, dborkman@kernel.org,
vadim.fedorenko@linux.dev
Subject: Re: [PATCH net v2 2/4] selftests/net: add no ARP b/mcast,null poison test
Date: Wed, 28 Jan 2026 20:27:39 -0800 [thread overview]
Message-ID: <20260128202739.79af1bb8@kernel.org> (raw)
In-Reply-To: <713d6f1ca57b402be420ade1331acee4898675c4.1769464405.git.marcdevel@gmail.com>
On Tue, 27 Jan 2026 00:53:03 +0100 Marc Suñé wrote:
> Add a selftest to test that ARP bcast/mcast/null poisioning checks
> are never bypassed.
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 45c4ea381bc3..a765f1800752 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -9,6 +9,7 @@ CFLAGS += -I../
> TEST_PROGS := \
> altnames.sh \
> amt.sh \
> + arp_no_invalid_sha_poision.sh \
alphabetical sort pls
> arp_ndisc_evict_nocarrier.sh \
> arp_ndisc_untracked_subnets.sh \
> bareudp.sh \
> +readonly V4_ADDR0="10.0.10.1"
> +readonly V4_ADDR1="10.0.10.2"
> +readonly BCAST_MAC="ff:ff:ff:ff:ff:ff"
> +readonly MCAST_MAC="01:00:5e:00:00:00"
> +readonly NULL_MAC="00:00:00:00:00:00"
> +readonly VALID_MAC="02:01:02:03:04:05"
> +readonly ARP_REQ=1
> +readonly ARP_REPLY=2
> +nsid=100
unused? (please run shellcheck)
> +ret=0
> +veth0_ifindex=0
> +veth1_mac=
> diff --git a/tools/testing/selftests/net/arp_send.c b/tools/testing/selftests/net/arp_send.c
> new file mode 100644
Could you check if mausezahn from netsniff-ng can send these
packets already? We already depend on mausezahn for other tests.
Similar comments on patch 4, I'm not gonna repeat.
next prev parent reply other threads:[~2026-01-29 4:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 23:53 [PATCH net v2 0/4] discard ARP/NDP b/mcast/null announce (poison) Marc Suñé
2026-01-26 23:53 ` [PATCH net v2 1/4] arp: discard invalid sha addr (b/mcast ARP poison) Marc Suñé
2026-01-26 23:53 ` [PATCH net v2 2/4] selftests/net: add no ARP b/mcast,null poison test Marc Suñé
2026-01-29 4:27 ` Jakub Kicinski [this message]
2026-01-29 18:28 ` Marc Sune
2026-01-29 23:37 ` Jakub Kicinski
2026-01-26 23:53 ` [PATCH net v2 3/4] neigh: discard invalid lladdr (b/mcast poison) Marc Suñé
2026-01-29 4:24 ` [net,v2,3/4] " Jakub Kicinski
2026-01-26 23:53 ` [PATCH net v2 4/4] selftests/net: add no NDP b/mcast,null poison test Marc Suñé
2026-01-29 4:24 ` [PATCH net v2 0/4] discard ARP/NDP b/mcast/null announce (poison) Jakub Kicinski
2026-01-29 18:39 ` Marc Sune
2026-01-29 23:32 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2026-01-27 7:09 [PATCH net v2 2/4] selftests/net: add no ARP b/mcast,null poison test kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128202739.79af1bb8@kernel.org \
--to=kuba@kernel.org \
--cc=dborkman@kernel.org \
--cc=marcdevel@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.