From: Jakub Kicinski <kuba@kernel.org>
To: jan.petrous@oss.nxp.com
Cc: Jakub Kicinski <kuba@kernel.org>,
edumazet@google.com, shawnguo@kernel.org, kernel@pengutronix.de,
krzk+dt@kernel.org, robh@kernel.org, andrew+netdev@lunn.ch,
mbrugger@suse.com, davem@davemloft.net, pabeni@redhat.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
s32@nxp.com, imx@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com, s.hauer@pengutronix.de,
conor+dt@kernel.org, chester62515@gmail.com, festevam@gmail.com,
mcoquelin.stm32@gmail.com, ghennadi.procopciuc@oss.nxp.com,
devicetree@vger.kernel.org, alexandre.torgue@foss.st.com
Subject: Re: [v4,4/4] stmmac: s32: enable support for Multi-IRQ mode
Date: Wed, 28 Jan 2026 21:10:04 -0800 [thread overview]
Message-ID: <20260129051004.375682-1-kuba@kernel.org> (raw)
In-Reply-To: <20260128-dwmac_multi_irq-v4-4-82fa34fcf2f2@oss.nxp.com>
This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
stmmac: s32: enable support for Multi-IRQ mode
Enables Multi-IRQ mode for the S32 GMAC driver when per-queue IRQs
are present and more than one RX queue is configured.
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c
> index 5a485ee98fa7..37a5b7b46973 100644
[ ... ]
> @@ -149,6 +149,16 @@ static int s32_dwmac_probe(struct platform_device *pdev)
> plat->core_type = DWMAC_CORE_GMAC4;
> plat->pmt = 1;
> plat->flags |= STMMAC_FLAG_SPH_DISABLE;
> +
> + /* Check for multi-IRQ config. Assumption: symetrical rx/tx queues */
^^^^^^^^^^
This isn't a bug, but "symetrical" should be "symmetrical".
next prev parent reply other threads:[~2026-01-29 5:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 8:49 [PATCH v4 0/4] Support multi-channel IRQs in stmmac platform drivers Jan Petrous (OSS)
2026-01-28 8:49 ` Jan Petrous via B4 Relay
2026-01-28 8:49 ` [PATCH v4 1/4] net: stmmac: platform: read channels irq Jan Petrous (OSS)
2026-01-28 8:49 ` Jan Petrous via B4 Relay
2026-01-29 5:09 ` [v4,1/4] " Jakub Kicinski
2026-02-23 13:32 ` Jan Petrous
2026-01-28 8:49 ` [PATCH v4 2/4] dt-bindings: net: nxp,s32-dwmac: Declare per-queue interrupts Jan Petrous (OSS)
2026-01-28 8:49 ` Jan Petrous via B4 Relay
2026-01-29 16:51 ` Rob Herring (Arm)
2026-01-28 8:49 ` [PATCH v4 3/4] arm64: dts: s32: set Ethernet channel irqs Jan Petrous (OSS)
2026-01-28 8:49 ` Jan Petrous via B4 Relay
2026-01-28 8:49 ` [PATCH v4 4/4] stmmac: s32: enable support for Multi-IRQ mode Jan Petrous (OSS)
2026-01-28 8:49 ` Jan Petrous via B4 Relay
2026-01-29 5:10 ` Jakub Kicinski [this message]
2026-02-23 13:34 ` [v4,4/4] " Jan Petrous
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129051004.375682-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=chester62515@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=jan.petrous@oss.nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mbrugger@suse.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.