From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, "Chengwen Feng" <fengchengwen@huawei.com>,
"Nicolas Chautru" <nicolas.chautru@intel.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Ori Kam" <orika@nvidia.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Jerin Jacob" <jerinj@marvell.com>,
"Amit Prakash Shukla" <amitprakashs@marvell.com>,
"Vladimir Medvedkin" <vladimir.medvedkin@intel.com>,
"Kiran Kumar K" <kirankumark@marvell.com>,
"Nithin Dabilpuram" <ndabilpuram@marvell.com>,
"Zhirun Yan" <yanzhirun_163@163.com>,
"Yipeng Wang" <yipeng1.wang@intel.com>,
"Sameh Gobriel" <sameh.gobriel@intel.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Pavan Nikhilesh" <pbhagavatula@marvell.com>,
"Paul Szczepanek" <paul.szczepanek@arm.com>
Subject: Re: [PATCH] lib: remove extra characters ending comment blocks
Date: Thu, 29 Jan 2026 12:14:14 -0800 [thread overview]
Message-ID: <20260129121414.6aa40db0@phoenix.local> (raw)
In-Reply-To: <20260129144749.3637111-1-thomas@monjalon.net>
On Thu, 29 Jan 2026 15:47:48 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:
> At the end of a comment, no need for an extra line.
>
> This pattern was fixed with the following command:
> git ls lib | xargs sed -i '/^ *\* *$/{N;/ *\*\/ *$/D;}'
>
> A comment should always be terminated with */
>
> Extra asterisks were found with this command:
> git grep '\* *\*/' lib
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Should look at examples and drivers as well.
Maybe add this to the AGENTS auto review script.
next prev parent reply other threads:[~2026-01-29 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 14:47 [PATCH] lib: remove extra characters ending comment blocks Thomas Monjalon
2026-01-29 14:52 ` Morten Brørup
2026-01-29 20:14 ` Stephen Hemminger [this message]
2026-02-04 20:34 ` Thomas Monjalon
2026-01-30 1:22 ` fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129121414.6aa40db0@phoenix.local \
--to=stephen@networkplumber.org \
--cc=amitprakashs@marvell.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=ndabilpuram@marvell.com \
--cc=nicolas.chautru@intel.com \
--cc=orika@nvidia.com \
--cc=paul.szczepanek@arm.com \
--cc=pbhagavatula@marvell.com \
--cc=sameh.gobriel@intel.com \
--cc=thomas@monjalon.net \
--cc=vladimir.medvedkin@intel.com \
--cc=yanzhirun_163@163.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.