From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFE511624D5 for ; Thu, 29 Jan 2026 13:36:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693790; cv=none; b=sxAXdlQqisKUjcVPJ0XBQyG2lvNjSMx/j0Sc2OZb9O1z5pz9/V7XET21WZYyxDADtU2/eFYAeeOPLtt8WEpD+28xdwbZU0AAx5A/y3xMmxL+KzpdGN33IKJlU2jZSt2k6Iy4AxaDY8CAUaj6GWEh/CescY7Wk4y88GmPFd7ajmY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769693790; c=relaxed/simple; bh=qyAYWeiCIFUv53I++zWQ9LqTF8vB8YxhXmCA6up9BFM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O8tviG+HG0EV0saPMZy8AsCndL1ZAIfHsXZwN1SRnuRu7vRnTpSD+FPp3mAezs604Tm+GiIaZj+miYpJMET9wPG1Ug5It4As0NEOLdR43dySAQL9mKhQbZ+Yl0fqLrdZZ+DR4GTM1o7B4zoPaUufJUMOO2Tagr0o24VJviiCnFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VRwp9gGC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VRwp9gGC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57183C116D0; Thu, 29 Jan 2026 13:36:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769693790; bh=qyAYWeiCIFUv53I++zWQ9LqTF8vB8YxhXmCA6up9BFM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VRwp9gGC9k4DiGMUtlQR+/6qRdWqe7wNK6IrttF1BajFP4Zk6BthjpUVAYlJRZiAX Siq/eK6ts9DPoe07I7b4TiinN/747/c8VU8nEaH0bSP4eVG2wEqmys6HjKikQXtFiV qBDHvLLIX3v7Ak3K+4dYFafVroxPQgWzi2Jc4Pn4uQesUglS4qJs3SNoB9E6hXjqHS Ee+E3rL2Rlxcf88Q3sieza+LjcbBmaYItwVqIO8T16njInJMgXckdcSLibUe5XkcGJ wzhmG1/f1TCjRgGzSVr0LGFKX/TOwcEDTDUBpMh3LIueuCwVNoyzf9n7U3BHMwcfxi qGFlWHbyqEyiQ== Date: Thu, 29 Jan 2026 15:36:25 +0200 From: Leon Romanovsky To: Pavan Chebbi Cc: jgg@ziepe.ca, michael.chan@broadcom.com, linux-kernel@vger.kernel.org, dave.jiang@intel.com, saeedm@nvidia.com, Jonathan.Cameron@huawei.com, gospo@broadcom.com, selvin.xavier@broadcom.com, kalesh-anakkur.purayil@broadcom.com Subject: Re: [PATCH v2 fwctl 3/5] fwctl/bnxt_en: Create an aux device for fwctl Message-ID: <20260129133625.GK10992@unreal> References: <20260126053710.3474483-1-pavan.chebbi@broadcom.com> <20260126053710.3474483-4-pavan.chebbi@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260126053710.3474483-4-pavan.chebbi@broadcom.com> On Sun, Jan 25, 2026 at 09:37:08PM -0800, Pavan Chebbi wrote: > Create an additional auxiliary device to support fwctl. > The next patch will create bnxt_fwctl and bind to this > device. > > Reviewed-by: Andy Gospodarek > Signed-off-by: Pavan Chebbi > --- > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 12 ++++++++++-- > include/linux/bnxt/ulp.h | 1 + > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c > index 4cdfc9641639..13159c0515bb 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c > @@ -62,6 +62,8 @@ static bool bnxt_auxdev_is_active(struct bnxt *bp, int idx) > > static struct bnxt_aux_device bnxt_aux_devices[__BNXT_AUXDEV_MAX] = {{ > .name = "rdma", > +}, { > + .name = "fwctl", > }}; I would expect the name to be part of auxiliary_driver initialization and not dynamically added. 5113 static struct auxiliary_driver mlx5r_driver = { 5114 .name = "rdma", 5115 .probe = mlx5r_probe, 5116 .remove = mlx5r_remove, 5117 .id_table = mlx5r_id_table, 5118 }; Thanks