From: Jakub Kicinski <kuba@kernel.org>
To: Cosmin Ratiu <cratiu@nvidia.com>
Cc: Tariq Toukan <tariqt@nvidia.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Gal Pressman <gal@nvidia.com>, Moshe Shemesh <moshe@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
"horms@kernel.org" <horms@kernel.org>,
"leon@kernel.org" <leon@kernel.org>
Subject: Re: [PATCH net V2 2/4] net/mlx5: Fix deadlock between devlink lock and esw->wq
Date: Thu, 29 Jan 2026 15:40:24 -0800 [thread overview]
Message-ID: <20260129154024.3915c3bf@kernel.org> (raw)
In-Reply-To: <d52714243592921c08175aa742f32ae56e4f6651.camel@nvidia.com>
On Thu, 29 Jan 2026 10:33:40 +0000 Cosmin Ratiu wrote:
> > This is quite an ugly hack, is there no way to avoid the flush and
> > let
> > the work discover that what it was supposed to do is no longer
> > needed?
>
> Not possible, unfortunately. I stared at it for quite a while. The wq
> is flushed because the esw is being unconfigured, which removes data
> structs the work handler uses. Flushing the work is required, otherwise
> we'll run into worse issues.
And having a refount on (I presume) struct mlx5_esw_functions
so that work can hold a ref is not an option?
Are you planning to revisit this in -next?
next prev parent reply other threads:[~2026-01-29 23:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 8:52 [PATCH net V2 0/4] mlx5 misc fixes 2026-01-27 Tariq Toukan
2026-01-27 8:52 ` [PATCH net V2 1/4] net/mlx5: fs, Fix inverted cap check in tx flow table root disconnect Tariq Toukan
2026-01-27 8:52 ` [PATCH net V2 2/4] net/mlx5: Fix deadlock between devlink lock and esw->wq Tariq Toukan
2026-01-29 4:56 ` Jakub Kicinski
2026-01-29 10:33 ` Cosmin Ratiu
2026-01-29 23:40 ` Jakub Kicinski [this message]
2026-02-02 14:48 ` Cosmin Ratiu
2026-02-03 0:29 ` Jakub Kicinski
2026-01-27 8:52 ` [PATCH net V2 3/4] net/mlx5: Fix vhca_id access call trace use before alloc Tariq Toukan
2026-01-27 8:52 ` [PATCH net V2 4/4] net/mlx5e: Skip ESN replay window setup for IPsec crypto offload Tariq Toukan
2026-01-29 5:00 ` [PATCH net V2 0/4] mlx5 misc fixes 2026-01-27 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129154024.3915c3bf@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.